On Mon, 6 Jan 2025 21:20:58 GMT, Chen Liang <li...@openjdk.org> wrote:
>> `javax.lang.model.SourceVersion` has a series of comments describing the new >> language features present in each source version. Similar comments for the >> `ClassFileFormatVersion` would be helpful, so readers no longer need to >> search through the JVMS to find changes in new versions. > > Chen Liang has updated the pull request incrementally with one additional > commit since the last revision: > > Add JEP/JSR numbers, clarify if something is attribute/modifier/etc. src/java.base/share/classes/java/lang/reflect/ClassFileFormatVersion.java line 58: > 56: * 2: ACC_STRICT modifier > 57: * 3: no changes > 58: * 4: no changes The version mapping can be tricky here: is "1" 1.0 plus 1.1? I presume "2" is 1.2, "3" is 1.3.x, "4" is 1.4.x Might be useful to include the actual JVMS classfile version numbers for ease of reference back to JVMS. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22934#discussion_r1904892789
