On Thu, 28 Nov 2024 01:54:10 GMT, Kim Barrett <kbarr...@openjdk.org> wrote:
>> David Holmes has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update src/java.base/share/native/libjava/NativeLibraries.c
>>
>> Co-authored-by: Alex Menkov <69548902+alexmen...@users.noreply.github.com>
>
> src/java.base/share/native/libjava/NativeLibraries.c line 88:
>
>> 86: if (cname != NULL) {
>> 87: strcat(jniFunctionName, "_");
>> 88: strcat(jniFunctionName, cname);
>
> Should be using 4-space indentation, rather than HotSpot's 2 space
> indentation.
Good catch! Thanks for reviewing Kim.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22380#discussion_r1861426578
