On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 12 Nov 2024 15:02:12 GMT, Sean Mullan wrote:
>> I can add it back if it is more convenient and readable to have the `@see`
>> tag.
>
> This can be taken care of later after integration.
Agreed!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1838282
On Fri, 8 Nov 2024 21:01:57 GMT, Phil Race wrote:
>>> I'd not looked at this test before but when I do the thing I noticed is
>>> that createPrivateValue is no longer used. But I don't see a problem with
>>> keeping the rest of the test.
>>
>> @prrace Do I understand correctly that _“`createPr
On Tue, 29 Oct 2024 17:06:08 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/MouseInfo.java line 68:
>>
>>> 66: * @throws SecurityException if a security manager exists and its
>>> 67: *{@code checkPermission} method doesn't allow the
>>> operation
>
On Tue, 29 Oct 2024 12:56:25 GMT, Sean Mullan wrote:
>> test/jdk/javax/xml/crypto/dsig/keyinfo/KeyInfo/Marshal.java line 30:
>>
>>> 28: * @modules java.xml.crypto/org.jcp.xml.dsig.internal.dom
>>> 29: * @compile -XDignore.symbol.file Marshal.java
>>> 30: * @run main/othervm/java.security.poli
On Mon, 28 Oct 2024 14:35:57 GMT, Sean Mullan wrote:
>> That and possibly rename the test because now it does not have anything to
>> do with the SecurityException. Now we only check that providing an empty
>> file causes the InvalidMidiDataException so EmptySoundBankTest or something
>> to th
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 30 Oct 2024 19:28:32 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 20:57:50 GMT, Sean Mullan wrote:
>> @honkar-jdk I'm inclined to leave it as because it's not the only method
>> which doesn't have a blank line between `@param` and `@throw` in this file.
>>
>> If it's worth taking care of, we may submit another bug to address it later.
>
>
On Mon, 28 Oct 2024 18:07:26 GMT, Harshitha Onkar wrote:
>> I'd not looked at this test before but when I do the thing I noticed is that
>> createPrivateValue is no longer used.
>> But I don't see a problem with keeping the rest of the test.
>
> Test updated in sandbox -
> https://github.com/op
On Mon, 28 Oct 2024 14:08:46 GMT, Sean Mullan wrote:
>> src/java.desktop/share/classes/java/awt/Font.java line 1612:
>>
>>> 1610: * obtained. The {@code String} value of this property is then
>>> 1611: * interpreted as a {@code Font} object according to the
>>> 1612: * specificat
On Fri, 25 Oct 2024 18:30:23 GMT, Harshitha Onkar wrote:
>> The updated test `bug6694823.java` works correctly on Windows and displays
>> its popup over the Windows taskbar — it is expected.
>>
>> The popup had to be moved if the security manager didn't allow to call
>> `setAlwaysOnTop(true)`.
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 17:30:56 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41:
>>
>>> 39: * @bug 6694823
>>> 40: * @summary Checks that popup menu cannot be partially hidden
>>> 41: * by the task bar.
>>
>> I believe this test is irrelev
On Fri, 25 Oct 2024 15:29:40 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/UIDefaults/6622002/bug6622002.java line 1:
>>
>>> 1: /*
>>
>> Again, I'm unsure this test has a value after the security manager is
>> removed. All it ver
On Fri, 25 Oct 2024 15:12:00 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486&
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 21:06:23 GMT, Harshitha Onkar wrote:
>>> It was missed when `-Djava.security.manager=allow` was removed.
>>
>> It wasn't intentional then, was it?
>>
>>> Out of curiosity: does it have any impact on the performance of CI testing
>>> if tests are run in /othervm mode when it
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Wed, 23 Oct 2024 02:56:30 GMT, Prasanta Sadhukhan
wrote:
>> Agreed. This is not a "clean up / update tests" task.
>> If it is a change on some lines of code that are updated by the SM changes,
>> then that's fair game, but otherwise only the SM behaviour is part of this
>> task.
>> Anything
On Thu, 24 Oct 2024 18:09:04 GMT, Harshitha Onkar wrote:
>> src/java.desktop/share/classes/java/awt/Desktop.java line 713:
>>
>>> 711: * {@code Info.plist}.
>>> 712: *
>>> 713: * @param printFileHandler handler
>>
>> Suggestion:
>>
>> * @param printFileHandler handler
>>
On Thu, 24 Oct 2024 17:58:55 GMT, Harshitha Onkar wrote:
> It was missed when `-Djava.security.manager=allow` was removed.
It wasn't intentional then, was it?
> Out of curiosity: does it have any impact on the performance of CI testing if
> tests are run in /othervm mode when it is not needed?
On Wed, 11 Sep 2024 09:19:21 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Tue, 10 Sep 2024 11:10:38 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this trivial change which replaces the usages
>> of `-mx` and `-ms` to `-Xmx` and `-Xms` in tests and in one code comment?
>>
>> As noted in https://bugs.openjdk.org/browse/JDK-8339834, these options are
>> o
On Thu, 15 Aug 2024 08:28:24 GMT, Pavel Rappo wrote:
>> This PR fixes a few trivial grammar issues and typos in documentation.
>>
>> The main issue is the use of the word "timeout". To my mind, timeout, a
>> duration, is not the same as deadline, which is a point in time, an instant,
>> which
On Mon, 22 Apr 2024 17:38:59 GMT, Jonathan Gibbons wrote:
> The document [How to Write Doc Comments for the Javadoc
> Tool](https://www.oracle.com/uk/technical-resources/articles/java/javadoc-tool.html)
> is depressingly obsolete, as indicated by this text towards the end:
I know. Yet there's
On Fri, 19 Apr 2024 19:18:31 GMT, Jonathan Gibbons wrote:
> We do not have an overall style guide. The conventional wisdom for editing
> any existing file is to follow the style in that file, if such a style can be
> discerned.
That's what I do.
I saw either style used in JDK. Yet I didn't ch
h one
> additional commit since the last revision:
>
> Update
> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
>
> Fix grammatical typo
>
> Co-authored-by: Alexey Ivanov
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18846#pullrequestreview-2012219677
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or imp
On Thu, 1 Feb 2024 11:57:04 GMT, Magnus Ihse Bursie wrote:
> This is a follow-up on
> [JDK-8324053](https://bugs.openjdk.org/browse/JDK-8324053). I have run the
> bin/blessed-modifier-order.sh on the entire code base, and manually checked
> the result. I have reverted all but these trivial and
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 18:14:21 GMT, Phil Race wrote:
>> That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`:
>> to document that it's *an applet test* — with the html file being the test
>> starter.
>
> Ok, although when I see something like that it looks more like a bug to
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:48:52 GMT, Phil Race wrote:
>> I see `SetOrient.java` has its sibling `SetOrient.html` where you added
>> `@key printer`.
>>
>> Since both files contain all the tags except for `@test` in the .java file,
>> you should not remove the `@run` tag from the .java file and add
On Mon, 27 Nov 2023 20:20:38 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Mon, 27 Nov 2023 18:53:24 GMT, Phil Race wrote:
> I can .. but I am not aware of even a convention to do that ordering.
It's not written anywhere as far as I know. There's [an ongoing
discussion](https://github.com/openjdk/jdk/pull/16674#discussion_r1402082665)
about it in #16674.
https://
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
test/jdk/java/awt/print/PrinterJob/PrintAllFon
On Thu, 23 Nov 2023 11:27:08 GMT, Alexey Ivanov wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test
On Thu, 23 Nov 2023 11:53:08 GMT, Alexey Ivanov wrote:
> Having said the above, this test requires its own bug to fix the test.
I submitted [JDK-8320671](https://bugs.openjdk.org/browse/JDK-8320671):
PageFormat/SmallPaperPrinting.java needs three sets of @test tags
-
PR Rev
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Changes requested by aivanov (Reviewer).
test
On Tue, 5 Sep 2023 22:49:41 GMT, Erik Joelsson wrote:
> There are a number of files in the `test` directory that have an incorrect
> copyright header, which includes the "classpath" exception text. This patch
> removes that text from all test files that I could find it in. I did this
> using a
On Thu, 8 Jun 2023 11:20:05 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix the code that is actually warning
>
> I'll take a look… hopefully next week.
> starts to break on existing code
>
> Julian Waters has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Leave nullptr for another day
> - src/java.desktop/windows/native/libawt/windows/ShellFolder2.cpp
>
>
On Fri, 23 Jun 2023 17:09:12 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Fri, 23 Jun 2023 14:30:49 GMT, Julian Waters wrote:
>> To minimise the number of changes, we can go for using `jint` in
>> `AwtMenu::GetItem`.
>>
>> What do you thing, @djelinski and @TheShermanTanker?
>
> Hmm, I lean towards jint as I feel it conveys the fact that it is a Java
> parameter
On Fri, 23 Jun 2023 14:24:44 GMT, Alexey Ivanov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76:
>>
>>> 74: /*for multifont menu */
>>> 75: BOOL IsTopMenu();
>>> 76: virtual AwtMenuItem* GetItem(jobject target, int
On Fri, 23 Jun 2023 00:16:45 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_MenuBar.cpp line 148:
>>
>>> 146: }
>>> 147:
>>> 148: AwtMenuItem* AwtMenuBar::GetItem(jobject target, jint index)
>>
>> What is the reason for using `jint` instead of `int`?
>>
>> The
On Fri, 23 Jun 2023 06:10:05 GMT, Daniel Jeliński wrote:
>> Julian Waters has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Revert wrong Copyright
>> - Copyright
>
> src/java.desktop/windows/native/libawt/windows/awt_Menu.h line 76:
>
On Thu, 22 Jun 2023 19:33:17 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "GetDIBits should take an LPVOID"
>>
>> This reverts c
On Thu, 25 May 2023 01:30:34 GMT, David Holmes wrote:
>> Julian Waters has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert "GetDIBits should take an LPVOID"
>>
>> This reverts commit 7dbe5dea84b1afb2235b66da581bcd3c1da4d6ac.
>
>
On Thu, 22 Jun 2023 14:40:23 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Tue, 13 Jun 2023 10:11:28 GMT, Pavel Rappo wrote:
>> Please review this long-awaited change to documentation inheritance.
>>
>> This change improves "methods comment algorithm" and introduces directed
>> documentation inheritance. While "methods comment algorithm" -- automatic
>> search for
On Thu, 8 Jun 2023 15:51:22 GMT, Pavel Rappo wrote:
>> Copying an individual doc element using `{@inheritDoc}` never adds meta
>> information on the generated HTML page to indicate where that doc element
>> was copied from. It so happens in this particular case that the doc
>> element's conten
On Thu, 8 Jun 2023 11:29:44 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/util/concurrent/LinkedBlockingDeque.java
>> line 635:
>>
>>> 633: * @return {@inheritDoc BlockingDeque}
>>> 634: */
>>> 635: public boolean offer(E e) {
>>
>> Does this work for @param tags to
On Thu, 1 Jun 2023 11:49:24 GMT, Julian Waters wrote:
>> On Windows, the basic Java Integer types are defined as long and __int64
>> respectively. In particular, the former is rather problematic since it
>> breaks compilation as the Visual C++ becomes stricter and more compliant
>> with every
On Fri, 3 Mar 2023 10:09:27 GMT, Claes Redestad wrote:
> Yes, iff means if-and-only-if and is used for extra precision in formal
> logic, mathematics.
I've never come across it before. With your explanations, it makes perfect
sense.
-
PR: https://git.openjdk.org/jdk/pull/12826
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the observable effect on the ge
On Wed, 4 Jan 2023 16:35:41 GMT, Michael Ernst wrote:
>> 8299563: Fix typos
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains ten commits:
>
> - Address review feedback
> - Merge ../jdk-openjdk into typos-typos
>
On Wed, 21 Dec 2022 21:48:24 GMT, Harshitha Onkar wrote:
>> *Headful* tests are not supposed concurrently: they display UI and often use
>> Robot to send input events to the UI. Running such tests concurrently leads
>> to obscure failures. In our CI system, `JTREG_JOBS=1` is passed to `make`
>
On Tue, 20 Dec 2022 23:25:30 GMT, Harshitha Onkar wrote:
> ViewportOverlapping was failing intermittently on Windows (Win10 & 11). Added
> robot.setAutoWaitForIdle() to ViewportOverlapping and its base class
> (OverlappingTestBase) to stabilize the test.
>
> Additionally added awt & swings tes
On Wed, 21 Dec 2022 17:25:20 GMT, Harshitha Onkar wrote:
>> test/jdk/TEST.ROOT line 36:
>>
>>> 34: com/sun/net/httpserver/simpleserver \
>>> 35: java/awt \
>>> 36: javax/swing
>>
>> Hello Harshitha, I don't have any knowledge of the client area, but I see
>> that there are a large number of te
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Mon, 24 Oct 2022 19:29:41 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
>>
>>This reverts commit c91fdaa19dc06351598bd1c061
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate t
68 matches
Mail list logo
