On Tue, 29 Oct 2024 12:56:25 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> test/jdk/javax/xml/crypto/dsig/keyinfo/KeyInfo/Marshal.java line 30: >> >>> 28: * @modules java.xml.crypto/org.jcp.xml.dsig.internal.dom >>> 29: * @compile -XDignore.symbol.file Marshal.java >>> 30: * @run main/othervm/java.security.policy==test.policy Marshal >> >> With this change, the test now only compiles but doesn't run the test. It >> could be a bug in jtreg since it is supposed to default to running the test >> as "run main <test>" when there is no @run tag. In any case, the @compile >> line is no longer necessary, so I will remove that, and then the test will >> be run again. >> >> Also, missing a copyright update, will fix. > > Fixed in > https://github.com/openjdk/jdk/pull/21498/commits/548eb9e2eb3f586bbb620d5357fe3e5665aeb505 > With this change, the test now only compiles but doesn't run the test. It > could be a bug in jtreg since it is supposed to default to running the test > as "run main " when there is no @run tag. In any case, the @compile line is > no longer necessary, so I will remove that, and then the test will be run > again. I guess it's the intended behaviour, jtreg implies `@run` if there are no other commands; you have to provide `@run` explicitly if there are `@compile` or `@build` tags. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1826256418
