On Wed, 23 Oct 2024 02:56:30 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Agreed. This is not a "clean up / update tests" task. >> If it is a change on some lines of code that are updated by the SM changes, >> then that's fair game, but otherwise only the SM behaviour is part of this >> task. >> Anything that is not needed to be changed for that purpose, can (and mostly >> should) be left alone. > > I know this is not relevant to SM and would not have pointed it out had it > not been modified in the PR.. > In some tests as I am going to point out below, the order is changed > intentionally even though it does not have anything to do with SM, all I am > asking it to restore it back in those tests (and since it will look odd to > have different order in different tests, I generalize it all for all > javax_swing tests in this PR which is what I reviewed) > I think we have finally decided that jtreg tag will come after copyright and > before imports...Applicable for all modified javax_swing tests in this PR... Did we agree on that? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1815457993
