On Mon, 26 Sep 2022 16:51:36 GMT, Michael Ernst <mer...@openjdk.org> wrote:
>> 8294321: Fix typos in files under test/jdk/java, test/jdk/jdk, test/jdk/jni
>
> Michael Ernst has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains six commits:
>
> - Reinstate typos in Apache code that is copied into the JDK
> - Merge ../jdk-openjdk into typos-typos
> - Remove file that was removed upstream
> - Fix inconsistency in capitalization
> - Undo change in zlip
> - Fix typos
Changes requested by aivanov (Reviewer).
src/hotspot/share/opto/memnode.cpp line 2365:
> 2363: if (x != this) return x;
> 2364:
> 2365: // Take apart the address into an oop and offset.
“and _an_ offset”?
src/java.xml/share/classes/org/w3c/dom/Document.java line 293:
> 291: * <code>systemId</code>, and <code>notationName</code> attributes
> are
> 292: * copied. If a <code>deep</code> import is requested, the
> descendants
> 293: * of the source <code>Entity</code> are recursively imported and
This class may come from a 3rd party library. Anyone from `java.xml` can
confirm it?
test/hotspot/jtreg/vmTestbase/nsk/share/locks/DeadlockMaker.java line 31:
> 29: /*
> 30: * Class used to create deadlocked threads. It is possible create 2 or
> more deadlocked thread, also
> 31: * is possible to specify resource of which type should lock each
> deadlocked thread
Suggestion:
* it is possible to specify resource of which type should lock each deadlocked
thread
It doesn't sound right without _“it”_.
test/jdk/com/sun/jdi/connect/spi/GeneratedConnectors.java line 28:
> 26: * @summary Unit test for "Pluggable Connectors and Transports" feature.
> 27: *
> 28: * When a transport service is deployed the virtual machine
Suggestion:
* When a transport service is deployed, the virtual machine
Let's add a comma for clarity.
test/jdk/java/security/testlibrary/SimpleOCSPServer.java line 445:
> 443:
> 444: /**
> 445: * Check the status database for revocation information on one or
> more
Suggestion:
* Check the status database for revocation information of one or more
test/jdk/sun/jvmstat/testlibrary/utils.sh line 181:
> 179: if [ $? -eq 0 ]
> 180: then
> 181: # it's still lingering, now it is hard
Suggestion:
# it's still lingering, now hit it hard
-------------
PR: https://git.openjdk.org/jdk/pull/10029
