On Wed, 13 Nov 2024 10:32:34 GMT, Alan Bateman wrote:
> Remove code required for the now defunct SecurityManager execution mode from
> java.lang.Class, friends, and reflection APIs. Careful review is required so
> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
> po
On Wed, 13 Nov 2024 19:05:21 GMT, Alan Bateman wrote:
>> Remove code required for the now defunct SecurityManager execution mode from
>> java.lang.Class, friends, and reflection APIs. Careful review is required so
>> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
>
On Thu, 7 Nov 2024 18:46:42 GMT, Sean Mullan wrote:
>> Prasadrao Koppula has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 11 commits:
>>
>> - Merge master
>> - initialized storeName with empty string
>> - Replaced Paths.get with
On Wed, 9 Oct 2024 19:22:01 GMT, Jan Lahoda wrote:
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to rece
On Tue, 5 Nov 2024 01:41:00 GMT, SendaoYan wrote:
> Hi all,
> The copyright year of some files which has been changed by
> [JDK-8341692](https://bugs.openjdk.org/browse/JDK-8341692) wasn't update
> correctly. This PR update the copyright year of
> [JDK-8341692](https://bugs.openjdk.org/browse
On Wed, 13 Nov 2024 22:26:35 GMT, Sean Mullan wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>> commits
The type of the Unsafe base offset constant is int, which may cause overflow
when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) fixes
most of the offset overflows in JDK, but ArraysSupport and CRC32C are still
unfixed.
@liach proposed the idea of changing the Unsafe bas
On Mon, 21 Oct 2024 14:25:06 GMT, Raffaello Giulietti
wrote:
> This helps in reducing memory consumption, especially for long inputs.
Marked as reviewed by darcy (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/21614#pullrequestreview-2435061028
On Thu, 7 Nov 2024 14:43:41 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 902:
>>
>>> 900: */
>>> 901: @Override
>>> 902: public void close() {
>>
>> Can/should this method be final? The real/original cleanup method is `end`
>> and if bo
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Tue, 5 Nov 2024 01:41:00 GMT, SendaoYan wrote:
> Hi all,
> The copyright year of some files which has been changed by
> [JDK-8341692](https://bugs.openjdk.org/browse/JDK-8341692) wasn't update
> correctly. This PR update the copyright year of
> [JDK-8341692](https://bugs.openjdk.org/browse
On Fri, 8 Nov 2024 23:57:58 GMT, Alexey Semenyuk wrote:
> The PR affects jpackage test library only. Changes:
>
> - Removed dependencies on `java.io.File`. `java.io.File.pathSeparator` is
> still used as there is no better alternative.
> - Use `TKit.concatMessages()` instead of `String.format()
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Thu, 14 Nov 2024 03:19:01 GMT, Naman Nigam wrote:
>> src/java.base/share/classes/java/util/TreeMap.java line 424:
>>
>>> 422: /**
>>> 423: * Returns the entry for the least key greater than or equal to
>>> the specified key;
>>> 424: * if no such entry exists (i.e. the specifie
> As the documentation of getCeilingEntry currently reads, the inference is
> misleading as follows:
>
> if no such entry exists, returns the entry for the least key greater than the
> specified key;
> if no such entry exists (i.e., the greatest key in the Tree is less than the
> specified key)
On Thu, 14 Nov 2024 02:36:38 GMT, Archie Cobbs wrote:
>> Naman Nigam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8343125 : Resolve a bad merge
>
> src/java.base/share/classes/java/util/TreeMap.java line 424:
>
>> 422: /**
>>
On Wed, 13 Nov 2024 02:43:12 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Thu, 14 Nov 2024 02:29:27 GMT, Naman Nigam wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is
>> misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than
>> the specified key;
>> if no such entry exists (i.e., th
On Wed, 13 Nov 2024 17:38:58 GMT, Chen Liang wrote:
>> Naman Nigam has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> JDK-8343125 : Resolve a bad merge
>
> src/java.base/share/classes/java/util/TreeMap.java line 514:
>
>> 512:
> As the documentation of getCeilingEntry currently reads, the inference is
> misleading as follows:
>
> if no such entry exists, returns the entry for the least key greater than the
> specified key;
> if no such entry exists (i.e., the greatest key in the Tree is less than the
> specified key)
> Can I please get a review for this PR that add tests to verify the value of
> `@since` tags to the Tools area modules. The test is described in this
> [email](https://mail.openjdk.org/pipermail/jdk-dev/2024-October/009474.html).
> This issue is similar to JDK-8341399, JDK-8331051 and JDK-83434
On Wed, 13 Nov 2024 20:33:25 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with the `ArrayList` wrapper that manages synchronization,
>> search and replacements efficiently. Arrays are easy targets for GC. There
>> ar
On Wed, 13 Nov 2024 20:46:09 GMT, Aleksey Shipilev wrote:
>> Right, d'oh. The unavailability of `ArrayList.capacity()` is what gets us in
>> this mess. I'll try to rewrite to just plain arrays.
>
> I pushed the array-based implementation, but ran out of time to properly test
> it. I'll circle b
> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
> support for functionality required to continue to support IIOP and custom
> serializers in light of additional module-based restrictions on reflection.
> It was expected that these libraries would use `sun.misc.Unsafe` in
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Wed, 13 Nov 2024 21:27:02 GMT, David Holmes wrote:
>> Currently, the man pages are stored as troff (a text format) in the open
>> repo, and a content-wise identical copy is stored as markdown (another text
>> format) in the closed repo.
>>
>> Since markdown is preferred to troff in terms of
On Wed, 13 Nov 2024 19:42:29 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof
>
> src/java.base/share/classes/java/io/Buffer
On Tue, 12 Nov 2024 07:30:41 GMT, Shaojin Wen wrote:
> In the JDK code, there are some places that may cause Unsafe offset overflow.
> The probability of occurrence is low, but if it occurs, it will cause JVM
> crash.
This pull request has now been integrated.
Changeset: 0dab920b
Author:S
On Wed, 16 Oct 2024 16:56:38 GMT, Brian Burkhalter wrote:
> Modify the `handleAvailable` native code path to ignore an
> `ERROR_INVALID_FUNCTION` encountered by `PeekNamedPipe` and update an
> existing test to verify this change.
continue;
-
PR Comment: https://git.openjdk.org/jd
On Wed, 13 Nov 2024 02:43:12 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMUL[U]DQ
>> instruction for following IR pallets.
>>
>>
>>MulVL ( AndV SRC1, 0x) ( AndV SRC2, 0x)
>>MulVL (URShiftVL SRC1 , 32) (
On Wed, 13 Nov 2024 19:05:21 GMT, Alan Bateman wrote:
>> Remove code required for the now defunct SecurityManager execution mode from
>> java.lang.Class, friends, and reflection APIs. Careful review is required so
>> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
>
On Wed, 13 Nov 2024 19:05:21 GMT, Alan Bateman wrote:
>> Remove code required for the now defunct SecurityManager execution mode from
>> java.lang.Class, friends, and reflection APIs. Careful review is required so
>> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
>
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://openjdk.org/jeps/483).
>
>
> Note: this is a combined PR of the following individual PRs
> - https://github.com/openjdk/jdk/pull/20516
> - https://github.com/openjdk/jdk/pull/20517
> - https://github.co
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove failing getDeclaredField call from test
java/lang/ProcessBuilder/Basic.java
-
Ch
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove JavaIOPrint{Stream,Writer
On Wed, 13 Nov 2024 20:17:24 GMT, Kevin Walls wrote:
> I think this means the one-true-master copy of a man page is now the public
> .md file. All contributors can now change and improve man pages, and would be
> expected to make necessary man page updates when making other changes. (Which
> i
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 17:47:57 GMT, Chen Liang wrote:
>> David M. Lloyd has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 37 commits:
>>
>> - Merge remote-tracking branch 'upstream-jdk/master' into serialization
>> - Round out the d
On Tue, 12 Nov 2024 01:41:27 GMT, Roger Riggs wrote:
> Refactor removing the dependencies on SecurityManager, doPrivileged, and
> AccessController.
This pull request has now been integrated.
Changeset: 168b18ec
Author:Roger Riggs
URL:
https://git.openjdk.org/jdk/commit/168b18ec68dd
On Wed, 13 Nov 2024 11:15:15 GMT, Raffaello Giulietti
wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 150:
>>
>>> 148: * A constant holding the largest positive finite value of type
>>> 149: * {@code Float16},
>>> 150: * (2-2-10)·215, n
On Wed, 13 Nov 2024 19:00:34 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 290:
>>
>>> 288: list.remove(lastIdx);
>>> 289:
>>> 290: // Capacity control: trim the backing storage if it
>>> looks like
>>
>> I t
On Wed, 13 Nov 2024 12:33:16 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Wed, 13 Nov 2024 15:51:44 GMT, Roger Riggs wrote:
>> Refactor removing the dependencies on SecurityManager, doPrivileged, and
>> AccessController.
>
> Roger Riggs has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Merge branch '8343958-p
On Wed, 13 Nov 2024 20:22:30 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8343039: Remove java.base/jdk.internal.misc from @modules in test
>> java/lang/ProcessBuilder/Basic.java
>
> test/
On Wed, 13 Nov 2024 17:22:21 GMT, Kelvin Nilsen wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> co
> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
> linked list with the `ArrayList` wrapper that manages synchronization, search
> and replacements efficiently. Arrays are easy targets for GC. There are
> possible improvements here, most glaring is parallelism that i
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove java.base/jdk.internal.misc from @modules in test
java/lang/ProcessBuilder/Basic.java
---
On Wed, 13 Nov 2024 20:16:44 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove InternalLock reference fr
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 20:07:59 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Address reviewer comments
f5548
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove InternalLock reference from
java/lang/ProcessBuilder/Basic.java
-
Changes:
- a
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Address reviewer comments
-
Changes:
- all: https://git.openjdk.org/jdk/pull/22048/fil
On Wed, 13 Nov 2024 19:57:39 GMT, Alan Bateman wrote:
> [...] it's good that Chen is reviewing too as would be too easy to introduce
> a bug with this refactor.
Definitely on both counts.
> src/java.base/share/classes/java/io/BufferedInputStream.java line 242:
>
>> 240: initialSize =
On Tue, 12 Nov 2024 15:41:01 GMT, Roger Riggs wrote:
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), java.time
> implementation dependencies on doPriviledged and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
This pull request has
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove JavaIOPrint{Stream,Writer
On Wed, 13 Nov 2024 08:16:31 GMT, Aleksey Shipilev wrote:
>> src/java.base/share/classes/jdk/internal/ref/CleanerImpl.java line 300:
>>
>>> 298: return true;
>>> 299: }
>>> 300: }
>>
>> It looks like the new `PhantomCleanableList.remove()` puts 100% trust in
On Wed, 13 Nov 2024 07:15:15 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/java/io/BufferedOutputStream.java line 88:
>>
>>> 86: }
>>> 87:
>>> 88: this.buf = new byte[initialSize]; // resizable if initialSize <
>>> maxSize
>>
>> Same remark as for BIS.
>>
>> Also th
On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8343039: Remove JavaIOPrint{Stream,Writer
The plan is to use the facilities described in "JEP 488: Primitive Types
in Patterns, instanceof, and switch (Second Preview)" once they become a
permanent _language_ feature.
Currently, you can perform one of the tests provided in
https://docs.oracle.com/en/java/javase/23/docs/api/java.base/j
On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 91:
>>
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>>
>> Please uncommen
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote:
> Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is
> fully initialized in `` block.
> It means we can replace legacy synchronized `Hashtable` with immutable set.
This pull request has now been integrated.
Changese
On Tue, 5 Nov 2024 12:49:04 GMT, Andrey Turbanov wrote:
> Content of Hashtable `com.sun.jndi.ldap.LdapClient#defaultBinaryAttrs` is
> fully initialized in `` block.
> It means we can replace legacy synchronized `Hashtable` with immutable set.
I run `com/sun/jndi` tests on my win x64. All green.
On Wed, 13 Nov 2024 06:40:15 GMT, Joe Darcy wrote:
>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/Float16.java
>> line 91:
>>
>>> 89: // JEP-401 (https://openjdk.org/jeps/401).
>>> 90: // @jdk.internal.MigratedValueClass
>>> 91: // @jdk.internal.ValueBased
>>
>> Please uncommen
> Please review this patch which removes unnecessary `@SuppressWarnings`
> annotations.
Archie Cobbs has updated the pull request incrementally with one additional
commit since the last revision:
Remove more unnecessary warning suppressions.
-
Changes:
- all: https://git.openj
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
> support for functionality required to continue to support IIOP and custom
> serializers in light of additional module-based restrictions on reflection.
> It was expected that these libraries would use `sun.misc.Unsafe` in
On Wed, 13 Nov 2024 10:32:34 GMT, Alan Bateman wrote:
> Remove code required for the now defunct SecurityManager execution mode from
> java.lang.Class, friends, and reflection APIs. Careful review is required so
> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
> po
On Wed, 13 Nov 2024 10:32:34 GMT, Alan Bateman wrote:
> Remove code required for the now defunct SecurityManager execution mode from
> java.lang.Class, friends, and reflection APIs. Careful review is required so
> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
> po
> Remove code required for the now defunct SecurityManager execution mode from
> java.lang.Class, friends, and reflection APIs. Careful review is required so
> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
> possible and not go over board with cleanup.
>
> sun.refl
> After the ClassFile API migration, when serializable lambdas are requested
> for hidden class callers, illegal class name is generated for the
> serialization methods, which previously had legal yet unusable class names,
> as hidden classes cannot be described by a `CONSTANT_Class_info`.
>
>
Please review this change for the `jar` tool to gracefully handle the case
where `--release` is not specified as the last arguments.
Prior to this commit, operation modes `-d --describe-module` and `--validate`
expected to read the optional `--release` option as a file argument: `jar -d -f
a.ja
On Wed, 13 Nov 2024 17:19:18 GMT, Kelvin Nilsen wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> co
On Wed, 13 Nov 2024 16:08:51 GMT, Brian Burkhalter wrote:
> I don't mind if JavaIOPrintStreamAccess is removed now or in a later PR.
It is removed by d3d1e3a.
-
PR Comment: https://git.openjdk.org/jdk/pull/22048#issuecomment-2474479043
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof
-
Changes:
- all: https://
On Wed, 13 Nov 2024 17:01:14 GMT, Chen Liang wrote:
>> After the ClassFile API migration, when serializable lambdas are requested
>> for hidden class callers, illegal class name is generated for the
>> serialization methods, which previously had legal yet unusable class names,
>> as hidden cla
On Tue, 12 Nov 2024 10:41:48 GMT, Alan Bateman wrote:
> Removes the SecurityManager usage from Thread + friends.
>
> In Thread, the getContextClassLoader method is no longer caller-sensitive
> method.
>
> JavaLangAccess.newThreadWithAcc is removed and jdk.internal.access is no
> longer export
> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411),
> Serialization implementation dependencies on SecurityManager, doPrivildged,
> and AccessController are removed.
> Some refactoring to cleanup the remaining code is expected.
Roger Riggs has updated the pull request incremental
Currently, the man pages are stored as troff (a text format) in the open repo,
and a content-wise identical copy is stored as markdown (another text format)
in the closed repo.
Since markdown is preferred to troff in terms of editing, we make changes to
the man pages in markdown and then conver
On Tue, 12 Nov 2024 21:45:41 GMT, Brian Burkhalter wrote:
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
21c9c5e addresses reviewer comments above and removes `InternalLock`. I will
submit on more commit to remove `JavaIOPrint{Stream,Writer}Access`.
-
PR Co
> Uses of `InternalLock` are removed and `synchronized` is reinstated.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8343039: Remove use of InternalLock from Stream{De,En}coder and throwable;
remove InternalLock class; address
On Wed, 13 Nov 2024 18:30:22 GMT, Chen Liang wrote:
>> After the ClassFile API migration, when serializable lambdas are requested
>> for hidden class callers, illegal class name is generated for the
>> serialization methods, which previously had legal yet unusable class names,
>> as hidden cla
On Thu, 17 Oct 2024 23:11:07 GMT, Joe Darcy wrote:
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
This pull request has now been integrated.
Changeset: dbf23466
Author:Joe Darcy
URL:
https://git.openjdk.org/jdk/commit/dbf23466aff902836838f06bc
On Wed, 13 Nov 2024 14:51:07 GMT, Roger Riggs wrote:
>> After [JDK-8338411](https://bugs.openjdk.org/browse/JDK-8338411), java.time
>> implementation dependencies on doPriviledged and AccessController are
>> removed.
>> Some refactoring to cleanup the remaining code is expected.
>
> Roger Riggs
On Wed, 13 Nov 2024 17:05:25 GMT, Magnus Ihse Bursie wrote:
> Currently, the man pages are stored as troff (a text format) in the open
> repo, and a content-wise identical copy is stored as markdown (another text
> format) in the closed repo.
>
> Since markdown is preferred to troff in terms o
On Wed, 13 Nov 2024 16:08:44 GMT, Christian Stein wrote:
>> Please review this change for the `jar` tool to gracefully handle the case
>> where `--release` is not specified as the last arguments.
>>
>> Prior to this commit, operation modes `-d --describe-module` and
>> `--validate` expected to
On Wed, 13 Nov 2024 13:17:31 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Wed, 13 Nov 2024 15:21:24 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix failing test
src/java.base/share/classes/
On Wed, 13 Nov 2024 10:32:34 GMT, Alan Bateman wrote:
> Remove code required for the now defunct SecurityManager execution mode from
> java.lang.Class, friends, and reflection APIs. Careful review is required so
> I've set Reviewer to 2. I've tried to keep the changes as easy to review as
> po
On Wed, 13 Nov 2024 15:38:35 GMT, Aleksey Shipilev wrote:
>> See the bug for more discussion and reproducer. This PR replaces the ad-hoc
>> linked list with the `ArrayList` wrapper that manages synchronization,
>> search and replacements efficiently. Arrays are easy targets for GC. There
>> ar
On Wed, 13 Nov 2024 16:55:16 GMT, Alan Bateman wrote:
> > `InternalLock` is also in `sun.nio.cs.Stream{De,En}coder`.
>
> Yes, these two will need to be updated. I don't mind if this is split up into
> several PRs but if InternalLock isn't removed by the current PR then you'll
> need to change
On Sat, 26 Oct 2024 14:06:37 GMT, Naman Nigam wrote:
> As the documentation of getCeilingEntry currently reads, the inference is
> misleading as follows:
>
> if no such entry exists, returns the entry for the least key greater than the
> specified key;
> if no such entry exists (i.e., the grea
On Wed, 13 Nov 2024 13:48:14 GMT, Per Minborg wrote:
> This PR proposes to remove the security manager dependencies in the FFM
> implementing classes.
I didn't get a chance to review until now, had one small comment.
src/java.base/share/classes/jdk/internal/foreign/abi/fallback/LibFallback.jav
On Wed, 13 Nov 2024 10:24:14 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in
On Wed, 13 Nov 2024 15:48:30 GMT, Roger Riggs wrote:
>> I assume Roger will run at least tier1 on all platforms before integrating.
>
> Inadvertent lapse.
> Retested in the CI on all platforms
Thank you Roger, the updated changes look good to me.
-
PR Review Comment: https://git.op
On Wed, 13 Nov 2024 16:14:11 GMT, Brian Burkhalter wrote:
> `InternalLock` is also in `sun.nio.cs.Stream{De,En}coder`.
Yes, these two will need to be updated. I don't mind if this is split up into
several PRs but if InternalLock isn't removed by the current PR then you'll
need to change its ti
On Wed, 13 Nov 2024 16:13:58 GMT, David M. Lloyd wrote:
>> Sorry, I meant to flag PrivilegedAction.
>
> Ah, I see. It looks like it's still used though, in
> `GetReflectionFactoryAction` which hasn't been removed yet. I guess it'll be
> removed in one of the sub-tasks of
> [JDK-8338411](https:
On Wed, 13 Nov 2024 13:17:31 GMT, David M. Lloyd wrote:
>> Issue [JDK-8164908](https://bugs.openjdk.org/browse/JDK-8164908) added
>> support for functionality required to continue to support IIOP and custom
>> serializers in light of additional module-based restrictions on reflection.
>> It wa
On Mon, 28 Oct 2024 06:05:50 GMT, Naman Nigam wrote:
>> To get a JBS issue, please open a bug report about this typo in
>> https://bugs.java.com/bugdatabase/. Also follow https://openjdk.org/guide
>> for the rest of the steps for contributions.
>
>> To get a JBS issue, please open a bug report
1 - 100 of 179 matches
Mail list logo
