On Wed, 13 Nov 2024 17:22:21 GMT, Kelvin Nilsen <kdnil...@openjdk.org> wrote:
>> Aleksey Shipilev has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> commits since the last revision: >> >> - Merge branch 'master' into JDK-8343704-cleaner-gc >> - Merge branch 'master' into JDK-8343704-cleaner-gc >> - Touchups: assert index, polish commits >> - Fix > > src/java.base/share/classes/jdk/internal/ref/PhantomCleanable.java line 71: > >> 69: this.index = -1; >> 70: this.list = CleanerImpl.getCleanerImpl(cleaner).activeList; >> 71: list.insert(this); > > For consistency, maybe use "this.list.insert(this)", or remove "this" from > the preceding two lines. Right, done. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1841120926
