On Wed, 13 Nov 2024 10:32:34 GMT, Alan Bateman <al...@openjdk.org> wrote:

> Remove code required for the now defunct SecurityManager execution mode from 
> java.lang.Class, friends, and reflection APIs. Careful review is required so 
> I've set Reviewer to 2. I've tried to keep the changes as easy to review as 
> possible and not go over board with cleanup.
> 
> sun.reflect.misc.ReflectUtil are been hollowed out. A future pass will remove 
> empty methods and qualified exports once the changes in "far away" code and 
> modules is done.
> 
> In Lookup's class description, the removal of the sentence "avoid package 
> access checks for classes accessible to the lookup class"  and the link to 
> the removed "Security manager interactions" section is in 
> discussion/non-normative text, just missed in the JEP 486 update that remove 
> the linked section.
> 
> runtime/cds/appcds/StaticArchiveWithLambda.java is temporarily excluded as 
> the loading of a dynamically generated class at archive time. I'm checking 
> with Calvin and Ioi on whether this test should be updated or replaced.
> 
> Testing: tier1-5

Reflection and invoke changes look good.  Not sure about ServiceLoader.  
Module/Package changes look innocuous but not a professional in those areas 
either.

-------------

Marked as reviewed by liach (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22063#pullrequestreview-2434049807

Reply via email to