On Wed, 13 Nov 2024 19:00:36 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> Uses of `InternalLock` are removed and `synchronized` is reinstated. > > Brian Burkhalter has updated the pull request incrementally with one > additional commit since the last revision: > > 8343039: Remove JavaIOPrint{Stream,Writer}Access and the use thereof src/java.base/share/classes/java/io/BufferedInputStream.java line 242: > 240: initialSize = size; > 241: if (getClass() == BufferedInputStream.class) { > 242: buf = EMPTY; Maybe keep "lazily create buffer when not subclassed" as the comment. src/java.base/share/classes/java/io/BufferedOutputStream.java line 88: > 86: } > 87: > 88: this.buf = new byte[initialSize]; // resizable if initialSize < > maxSize Something has got messed up here, it creates the byte[] twice now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22048#discussion_r1841062387 PR Review Comment: https://git.openjdk.org/jdk/pull/22048#discussion_r1841064710