On Wed, 13 Nov 2024 22:26:35 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Alan Bateman has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> commits since the last revision: >> >> - StaticArchiveWithLambda no longer skips dynamically generated class when >> creating archive >> - Merge branch 'master' into JDK-8344011 >> - Initial commit > > src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java line > 1: > >> 1: /* > > Line 82: is `GetReflectionFactoryAction` still needed? There's a sequencing issue here, this can't be removed until Roger's work on removing SM use from serialization are in. In general, we'll the efforts to remove usage of the SM from the JDK will require multiple passes due to dependencies like this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22063#discussion_r1841596240