On Mon, 28 Oct 2024 08:34:14 GMT, Alan Bateman wrote:
> This is an update to the Virtual thread implementation that we'd like to
> integrate in advance of JEP 491.
>
> The update removes the use of "temporary transitions", basically cases where
> the thread identity switches to the carrier th
On Sun, 27 Oct 2024 06:25:02 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 30 Oct 2024 05:51:30 GMT, David Holmes wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> un
On Mon, 1 Jul 2024 19:20:48 GMT, Chen Liang wrote:
> Clarify that only `Class` is returned for core reflection implementation, and
> the return type is `Type` to support other implementations, such as ones
> modeling unloaded or remote types.
This pull request has now been integrated.
Changes
On Wed, 23 Oct 2024 04:40:50 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdirectory of the input directory.
>
> jpackage will produce a
On Sun, 27 Oct 2024 06:25:02 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Wed, 23 Oct 2024 04:40:50 GMT, Julian Waters wrote:
> After 8339120, gcc began catching many different instances of unused code in
> the Windows specific codebase. Some of these seem to be bugs. I've taken the
> effort to mark out all the relevant globals and locals that trigger the
> unuse
On Tue, 29 Oct 2024 14:03:35 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add support for proper String -> Float16 conversion.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vect
> Port of Float16 from java.lang in the lworld+fp16 branch to
> jdk.incubabor.vector.
Joe Darcy has updated the pull request incrementally with one additional commit
since the last revision:
Respond to review feedback.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21574/f
On Tue, 29 Oct 2024 14:03:17 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add support for proper String -> Float16 conversion.
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vect
On Tue, 29 Oct 2024 16:15:30 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add forgotten .jcheck/conf
Hotspot changes are fine.
Thanks
-
Marked as reviewed by
On Tue, 29 Oct 2024 09:51:16 GMT, Julian Waters wrote:
>> src/hotspot/share/prims/jvm.cpp line 381:
>>
>>> 379: {
>>> 380: #undef CSIZE
>>> 381: #if defined(_LP64)
>>
>> Windows is actually LLP64 programming model not LP64. Does Windows x64
>> define _LP64 or is that something we do in our b
On Tue, 29 Oct 2024 20:22:03 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Mon, 28 Oct 2024 13:27:27 GMT, Alexey Semenyuk wrote:
> Change suffixes produced by `TKit.createUniqueFileName()` function from
> `.` to `-` (e.g.: from `.0` to `-0`).
> Apple's `codesign` tool can't sign directories with periods in their names as
> it interprets them as bundles. Directories
On Tue, 29 Oct 2024 23:13:21 GMT, Alexander Matveev
wrote:
> - Added check for "--mac-sign" argument in cases when we do in-place signing
> of predefined app image to avoid potential bugs.
Marked as reviewed by asemenyuk (Reviewer).
Looks good!
-
PR Review: https://git.openjdk.o
On Tue, 29 Oct 2024 20:22:03 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 15:30:44 GMT, Magnus Ihse Bursie wrote:
>> src/hotspot/share/utilities/globalDefinitions_visCPP.hpp line 55:
>>
>>> 53: #error unsupported platform
>>> 54: #endif
>>> 55:
>>
>> Does Windows Aarch64 define _LP64?
>
> Yes. As Julian says, it's something we set up in our build
On Tue, 29 Oct 2024 17:40:35 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Alan's review - fix code comment about Microsoft C Runtime Library
>
> src/java.base/windows/native/libjli/java_md.c li
On Wed, 30 Oct 2024 01:49:48 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which cleans up references to "JRE"
>> from the launcher's code?
>>
>> No functional changes have been introduced in this change.
>>
>> No new tests have been introduced and existing tests in tier
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> Can I please get a review of this change which cleans up references to "JRE"
> from the launcher's code?
>
> No functional changes have been introduced in this change.
>
> No new tests have been introduced and existing tests in tier1, tier2 and
> tier3 continue to pass in our CI against Linux
- All verbose log messages in Executor will only be shown if mode is not quite
to eliminate partial and unnecessary log messages.
-
Commit messages:
- 8343085: jpackage Executor outputs verbose log messages even if run in the
quiet mode
Changes: https://git.openjdk.org/jdk/pull/21
On Wed, 30 Oct 2024 00:44:14 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 22:12:56 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/x86/interp_masm_x86.cpp line 359:
>>
>>> 357: push_cont_fastpath();
>>> 358:
>>> 359: // Make VM call. In case of preemption set last_pc to the one we
>>> want to resume to.
>>
>> From the comment, it soun
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 29 Oct 2024 21:32:44 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/share/oops/method.cpp line 870:
>
>> 868: }
>> 869:
>> 870:
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
- Added check for "--mac-sign" argument in cases when we do in-place signing of
predefined app image to avoid potential bugs.
-
Commit messages:
- 8342544: [macos] jpackage test helper should check for both "--app-image"
and "--mac-sign" for signing predefined app image case
Chang
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Sun, 6 Oct 2024 08:32:20 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This is just a redo of https://github.com/openjdk/jdk/pull/13093. mostly
>> just the revert of the backout.
>>
>> Regarding the related issues:
>>
>> - [JDK-8306008](https://bugs.openjdk.org/browse/JDK-8306008) and
>> [JDK-830
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 16:52:45 GMT, Tom Rodriguez wrote:
> The notification that finalize is complete should be done after printing the
> message because in Xcomp mode there might be a significant delay at the
> println so the object hasn't actually been finalized yet.
LGTM
-
Marke
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
On Wed, 21 Aug 2024 16:03:15 GMT, Chen Liang wrote:
>> A straightforward optimization, to share the signature parsing of method,
>> constructor, and field between the root and the copied objects, like how
>> method handle accessors are shared.
>
> Chen Liang has updated the pull request with a
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 20:39:44 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Improve comment in SharedRuntime::generate_native_wrapper
>
> src/hotspot/share/code/nmethod.cpp line 712:
>
>>
On Mon, 28 Oct 2024 21:07:47 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Objec
On Tue, 29 Oct 2024 01:59:35 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp line 1351
On Tue, 29 Oct 2024 20:14:27 GMT, Severin Gehwolf wrote:
>> Henry Jen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix regression failed to setup helper methods properly
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Snippet
On Tue, 29 Oct 2024 16:06:32 GMT, Alexey Semenyuk wrote:
>> Change suffixes produced by `TKit.createUniqueFileName()` function from
>> `.` to `-` (e.g.: from `.0` to `-0`).
>> Apple's `codesign` tool can't sign directories with periods in their names
>> as it interprets them as bundles. Directo
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Tue, 29 Oct 2024 12:40:59 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Tue, 29 Oct 2024 10:06:01 GMT, Fredrik Bredberg
wrote:
>> Right. We want to take the slow path to find the compiled native wrapper
>> frame and fail to freeze. Otherwise the fast path won't find it since we
>> don't walk the stack.
>
> It would be nice if Coleen's question and your answer c
On Tue, 29 Oct 2024 19:04:57 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/aarch64/frame_aarch64.hpp line 77:
>>
>>> 75: // Interpreter frames
>>> 76: interpreter_frame_result_handler_offset = 3, // for
>>> native calls only
>>> 77: interpreter_frame_oop_temp_offs
On Tue, 29 Oct 2024 16:15:30 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add forgotten .jcheck/conf
Marked as reviewed by erikj (Reviewer).
-
PR Review: https
> As a prerequisite for Hermetic Java, we need a statically linked `java`
> launcher. It should behave like the normal, dynamically linked `java`
> launcher, except that all JDK native libraries should be statically, not
> dynamically, linked.
>
> This patch is the first step towards this goal.
On Tue, 29 Oct 2024 18:57:38 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 23:36:19 GMT, Jiangli Zhou wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Don't hardcode server variant
>
>> > > When trying to sort out the LDFLAGS issues, it turned out that I could
>>
On Tue, 29 Oct 2024 18:57:38 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Mon, 28 Oct 2024 05:15:18 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the class
On Tue, 29 Oct 2024 13:12:56 GMT, Aleksey Shipilev wrote:
>> This is forked from
>> [JDK-8342642](https://bugs.openjdk.org/browse/JDK-8342642) and filed as a
>> general issue for archived boxed Integer cache when it's recreated at
>> runtime. In short, current code drops the entire primitive c
On Mon, 7 Oct 2024 22:03:36 GMT, Serguei Spitsyn wrote:
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tie
On Tue, 29 Oct 2024 08:35:27 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Tue, 29 Oct 2024 00:04:09 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Tue, 29 Oct 2024 08:29:55 GMT, David Holmes wrote:
>> It's conceivable that in the future we might have more native methods we
>> want to preempt. Instead of enumerating them all, we could set a flag on
>> the method.
>>
>> I was assuming that David was suggesting we have the Java caller d
On Tue, 29 Oct 2024 01:42:09 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix comment in VThreadWaitReenter
>
> src/hotspot/cpu/aarch64/frame_aarch64.hpp line 77:
>
>> 75: // Interp
On Mon, 28 Oct 2024 23:38:43 GMT, Dean Long wrote:
>>> Could the problem be solved with a resume adapter instead, like the
>>> interpreter uses?
>>>
>> It will just move the task of adjusting the size of the frame somewhere else.
>
>> One way to get rid of this would be to have c2 just set last_
On Mon, 28 Oct 2024 23:46:09 GMT, Dean Long wrote:
> > regardless of when you freeze, while doing the freezing the monitor could
> > have been released already. So trying to acquire the monitor after freezing
> > can always succeed, which means we don't want to unmount but continue
> > executi
On Tue, 29 Oct 2024 12:40:59 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdirectory of the input directory.
>
> jpackage will produce a
Redirect to core-libs-...@openjdk.java.net.
On 10/29/24 12:36 PM, Emre Kaplan wrote:
Hi,
Why wouldn't requireNonNullElse(o1, requireNonNull(o2)) or
requireNonNull(requireNonNullElse(o1, o2)) suffice?
Because requireNonNullElse requires both arguments are not null.
There isn't a meth
On Tue, 29 Oct 2024 08:35:27 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Mon, 28 Oct 2024 14:25:40 GMT, Mark Reinhold wrote:
>> Severin Gehwolf has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Better handle patched modules
>>
>>Also add a test which ensures that module patching (if present), will
On Fri, 25 Oct 2024 18:51:09 GMT, Mandy Chung wrote:
>> Severin Gehwolf has updated the pull request incrementally with five
>> additional commits since the last revision:
>>
>> - Better handle patched modules
>>
>>Also add a test which ensures that module patching (if present), will
>
On Tue, 29 Oct 2024 16:15:30 GMT, Pavel Rappo wrote:
>> Prepare for JDK 25.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Add forgotten .jcheck/conf
Congratulations on accepting the baton from Joe!
Confirmed everything a
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up references to "JRE"
> from the launcher's code?
>
> No functional changes have been introduced in this change.
>
> No new tests have been introduced and existing tests in tier1, tie
On Mon, 28 Oct 2024 05:15:18 GMT, Henry Jen wrote:
>> This PR split out large array/set construction into separate factory methods
>> to avoid oversized method trying to construct several of those.
>>
>> In order to do that, we will need to generate those help methods on demand
>> in the class
On Wed, 12 Jun 2024 14:24:56 GMT, Alan Bateman wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> Are you planning to add tests? I don't think we should be changing this code
> with good tests.
Hi @AlanBateman, when you have a chance can you take a look at the tests I
add
On Thu, 24 Oct 2024 06:40:42 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Thu, 24 Oct 2024 15:12:55 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 186 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Update copyrights
On Thu, 24 Oct 2024 15:03:23 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Tue, 22 Oct 2024 15:15:14 GMT, Chen Liang wrote:
>> Clarify that only `Class` is returned for core reflection implementation,
>> and the return type is `Type` to support other implementations, such as ones
>> modeling unloaded or remote types.
>
> Chen Liang has updated the pull request with
The notification that finalize is complete should be done after printing the
message because in Xcomp mode there might be a significant delay at the println
so the object hasn't actually been finalized yet.
-
Commit messages:
- 8343213: TEST_BUG: [Graal] java/lang/ref/Basic.java fa
On Mon, 28 Oct 2024 12:29:07 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Mon, 28 Oct 2024 16:41:56 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Mon, 28 Oct 2024 16:41:56 GMT, Jiangli Zhou wrote:
>> Moved from
>> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>>
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details i
On Tue, 29 Oct 2024 16:01:49 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Tue, 29 Oct 2024 16:01:49 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> Prepare for JDK 25.
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Add forgotten .jcheck/conf
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21763/files
- new: https://git.openjdk.org/jdk/pull/21763/files/fc851
On Tue, 29 Oct 2024 16:01:49 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
On Tue, 29 Oct 2024 16:01:49 GMT, Magnus Ihse Bursie wrote:
>> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
>> Port_](https://openjdk.org/jeps/479).
>>
>> This is the summary of JEP 479:
>>> Remove the source code and build support for the Windows 32-bit x86 port.
>>>
> Change suffixes produced by `TKit.createUniqueFileName()` function from
> `.` to `-` (e.g.: from `.0` to `-0`).
> Apple's `codesign` tool can't sign directories with periods in their names as
> it interprets them as bundles. Directories produced by
> `TKit.createUniqueFileName()` may end up in
> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86
> Port_](https://openjdk.org/jeps/479).
>
> This is the summary of JEP 479:
>> Remove the source code and build support for the Windows 32-bit x86 port.
>> This port was [deprecated for removal in JDK
>> 21](https://openjd
On Tue, 29 Oct 2024 10:37:52 GMT, Alan Bateman wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The pull request now contains seven commits:
>>
>> - Update VirtualMachineImpl_openProcess since it only needs to care about
>> 64-bit
On Tue, 29 Oct 2024 14:37:43 GMT, Aleksey Shipilev wrote:
>> @shipilev There _is_ a way to implement SpinPause on Windows/x64 though, if
>> support is really as simple as a single pause instruction. Should I help
>> implement this separately (After this PR is integrated, to avoid conflicts)?
>
1 - 100 of 165 matches
Mail list logo
