On Mon, 28 Oct 2024 16:41:56 GMT, Jiangli Zhou <jian...@openjdk.org> wrote:
>> Moved from >> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16: >> >> Please review the fix that uses String type for the mapped value in >> ModuleLoaderMap.Mapper map (Map<String, String>). Please see details in >> https://bugs.openjdk.org/browse/JDK-8342642, thanks. >> >> Existing comment threads from closed >> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16: >> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2436358591 >> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2437465648 >> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2438567642 >> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2436262114 >> - https://github.com/openjdk/jdk/pull/21672#issuecomment-2437501231 > > Jiangli Zhou has updated the pull request incrementally with one additional > commit since the last revision: > > Adjust comment. Marked as reviewed by alanb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/21722#pullrequestreview-2402484341