On Sat, 26 Oct 2024 01:42:17 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Objec
On Sat, 26 Oct 2024 01:40:41 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Objec
On Fri, 25 Oct 2024 22:14:43 GMT, Brian Burkhalter wrote:
>> Modify `FileInputStream` (FIS) to fall back to the superclass
>> implementations of `readAllBytes()`, `readNBytes(int)`, `skip()`, and
>> `transferTo` when the input source would otherwise fail with "Illegal Seek"
>> in the FIS imple
On Sat, 26 Oct 2024 06:34:08 GMT, Serguei Spitsyn wrote:
>> src/hotspot/share/prims/jvmtiEnvBase.cpp line 667:
>>
>>> 665:
>>> 666: javaVFrame*
>>> 667: JvmtiEnvBase::check_and_skip_hidden_frames(bool is_in_VTMS_transition,
>>> javaVFrame* jvf) {
>>
>> reworked function looks much better! Now
On Thu, 24 Oct 2024 22:58:01 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: removed asserts from continuationFreezeThaw.cpp again
>
> src/hotspot/share/prims/jvmtiEnvBase.cpp line 667:
- merge EmptyFolderTest, EmptyFolderPackageTest and EmptyFolderTestBase in
EmptyFolderTest class.
- for .msi package still verify the output. It should not contain empty
folders from `--input`, but should contain other folders and files.
-
Commit messages:
- 8343100: Consolidate E
On Sat, 26 Oct 2024 05:13:08 GMT, Alan Bateman wrote:
>> src/java.base/share/classes/jdk/internal/vm/annotation/JvmtiMountTransition.java
>> line 38:
>>
>>> 36: *
>>> 37: * @implNote
>>> 38: * This annotation is only used for the VirtualThread notifyJvmti*
>>> methods.
>>
>> What about Vi
On Sat, 26 Oct 2024 00:43:00 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: introduce new annotation @JvmtiHideEvents and use it in
>> VirtualThread/Continuation classes to disallow Fr
On Fri, 25 Oct 2024 22:09:30 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add/fix comments for David
>> - Move condition to new line in nmethod::preserve_callee_argument_oops
>
> test
On Sat, 26 Oct 2024 00:41:43 GMT, Alex Menkov wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: introduce new annotation @JvmtiHideEvents and use it in
>> VirtualThread/Continuation classes to disallow Fr
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Sat, 26 Oct 2024 00:27:25 GMT, Dean Long wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Restore use of atPointA in test StopThreadTest.java
>> - remove interruptible check from conditional in Objec
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 19:32:23 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
> On Oct 25, 2024, at 7:31 PM, Alexander Matveev wrote:
>
> On Fri, 25 Oct 2024 21:55:58 GMT, Michael Hall wrote:
>
>> So these both still return the failing error code?
> Yes, jpackage will return failing error case.
>
>> Are these changes only related to the test or do they apply somehow
On Fri, 25 Oct 2024 20:52:29 GMT, Serguei Spitsyn wrote:
>> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
>> frames hiding mechanism.
>> Please, see a fix description in the first comment.
>>
>> Testing:
>> - Verified with new test `vthread/CheckHiddenFrames`
>> - M
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:55:58 GMT, Michael Hall wrote:
> So these both still return the failing error code?
Yes, jpackage will return failing error case.
> Are these changes only related to the test or do they apply somehow to normal
> usage?
Change is for test only. Test will ignore jpackage er
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 19:32:23 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:14:25 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/SecureClassLoader.java line 1:
>>
>>> 1: /*
>>
>> The class spec still mentions "permissions which are retrieved by the system
>> policy by default". Shall we remove it? Also, `getPermissions` alw
On Tue, 22 Oct 2024 02:18:19 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/cpu/aarch64/continuationFreezeThaw_aarch64.inline.hpp line 300:
>>
>>> 298: CodeBlob* cb = top.cb();
>>> 299:
>>> 300: if (cb->frame_size() == 2) {
>>
>> Is this a filter to identify c2 runtime stubs? Is there
On Fri, 25 Oct 2024 20:53:23 GMT, Sean Mullan wrote:
>> src/java.base/share/classes/java/security/AccessControlContext.java line 141:
>>
>>> 139: throws AccessControlException
>>> 140: {
>>> 141: throw new AccessControlException("");
>>
>> No message for this exception?
>
>
On Fri, 25 Oct 2024 06:49:48 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which cleans up references to "JRE"
> from the launcher's code?
>
> No functional changes have been introduced in this change.
>
> No new tests have been introduced and existing tests in tier1, tie
On Fri, 25 Oct 2024 21:09:19 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/sound/midi/Soundbanks/GetSoundBankSecurityException/GetSoundBankSecurityException.java
>> line 1:
>>
>>> 1: /*
>>
>> I believe this test becomes irrelevant without `SecurityManager`.
>>
>> The summary of the test state
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:06:28 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/imageio/spi/AppletContextTest/IIOPluginTest.java line 42:
>>
>>> 40: } catch (ServiceConfigurationError sce) {
>>> 41: System.out.println("Expected ServiceConfigurationError \n"
>>> + sce);
>>> 42:
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 21:23:26 GMT, Harshitha Onkar wrote:
>> The tests with “Audit Core Reflection” in their summary fall into this
>> category, we may consider removing them.
>
> @prrace Can you please advice on “Audit Core Reflection” category of tests.
> I'm not 100% sure if these tests need
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
> This addresses tendencies in previous update to increase fencing, scanning,
> and signalling that can increase contention, and slow down performance
> especially on ARM platforms. It also uses more ARM-friendly constructions to
> reduce overhead (leading to several changes that all of the same
On Fri, 25 Oct 2024 21:29:05 GMT, Patricio Chilano Mateo
wrote:
>> I see that in lightweightSynchronizer.cpp we already use the name
>> `locking_thread` (although
>> `LightweightSynchronizer::inflate_into_object_header` still uses
>> `inflating_thread`). So how about using `locking_thread` in
On Wed, 23 Oct 2024 20:42:44 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/runtime/objectMonitor.hpp line 299:
>>
>>> 297: // Simply set _owner field to new_value; current value must match
>>> old_value.
>>> 298: void set_owner_from_raw(int64_t old_value, int64_t new_value);
On Fri, 25 Oct 2024 21:33:24 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 18:09:22 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8341666: Fix Windows oversight
>
> src/java.base/share/classes/java/io/FileInputStream.java line 86:
>
>> 84:
>>
> Modify `FileInputStream` (FIS) to fall back to the superclass implementations
> of `readAllBytes()`, `readNBytes(int)`, `skip()`, and `transferTo` when the
> input source would otherwise fail with "Illegal Seek" in the FIS
> implementation, such as for the standard input or a named pipe.
Bria
On Fri, 25 Oct 2024 18:34:16 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 05:17:51 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with four
>> additional commits since the last revision:
>>
>> - Rename set/has_owner_anonymous to set/has_anonymous_owner
>> - Fix comments in javaThread.hpp and Thread.
Moved from
https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
Please review the fix that uses String type for the mapped value in
ModuleLoaderMap.Mapper map (Map). Please see details in
https://bugs.openjdk.org/browse/JDK-8342642, thanks.
Existing comme
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
Jiangli Zhou has updated the pull request incrementally with 109 additional
commits since the last revision:
-
On Tue, 22 Oct 2024 15:56:18 GMT, Paul Sandoz wrote:
>> Hey @eme64 ,
>>
>>> Wow this is really a very moving target - quite frustrating to review - it
>>> takes up way too much of the reviewers bandwidth. You really need to split
>>> up your PRs as much as possible so that review is easier and
On Fri, 25 Oct 2024 19:44:54 GMT, Weijun Wang wrote:
> Comments on `java.security` classes.
>
> Also, I'd like to see some clarifications on what "the installed policy" or
> "the current policy" is. The `ProtectionDomain` mentions this when talking
> about dynamic permissions. On the other han
On Fri, 25 Oct 2024 21:35:37 GMT, Alexey Semenyuk wrote:
> Remove `--compress` from jlink command lines in jpackage tests
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21723#pullrequestreview-2396563507
On Thu, 24 Oct 2024 13:36:50 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new vector operators.
>>
>>
>> . SUADD : Saturating unsigned addition.
>> . SADD: Saturating signed addition.
>
> On Oct 25, 2024, at 4:36 PM, Alexander Matveev wrote:
>
> Generating PKG and DMG is not possible due to potential failure of codesign.
So these both still return the failing error code?
Are these changes only related to the test or do they apply somehow to normal
usage?
I’m not sure wha
On Fri, 25 Oct 2024 08:37:30 GMT, Maurizio Cimadamore
wrote:
> This PR fixes an issue where passing many by-reference parameters to downcall
> results in escape analysis failures.
> The problem is that, as the parameters grow, the generated code in the
> trampoline stub we generate also grows.
On Fri, 25 Oct 2024 01:49:01 GMT, Alexander Matveev
wrote:
> - It is not clear on which macOS versions codesign fails if application
> bundle contains additional content.
> - As a result test was modified to generate only application image, since PKG
> or DMG cannot be generated if signing fai
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote:
> Moved from
> https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16:
>
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
>
On Fri, 25 Oct 2024 12:00:43 GMT, Coleen Phillimore wrote:
>> src/hotspot/share/runtime/synchronizer.cpp line 1440:
>>
>>> 1438: }
>>> 1439:
>>> 1440: ObjectMonitor* ObjectSynchronizer::inflate_impl(JavaThread*
>>> inflating_thread, oop object, const InflateCause cause) {
>>
>> `inflating_thr
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 16:29:52 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
Remove `--compress` from jlink command lines in jpackage tests
-
Commit messages:
- 8343102: Remove `--compress` from jlink command lines from jpackage tests
Changes: https://git.openjdk.org/jdk/pull/21723/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21723&range=00
Iss
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Fri, 25 Oct 2024 20:53:09 GMT, Jiangli Zhou wrote:
> There is an issue from my last push. It includes unintended merged changes
> from head. It's probably because I did a cherrypick for my fix when creating
> the initial PR. Let me close this PR and create a new one. I'll link all
> existin
On Fri, 25 Oct 2024 16:47:31 GMT, Alexey Ivanov wrote:
>> This doubt applies to all the tests which exercise lazy values or similar
>> logic… without and *with* the security manager.
>>
>> Now, without the security manager, the problematic cases are no longer
>> relevant; the common path *with
> - merge EmptyFolderTest, EmptyFolderPackageTest and EmptyFolderTestBase in
> EmptyFolderTest class.
> - for .msi packaging still verify the output. It should not contain empty
> folders from `--input`, but should contain other folders and files from
> `--input`.
> - fixed `TKit.assertPathNotE
On Fri, 25 Oct 2024 18:08:16 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
Make `BasicTest.testTemp()` test cases run jpackage with non-empty `--temp`
directory only once instead of twice.
Add additional checks jpackage doesn't change contents of `--temp` directory if
it aborts execution.
-
Commit messages:
- 8343101: Rework BasicTest.testTemp test cases
On Wed, 23 Oct 2024 22:14:13 GMT, Jiangli Zhou wrote:
> Please review the fix that uses String type for the mapped value in
> ModuleLoaderMap.Mapper map (Map). Please see details in
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
This pull request has been closed without being integrate
On Fri, 25 Oct 2024 20:11:36 GMT, Jiangli Zhou wrote:
>> Please review the fix that uses String type for the mapped value in
>> ModuleLoaderMap.Mapper map (Map). Please see details in
>> https://bugs.openjdk.org/browse/JDK-8342642, thanks.
>
> Jiangli Zhou has updated the pull request increment
> Make jpackage correctly handle the output directory (`--dest`) that is:
> - a subdirectory of the input directory;
> - the same as the input directory.
>
> Make jpackage correctly handle temp directory (`--temp`) that is:
> - a subdirectory of the input directory.
>
> jpackage will produce a
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition
> frames hiding mechanism.
> Please, see a fix description in the first comment.
>
> Testing:
> - Verified with new test `vthread/CheckHiddenFrames`
> - Mach5 tiers 1-6 are passed
Serguei Spitsyn has updated the pull re
On Fri, 25 Oct 2024 14:36:46 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Fri, 25 Oct 2024 18:08:17 GMT, Ashutosh Mehra wrote:
>> Ioi Lam has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8342907: Implement AOT testing mode for jtreg tests (authored by
>> @katyapav)
>> - disable test that fails with hotsp
On Thu, 24 Oct 2024 03:01:54 GMT, Ioi Lam wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://openjdk.org/jeps/483).
>>
>>
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Thu, 24 Oct 2024 03:01:40 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor fixes in inc/dec_held_monitor_count on aarch64 and riscv
>
> src/java.base/share/classes/java/lang/Virt
On Fri, 25 Oct 2024 11:17:13 GMT, Alan Bateman wrote:
>>> I think the main thing with this PR is whether canSeek is the right thing
>>> to use.
>>
>> `canSeek` is really the same as `isOther` in the recent
>> `Files.newInputStream` change, but given that on Windows the result of the
>> functi
On Fri, 25 Oct 2024 18:30:23 GMT, Harshitha Onkar wrote:
>> The updated test `bug6694823.java` works correctly on Windows and displays
>> its popup over the Windows taskbar — it is expected.
>>
>> The popup had to be moved if the security manager didn't allow to call
>> `setAlwaysOnTop(true)`.
On Fri, 25 Oct 2024 05:25:58 GMT, David Holmes wrote:
>> Patricio Chilano Mateo has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Add/fix comments for David
>> - Move condition to new line in nmethod::preserve_callee_argument_oops
>
> s
On Fri, 25 Oct 2024 18:39:54 GMT, Patricio Chilano Mateo
wrote:
>>> The "waiting list" here is just a list of virtual threads that need
>>> unparking by the Unblocker thread - right?
>>>
>> Yes.
>
>> Some comments here about the operation would be useful.
>>
> Added a comment.
> I'm struggling
On Fri, 25 Oct 2024 00:26:24 GMT, David Holmes wrote:
> The "waiting list" here is just a list of virtual threads that need unparking
> by the Unblocker thread - right?
>
Yes.
> src/hotspot/share/classfile/javaClasses.cpp line 2086:
>
>> 2084: jboolean vthread_on_list = Atomic::load(addr);
>
On Fri, 25 Oct 2024 18:39:23 GMT, Patricio Chilano Mateo
wrote:
>> src/hotspot/share/classfile/javaClasses.cpp line 2082:
>>
>>> 2080: }
>>> 2081:
>>> 2082: bool java_lang_VirtualThread::set_onWaitingList(oop vthread,
>>> OopHandle& list_head) {
>>
>> Some comments here about the operation w
On Fri, 25 Oct 2024 10:45:00 GMT, Aleksey Shipilev wrote:
> > In that sense, I think we don't have a risk of potentially with
> > `used_Integer > IntegerCache.high`. The idea described in Ioi's comment
> > above (also brought up by Aleksey Shipilev separately during premain
> > meeting) could
On Fri, 25 Oct 2024 17:52:59 GMT, Alexey Ivanov wrote:
>> This particular test was failing on windows & linux after SM removal. There
>> is a functional issue and for that reason I think it is better to retain
>> this test. Details documented here -
>> [JDK-8342012](https://bugs.openjdk.org/br
> This is the implementation of JEP 491: Synchronize Virtual Threads without
> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
> further details.
>
> In order to make the code review easier the changes have been split into the
> following initial 4 commits:
>
> - Change
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
On Fri, 25 Oct 2024 17:04:22 GMT, Brian Burkhalter wrote:
>> Modify `FileInputStream` (FIS) to fall back to the superclass
>> implementations of `readAllBytes()`, `readNBytes(int)`, `skip()`, and
>> `transferTo` when the input source would otherwise fail with "Illegal Seek"
>> in the FIS imple
On Fri, 25 Oct 2024 16:47:42 GMT, Maurizio Cimadamore
wrote:
>> This PR fixes an issue where passing many by-reference parameters to
>> downcall results in escape analysis failures.
>> The problem is that, as the parameters grow, the generated code in the
>> trampoline stub we generate also gr
On Fri, 25 Oct 2024 13:17:23 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 17:30:56 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/JPopupMenu/6694823/bug6694823.java line 41:
>>
>>> 39: * @bug 6694823
>>> 40: * @summary Checks that popup menu cannot be partially hidden
>>> 41: * by the task bar.
>>
>> I believe this test is irrelev
On Fri, 25 Oct 2024 13:17:23 GMT, Patricio Chilano Mateo
wrote:
>> This is the implementation of JEP 491: Synchronize Virtual Threads without
>> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for
>> further details.
>>
>> In order to make the code review easier the change
On Fri, 25 Oct 2024 14:57:18 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
I hereby request for comments on the proposal to generalize the existing
method "String.getChars()"'s signature to become a new default interface
method "CharSequence.getChars()".
Problem
For performance reasons, many CharSequence implementations, in particular
String, StringBuilder, String
> 8342566: Improve javadoc of java.lang.annotation.ElementType
Kevin Bourrillion has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains eight additional
commi
On Fri, 25 Oct 2024 16:29:52 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 25 Oct 2024 15:06:45 GMT, Alexey Semenyuk wrote:
>> Make jpackage correctly handle the output directory (`--dest`) that is:
>> - a subdirectory of the input directory;
>> - the same as the input directory.
>>
>> Make jpackage correctly handle temp directory (`--temp`) that is:
>> - a
> Modify `FileInputStream` (FIS) to fall back to the superclass implementations
> of `readAllBytes()`, `readNBytes(int)`, `skip()`, and `transferTo` when the
> input source would otherwise fail with "Illegal Seek" in the FIS
> implementation, such as for the standard input or a named pipe.
Bria
> Modify `FileInputStream` (FIS) to fall back to the superclass implementations
> of `readAllBytes()`, `readNBytes(int)`, `skip()`, and `transferTo` when the
> input source would otherwise fail with "Illegal Seek" in the FIS
> implementation, such as for the standard input or a named pipe.
Bria
On Fri, 25 Oct 2024 15:29:40 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/UIDefaults/6622002/bug6622002.java line 1:
>>
>>> 1: /*
>>
>> Again, I'm unsure this test has a value after the security manager is
>> removed. All it verifies is that whatever reflection is used in
>> `UIDefaults.
On Fri, 25 Oct 2024 15:12:00 GMT, Alexey Ivanov wrote:
>> Sean Mullan has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 150 commits:
>>
>> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411
>> - Merge
>> - Updat
On Thu, 24 Oct 2024 13:19:55 GMT, Sean Mullan wrote:
>> This is the implementation of JEP 486: Permanently Disable the Security
>> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The
>> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the
>> main ch
1 - 100 of 186 matches
Mail list logo
