On Fri, 25 Oct 2024 11:17:13 GMT, Alan Bateman <al...@openjdk.org> wrote:
>>> I think the main thing with this PR is whether canSeek is the right thing >>> to use. >> >> `canSeek` is really the same as `isOther` in the recent >> `Files.newInputStream` change, but given that on Windows the result of the >> function is always `true`, the naming `isOther` (which would always return >> `false`) did not seem apropos. > > I think it would be limit to limit is to regular files, in which case canSeek > could be isRegularFile and just check S_ISREG. The Windows implementation > that just assume it's a regular file until there is a better implementation. > Up to you but I think it would make it much clearer. Longer time we need to > re-target this to use FileChannelImpl but several issues to work through > before then. So changed in [0bb34b4](https://github.com/openjdk/jdk/pull/21673/commits/0bb34b4d62d9ac89b9d84098a6df95b77838c724). ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21673#discussion_r1817218477
