On Sat, 26 Oct 2024 00:41:43 GMT, Alex Menkov <amen...@openjdk.org> wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review: introduce new annotation @JvmtiHideEvents and use it in >> VirtualThread/Continuation classes to disallow FramePop requests > > src/java.base/share/classes/jdk/internal/vm/annotation/JvmtiMountTransition.java > line 38: > >> 36: * >> 37: * @implNote >> 38: * This annotation is only used for the VirtualThread notifyJvmti* >> methods. > > What about VirtualThread.switchToCarrierThread and > VirtualThread.switchToVirtualThread ? They also have the annotation. We working to remove these two methods. I think the main thing for JvmtiMountTransition is that the interface description provides enough information to know when the annotation is needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21397#discussion_r1817689498
