> Please review the fix that uses String type for the mapped value in 
> ModuleLoaderMap.Mapper map (Map<String, String>). Please see details in 
> https://bugs.openjdk.org/browse/JDK-8342642, thanks.

Jiangli Zhou has updated the pull request incrementally with 109 additional 
commits since the last revision:

 - Reflect review feedback:
   - Rename [APP|PLATFORM]_LOADER_INDEX to [APP|PLATFORM]_LOADER_NAME.
   
   - Update loader map index related comments.
   
   - Change to use '.equals()' (from '==') when comparing loader map values.
   
   Runs on Debian 6.9.10
   
   With '=='
    Performance counter stats for 'images/jdk/bin/java -cp 
/.../home/jianglizhou/tests/hw.jar HelloWorld' (100 runs):
   
               133.08 msec task-clock:u                     #    1.181 CPUs 
utilized               ( +-  0.29% )
                    0      context-switches:u               #    0.000 /sec
                    0      cpu-migrations:u                 #    0.000 /sec
                5,940      page-faults:u                    #   44.636 K/sec    
                   ( +-  0.02% )
          139,151,067      cycles:u                         #    1.046 GHz      
                   ( +-  0.24% )
          158,618,665      instructions:u                   #    1.14  insn per 
cycle              ( +-  0.00% )
           27,343,220      branches:u                       #  205.471 M/sec    
                   ( +-  0.00% )
              746,103      branch-misses:u                  #    2.73% of all 
branches             ( +-  0.63% )
   
             0.112697 +- 0.000386 seconds time elapsed  ( +-  0.34% ).
   
   With '.equals()':
    Performance counter stats for 'images/jdk/bin/java -cp 
/usr/local/google/home/jianglizhou/tests/hw.jar HelloWorld' (100 runs):
   
               133.26 msec task-clock:u                     #    1.186 CPUs 
utilized               ( +-  0.34% )
                    0      context-switches:u               #    0.000 /sec
                    0      cpu-migrations:u                 #    0.000 /sec
                5,941      page-faults:u                    #   44.581 K/sec    
                   ( +-  0.02% )
          141,082,552      cycles:u                         #    1.059 GHz      
                   ( +-  0.25% )
          158,619,823      instructions:u                   #    1.12  insn per 
cycle              ( +-  0.00% )
           27,343,260      branches:u                       #  205.184 M/sec    
                   ( +-  0.00% )
              743,257      branch-misses:u                  #    2.72% of all 
branches             ( +-  0.68% )
   
             0.112399 +- 0.000505 seconds time elapsed  ( +-  0.45% )
 - 8343086: [BACKOUT] JDK-8295269 G1: Improve slow startup due to predictor 
initialization
   
   Reviewed-by: sangheki
 - 8339289: Enhance Attach API to support arbitrary length arguments - Windows
   
   Reviewed-by: kevinw, sspitsyn
 - 8342934: TYPE_USE annotations printed with error causing "," in toString 
output
   
   Reviewed-by: iris, vromero
 - 8338426: Test java/nio/channels/Selector/WakeupNow.java failed
   
   Reviewed-by: jpai, alanb
 - 8295269: G1: Improve slow startup due to predictor initialization
   
   Reviewed-by: iwalulya, sjohanss
 - 8342930: New tests from JDK-8335912 are failing
   
   Reviewed-by: jpai
 - 8343063: RISC-V: remove redundant reg copy in generate_resolve_blob
   
   Reviewed-by: fyang, rehn
 - 8343060: RISC-V: enable TestFloat16VectorConvChain for riscv
   
   Reviewed-by: fyang
 - 8342953: RISC-V: Fix definition of RISCV_HWPROBE_EXT_ZVFHMIN
   
   Reviewed-by: mli, rehn
 - ... and 99 more: https://git.openjdk.org/jdk/compare/ade90fb5...94f35861

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21672/files
  - new: https://git.openjdk.org/jdk/pull/21672/files/ade90fb5..94f35861

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21672&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21672&range=00-01

  Stats: 32526 lines in 383 files changed: 11133 ins; 19908 del; 1485 mod
  Patch: https://git.openjdk.org/jdk/pull/21672.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21672/head:pull/21672

PR: https://git.openjdk.org/jdk/pull/21672

Reply via email to