On Tue, 22 Oct 2024 15:56:18 GMT, Paul Sandoz <psan...@openjdk.org> wrote:
>> Hey @eme64 , >> >>> Wow this is really a very moving target - quite frustrating to review - it >>> takes up way too much of the reviewers bandwidth. You really need to split >>> up your PRs as much as possible so that review is easier and faster. >> >> I understand reviewer's pain, which is why I mentioned about last two >> changes specifically. Vector API related PRs generally looks bulky due to >> script generated sources and tests. Barring that it may not demand much of >> your time. >> >> But, to keep you motivated :-) and following @PaulSandoz and yours >> suggestions, I have moved out IR validations and Min / Max transforms to >> following follow up PRs. >> >> - https://bugs.openjdk.org/browse/JDK-8342676 >> (https://github.com/openjdk/jdk/pull/21604) >> - https://bugs.openjdk.org/browse/JDK-8342677 >> (https://github.com/openjdk/jdk/pull/21603) >> >> Can you kindly run this though your test infrastructure and approve if it >> goes fine ? >> >> Best Regards, >> Jatin > >> Can you kindly run this though your test infrastructure and approve if it >> goes fine ? >> > > Internal tier 1 to 3 testing passed (i needed to merge with master at > 7133d1b983d, due to some updates to unrelated test configuration files the > test infrastructure expects). @PaulSandoz Looks like you also need to re-approve. ------------- PR Comment: https://git.openjdk.org/jdk/pull/20507#issuecomment-2438938409
