On Tue, 10 Jan 2023 16:06:15 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nam
On Tue, 10 Jan 2023 23:38:14 GMT, Maurizio Cimadamore
wrote:
>> OK I'm glad you pointed that out because I'm a little unclear on the best
>> way to do this bit.
>>
>> Just to confirm, you are saying that this:
>>
>> `if (erasure(type).equalsIgnoreMetadata(outerType)) {`
>>
>> should be repla
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the compiler
A small doc clarification that also specifies where the additional
MemorySegment parameter of a downcall method handle linked with the
captureCallState option appears in the parameter list, on the CaptureCallState
class.
-
Commit messages:
- add parameter order clarification
Chan
On Wed, 11 Jan 2023 00:04:14 GMT, Maurizio Cimadamore
wrote:
>> Yes, because the 'this' reference can bounce around through different
>> variables in scope each time around the loop. So we have to repeat the loop
>> until all 'this' references have "flooded" into all the nooks and crannies.
>>
On Tue, 10 Jan 2023 19:20:35 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 1098:
>>
>>> 1096: private void visitLooped(T tree, Consumer
>>> visitor) {
>>> 1097: this.visitScoped(tree, false, t -> {
>>> 1098:
On Tue, 10 Jan 2023 23:45:59 GMT, Maurizio Cimadamore
wrote:
>> It's slightly different from that.
>>
>> Considering any of the various things in scope that can point to an object
>> (these are: the current 'this' instance, the current outer 'this' instance,
>> method parameter/variable, meth
On Tue, 10 Jan 2023 19:18:04 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEscapeAnalyzer.java
>> line 85:
>>
>>> 83: *
>>> 84: *
>>> 85: * When tracking references, we distinguish between direct references
>>> and indirect references,
>>
>> I'
On Tue, 10 Jan 2023 19:42:06 GMT, Archie L. Cobbs wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 2345:
>>
>>> 2343: if (!innerType.hasTag(CLASS) || !outerType.hasTag(CLASS))
>>> 2344: return false;
>>> 2345: innerType = erasure(inner
On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
> updated to reflect the current state of Java and can be modernized:
>
> * Add `@Serial` annotations
> * Seal classes and restrict subclassing for internal class
On Tue, 10 Jan 2023 17:17:41 GMT, Naoto Sato wrote:
> Fixing the subject method to recover gracefully on a failed
> `ZoneRulesProvider` registration.
Marked as reviewed by joehw (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11928
On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
> updated to reflect the current state of Java and can be modernized:
>
> * Add `@Serial` annotations
> * Seal classes and restrict subclassing for internal class
On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
> updated to reflect the current state of Java and can be modernized:
>
> * Add `@Serial` annotations
> * Seal classes and restrict subclassing for internal class
On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
> updated to reflect the current state of Java and can be modernized:
>
> * Add `@Serial` annotations
> * Seal classes and restrict subclassing for internal class
On Tue, 10 Jan 2023 19:59:36 GMT, Roger Riggs wrote:
> Since you are updating the example, perhaps they should use `@snippet
> lang="java" { }` instead of the @code and blockquote markup.
That's a good point and Lance brought that up as well, I will create a separate
issue to address inst
On Tue, 10 Jan 2023 17:17:41 GMT, Naoto Sato wrote:
> Fixing the subject method to recover gracefully on a failed
> `ZoneRulesProvider` registration.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.org/jdk/pull/11928
On Tue, 10 Jan 2023 17:17:41 GMT, Naoto Sato wrote:
> Fixing the subject method to recover gracefully on a failed
> `ZoneRulesProvider` registration.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11928
On Tue, 10 Jan 2023 18:02:22 GMT, Justin Lu wrote:
>> The javadocs of the following methods used deprecated constructors of the
>> primitive wrapper classes:
>>
>> java.lang.ArrayStoreException
>> java.lang.ClassCastException
>> java.lang.Double.compare(double, double)
>> java.lang.Float.compar
On Tue, 10 Jan 2023 18:02:22 GMT, Justin Lu wrote:
>> The javadocs of the following methods used deprecated constructors of the
>> primitive wrapper classes:
>>
>> java.lang.ArrayStoreException
>> java.lang.ClassCastException
>> java.lang.Double.compare(double, double)
>> java.lang.Float.compar
On Tue, 10 Jan 2023 18:02:22 GMT, Justin Lu wrote:
>> The javadocs of the following methods used deprecated constructors of the
>> primitive wrapper classes:
>>
>> java.lang.ArrayStoreException
>> java.lang.ClassCastException
>> java.lang.Double.compare(double, double)
>> java.lang.Float.compar
On Tue, 10 Jan 2023 18:02:22 GMT, Justin Lu wrote:
>> The javadocs of the following methods used deprecated constructors of the
>> primitive wrapper classes:
>>
>> java.lang.ArrayStoreException
>> java.lang.ClassCastException
>> java.lang.Double.compare(double, double)
>> java.lang.Float.compar
> This PR adds a new lint warning category `this-escape`.
>
> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
> allow the JDK to continue to compile with `-Xlint:all`.
>
> A 'this' escape warning is generated for a constructor `A()` in a class `A`
> when the compiler
On Tue, 10 Jan 2023 18:40:28 GMT, Justin Lu wrote:
> > Given that type conversions create the primitive wrapper instances when
> > they are needed, I think the examples should be reconsidered. They
> > needlessly suggest that the wrapper instances need to be explicitly created.
>
> Hi Roger, t
On Tue, 10 Jan 2023 18:02:22 GMT, Justin Lu wrote:
>> The javadocs of the following methods used deprecated constructors of the
>> primitive wrapper classes:
>>
>> java.lang.ArrayStoreException
>> java.lang.ClassCastException
>> java.lang.Double.compare(double, double)
>> java.lang.Float.compar
On Mon, 9 Jan 2023 14:23:47 GMT, Maurizio Cimadamore
wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix incorrect @bug numbers in unit tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.j
On Mon, 9 Jan 2023 15:03:10 GMT, Maurizio Cimadamore
wrote:
>> Archie L. Cobbs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix incorrect @bug numbers in unit tests.
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/comp/ThisEsc
On Tue, 10 Jan 2023 16:06:15 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nam
On Sat, 7 Jan 2023 21:08:07 GMT, Archie L. Cobbs wrote:
>> This PR adds a new lint warning category `this-escape`.
>>
>> It also adds `@SuppressWarnings` annotations as needed to the JDK itself to
>> allow the JDK to continue to compile with `-Xlint:all`.
>>
>> A 'this' escape warning is gener
On Tue, 10 Jan 2023 18:07:54 GMT, Roger Riggs wrote:
> Given that type conversions create the primitive wrapper instances when they
> are needed, I think the examples should be reconsidered. They needlessly
> suggest that the wrapper instances need to be explicitly created.
Hi Roger, thanks fo
On Tue, 10 Jan 2023 16:06:15 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nam
On Tue, 10 Jan 2023 18:02:22 GMT, Justin Lu wrote:
>> The javadocs of the following methods used deprecated constructors of the
>> primitive wrapper classes:
>>
>> java.lang.ArrayStoreException
>> java.lang.ClassCastException
>> java.lang.Double.compare(double, double)
>> java.lang.Float.compar
On Thu, 5 Jan 2023 20:10:45 GMT, Alexey Semenyuk wrote:
> 8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed
> AddLauncherTest.bug8230933
This pull request has now been integrated.
Changeset: c595f965
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/jdk/commit/c595f96
On Mon, 9 Jan 2023 22:53:18 GMT, Alexey Semenyuk wrote:
> Increase failed test timeouts.
> Simple tests got an x1.5 increase and parametrized tests got an x2 increase
This pull request has now been integrated.
Changeset: 3c99e786
Author:Alexey Semenyuk
URL:
https://git.openjdk.org/j
> The javadocs of the following methods used deprecated constructors of the
> primitive wrapper classes:
>
> java.lang.ArrayStoreException
> java.lang.ClassCastException
> java.lang.Double.compare(double, double)
> java.lang.Float.compare(float, float)
> java.lang.Integer.getInteger(String, int)
On Tue, 10 Jan 2023 01:50:45 GMT, Jaikiran Pai wrote:
>> Like Naoto notes, my understanding of it is that the `@systemProperty`
>> should appear only once at the place where the semantics of that system
>> property is being defined. This mail, which was sent when this tag was
>> introduced, ha
On Tue, 10 Jan 2023 15:26:05 GMT, Per Minborg wrote:
> This PR proposes to add null-checking for some parameter arguments in
> `ZipFileStore`.
Thanks for taking this on Per.
I think we also need to add a test for getAttribute() and
getFileStoreAttributeView() as I do not see it being tested
On Tue, 10 Jan 2023 15:52:51 GMT, Per Minborg wrote:
>> src/java.base/share/classes/java/io/ObjectStreamConstants.java line 38:
>>
>>> 36: * Magic number that is written to the stream header.
>>> 37: */
>>> 38: short STREAM_MAGIC = (short)0xaced;
>>
>> I'd prefer to retain the `st
On Tue, 10 Jan 2023 16:06:15 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nam
Fixing the subject method to recover gracefully on a failed `ZoneRulesProvider`
registration.
-
Commit messages:
- Added a test
- 8299571: ZoneRulesProvider.registerProvider() can leave inconsistent state
on failure
Changes: https://git.openjdk.org/jdk/pull/11928/files
Webrev: h
On Thu, 5 Jan 2023 20:45:20 GMT, Mandy Chung wrote:
> Trivial fix. Fix `Invokers.checkExactType` to call
> `newWrongMethodTypeException(actual, expected)` with parameters in right
> order.
This pull request has now been integrated.
Changeset: a86b6f6f
Author:Mandy Chung
URL:
http
Hi,
ZipFile.isSignatureRelated currently returns true for paths such as the
following:
META-INF/libraries/org.bouncycastle:bcprov-jdk15on:jar-1.70/META-INF/BC2048KE.DSA
While this path does start with "META-INF/" and ends with ".DSA", the file
does not live in the META-INF/ directory _directly_,
On Tue, 10 Jan 2023 00:46:35 GMT, Justin Lu wrote:
>> The system property _user.timezone_ is specified in the
>> _TimeZone.getDefault()_ and _TimeZone.setDefault()_ methods. The javadoc
>> search box should be able to match on the system property name.
>>
>> This change replaces the **@code**
> Code in java.io contains many legacy constructs and semantics not recommended
> including:
>
> * C-style array declaration
> * Unnecessary visibility
> * Redundant keywords in interfaces (e.g. public, static)
> * Non-standard naming for constants
> * Javadoc typos
> * Missing final declar
On Tue, 10 Jan 2023 14:59:35 GMT, Roger Riggs wrote:
>> Per Minborg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert removal of a final keyword
>
> src/java.base/share/classes/java/io/ObjectStreamConstants.java line 38:
>
>> 36:
This PR proposes to add null-checking for some parameter arguments in
`ZipFileStore`.
-
Commit messages:
- Check null invariants
Changes: https://git.openjdk.org/jdk/pull/11926/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=11926&range=00
Issue: https://bugs.openjdk.org/
> Add experimental Foreign Function & Memory API support for RISC-V.
>
> For details of the FFM API RISC-V port please refer to [JBS
> issue](https://bugs.openjdk.org/browse/JDK-8293841)
>
> Testing:
>
> - [x] jdk_foreign with release/fastdebug build
> - [x] run TestMatrix.java manually with re
On Tue, 10 Jan 2023 13:34:49 GMT, Per Minborg wrote:
>> Code in java.io contains many legacy constructs and semantics not
>> recommended including:
>>
>> * C-style array declaration
>> * Unnecessary visibility
>> * Redundant keywords in interfaces (e.g. public, static)
>> * Non-standard nam
On Tue, 10 Jan 2023 14:04:38 GMT, Maurizio Cimadamore
wrote:
> When unifying memory address with memory segments, we missed the case where a
> heap memory segment is passed as a value to a var handle address setters.
>
> The solution is to reuse the same check we use when validating segment
>
When unifying memory address with memory segments, we missed the case where a
heap memory segment is passed as a value to a var handle address setters.
The solution is to reuse the same check we use when validating segment downcall
parameters also for segment memory writes.
-
Commi
> Add experimental Foreign Function & Memory API support for RISC-V.
>
> For details of the FFM API RISC-V port please refer to [JBS
> issue](https://bugs.openjdk.org/browse/JDK-8293841)
>
> Testing:
>
> - [x] jdk_foreign with release/fastdebug build
> - [x] run TestMatrix.java manually with re
On Tue, 10 Jan 2023 12:04:10 GMT, Pavel Rappo wrote:
> I'm sure others will note or have already noted elsewhere that we don't do
> direct PRs against JSR 166.
Yes. I will change the PR to a draft as we explore ways to integrate the spirit
of the proposed changes.
-
PR: https://g
> Code in java.io contains many legacy constructs and semantics not recommended
> including:
>
> * C-style array declaration
> * Unnecessary visibility
> * Redundant keywords in interfaces (e.g. public, static)
> * Non-standard naming for constants
> * Javadoc typos
> * Missing final declar
Filled https://bugs.openjdk.org/browse/JDK-8299864
Andrey Turbanov
вт, 10 янв. 2023 г. в 13:24, Alan Bateman :
>
>
>
> On 10/01/2023 09:35, Andrey Turbanov wrote:
> > Hello.
> > I've noticed that ZipFileStore#supportsFileAttributeView(String)
> > doesn't throw NullPointerException when 'null' is
On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
> updated to reflect the current state of Java and can be modernized:
>
> * Add `@Serial` annotations
> * Seal classes and restrict subclassing for internal class
On Tue, 10 Jan 2023 09:14:11 GMT, Andrey Turbanov wrote:
>> `jdk.internal.jrtfs.JrtFileSystem#getFileAttributes` never return `null`
>>
>> https://github.com/openjdk/jdk/blob/679e485838881c1364845072af305fb60d95e60a/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java#L206-L213
>> S
`java.util.concurrent.ConcurrentHashMap` is relatively old and has not been
updated to reflect the current state of Java and can be modernized:
* Add `@Serial` annotations
* Seal classes and restrict subclassing for internal classes
* Use pattern matching for instance
* Remove redundant modif
On 10/01/2023 09:35, Andrey Turbanov wrote:
Hello.
I've noticed that ZipFileStore#supportsFileAttributeView(String)
doesn't throw NullPointerException when 'null' is passed as an
argument.
public boolean supportsFileAttributeView(String name) {
return "basic".equals(name) || "zip".equals
Hi Alexey,
great! I've created the PR: https://github.com/openjdk/jdk/pull/11922
Best regards,
David Schumann
Am Mo., 9. Jan. 2023 um 23:57 Uhr schrieb Alexey Semenyuk <
alexey.semen...@oracle.com>:
> Hi David,
>
> The request to adjust osx linker command lines looks reasonable. Please
> go a
Hello.
I've noticed that ZipFileStore#supportsFileAttributeView(String)
doesn't throw NullPointerException when 'null' is passed as an
argument.
public boolean supportsFileAttributeView(String name) {
return "basic".equals(name) || "zip".equals(name) ||
(("owner".equals(name) || "po
> `jdk.internal.jrtfs.JrtFileSystem#getFileAttributes` never return `null`
>
> https://github.com/openjdk/jdk/blob/679e485838881c1364845072af305fb60d95e60a/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java#L206-L213
> So, no need to check for `null` its result.
> Seems it was copie
On Mon, 9 Jan 2023 20:55:14 GMT, Andrey Turbanov wrote:
> `jdk.internal.jrtfs.JrtFileSystem#getFileAttributes` never return `null`
>
> https://github.com/openjdk/jdk/blob/679e485838881c1364845072af305fb60d95e60a/src/java.base/share/classes/jdk/internal/jrtfs/JrtFileSystem.java#L206-L213
> So, no
On Mon, 9 Jan 2023 18:34:57 GMT, Per Minborg wrote:
> On the note of `CHM::isEmpty`: It would be better to rewrite this method as a
> short-circuitable reduction of the many CounterCells' values. As soon as at
> least one of them are >0 then the map is not empty. In contrast, today we sum
> al
On Sat, 10 Dec 2022 18:11:30 GMT, Victor Toni wrote:
> Being able to compare instances of Throwable allows simple detection of
> exceptions raised by the same circumstances. Comparison allows for reduction
> of excessive logging e.g. in hotspots without requiring custom code to
> compare Throw
63 matches
Mail list logo
