On Tue, 10 Jan 2023 16:06:15 GMT, Per Minborg <pminb...@openjdk.org> wrote:
>> Code in java.io contains many legacy constructs and semantics not >> recommended including: >> >> * C-style array declaration >> * Unnecessary visibility >> * Redundant keywords in interfaces (e.g. public, static) >> * Non-standard naming for constants >> * Javadoc typos >> * Missing final declaration >> >> These should be fixed as a sanity effort. > > Per Minborg has updated the pull request incrementally with one additional > commit since the last revision: > > Revert removal of static modifier in OSC src/java.base/share/classes/java/io/ObjectStreamConstants.java line 123: > 121: * new Proxy Class Descriptor. > 122: */ > 123: static byte TC_PROXYCLASSDESC = (byte)0x7D; alignment is confusing here. As we touch every constant here I suggest to realign all values properly. (Or remove alignment attempt completely.) ------------- PR: https://git.openjdk.org/jdk/pull/11848
