On Tue, 10 Jan 2023 10:32:34 GMT, Per Minborg <pminb...@openjdk.org> wrote:
> `java.util.concurrent.ConcurrentHashMap` is relatively old and has not been > updated to reflect the current state of Java and can be modernized: > > * Add `@Serial` annotations > * Seal classes and restrict subclassing for internal classes > * Use pattern matching for instance > * Remove redundant modifiers (such as some final declarations) > * Use Objects.requireNonNull for invariant checking > * Use diamond operators instead of explicit types > * Simplify expressions using Math::max src/java.base/share/classes/java/util/concurrent/ConcurrentHashMap.java line 2002: > 2000: } > 2001: if (delta != 0) > 2002: addCount((long)delta, binCount); Not sure why delta is not declared long as in clear(). But if not, then the explicit cast is documentation of the implementation choice to declare it int. ------------- PR: https://git.openjdk.org/jdk/pull/11924
