On Tue, 10 Jan 2023 15:52:51 GMT, Per Minborg <pminb...@openjdk.org> wrote:

>> src/java.base/share/classes/java/io/ObjectStreamConstants.java line 38:
>> 
>>> 36:      * Magic number that is written to the stream header.
>>> 37:      */
>>> 38:     short STREAM_MAGIC = (short)0xaced;
>> 
>> I'd prefer to retain the `static`, it is easier to read and not have to 
>> remember that this declaration is in an interface.
>
> I think the class should not be an interface in the first place but this is 
> hard to change now.

Just because the static is not required does NOT mean it should be omitted!.

-------------

PR: https://git.openjdk.org/jdk/pull/11848

Reply via email to