[GitHub] [incubator-nuttx] yamt commented on pull request #2222: Use a few integer types from the compiler

2020-11-17 Thread GitBox
yamt commented on pull request #: URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-728757341 > All patches fix the type mismatch issue, why split it into multiple small one(e.g. sim has 4 patch). have you read the commit messages fo those 4 patches? >

[GitHub] [incubator-nuttx] diegoherranz opened a new pull request #2321: drivers/leds/apa102: remove/fix references to I2C/LM-75 (comments only)

2020-11-17 Thread GitBox
diegoherranz opened a new pull request #2321: URL: https://github.com/apache/incubator-nuttx/pull/2321 Just fixing wrong comments from copy-paste. Thanks! This is an automated message from the Apache Git Service. T

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2222: Use a few integer types from the compiler

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #: URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-728764827 > > All patches fix the type mismatch issue, why split it into multiple small one(e.g. sim has 4 patch). > > have you read the commit messages fo those 4 p

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
jerpelea commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r524969933 ## File path: drivers/audio/cxd56.c ## @@ -1370,22 +1375,24 @@ static void cxd56_dma_int_handler(void) flags = spin_lock_irqsave(); -

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r524994088 ## File path: drivers/audio/cxd56.c ## @@ -1272,6 +1276,151 @@ static void cxd56_reset_channel_sel(cxd56_dmahandle_t handle) } } +#i

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2321: drivers/leds/apa102: remove/fix references to I2C/LM-75 (comments only)

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #2321: URL: https://github.com/apache/incubator-nuttx/pull/2321#issuecomment-728795620 @diegoherranz please help fix minor nxstyle warning here: https://github.com/apache/incubator-nuttx/pull/2321/checks?check_run_id=1410972471 ``` Error:

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2322: arch/arm/src/stm32h7/stm32_otghost.c: Fix undeclared "ret".

2020-11-17 Thread GitBox
Ouss4 opened a new pull request #2322: URL: https://github.com/apache/incubator-nuttx/pull/2322 ## Summary fix #2314 ## Impact ## Testing This is an automated message from the Apache Git Service. To resp

[GitHub] [incubator-nuttx] Ouss4 commented on issue #2314: chip/stm32_otghost.c doesn't build , have C errors

2020-11-17 Thread GitBox
Ouss4 commented on issue #2314: URL: https://github.com/apache/incubator-nuttx/issues/2314#issuecomment-728805098 Thanks for reporting the error, #2322 should fix this. This is an automated message from the Apache Git Servic

[GitHub] [incubator-nuttx] kernelgurumeditation commented on issue #2314: chip/stm32_otghost.c doesn't build , have C errors

2020-11-17 Thread GitBox
kernelgurumeditation commented on issue #2314: URL: https://github.com/apache/incubator-nuttx/issues/2314#issuecomment-728812416 Have you noticed the: chip/stm32_otghost.c:1235:33: error: expected ';', ',' or ')' before 'uint8_t' Not sure if it was fixed in a previous com

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525015043 ## File path: drivers/audio/cxd56.c ## @@ -3269,27 +3415,38 @@ static int cxd56_enqueuebuffer(FAR struct audio_lowerhalf_s *lower, FAR st

[GitHub] [incubator-nuttx] kernelgurumeditation opened a new issue #2323: Howto to build external apps(elf)?

2020-11-17 Thread GitBox
kernelgurumeditation opened a new issue #2323: URL: https://github.com/apache/incubator-nuttx/issues/2323 Hello... I have read all the howtos, videos..., tried with symbols, without symbols. Gone back to 9. ... 8... versions and it never works I enabled elf loader debug in t

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525028253 ## File path: drivers/audio/cxd56_src.c ## @@ -0,0 +1,596 @@ +/ +

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525028253 ## File path: drivers/audio/cxd56_src.c ## @@ -0,0 +1,596 @@ +/ +

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1852: sysconf: add _SC_PAGESIZE sysconf support

2020-11-17 Thread GitBox
xiaoxiang781216 merged pull request #1852: URL: https://github.com/apache/incubator-nuttx/pull/1852 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated: sysconf: add _SC_PAGESIZE sysconf support

2020-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new fd94a32 sysconf: add _SC_PAGESIZE s

[GitHub] [incubator-nuttx] Ouss4 commented on pull request #2322: arch/arm/src/stm32h7/stm32_otghost.c: Fix undeclared "ret".

2020-11-17 Thread GitBox
Ouss4 commented on pull request #2322: URL: https://github.com/apache/incubator-nuttx/pull/2322#issuecomment-728833855 > should we enable OTG in one of config to catch the similar error in the future? For this particular driver, there is a preprocessor warning saying that "it was ne

[GitHub] [incubator-nuttx-apps] rzr opened a new pull request #482: netutils/netcat: Add netcat tool

2020-11-17 Thread GitBox
rzr opened a new pull request #482: URL: https://github.com/apache/incubator-nuttx-apps/pull/482 Check readme for usage and demo: [![weboftwins-osvehicle-2020-rzr]( https://files.mastodon.social/media_attachments/files/105/163/916/892/863/178/original/05468e28b4463f95.png )](

[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
jerpelea opened a new pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324 ## Summary Add audio sample rate conversion library from http://www.mega-nerd.com/SRC/index.html Source: https://github.com/libsndfile/libsamplerate Add needed patches fo

[GitHub] [incubator-nuttx] davids5 merged pull request #2322: arch/arm/src/stm32h7/stm32_otghost.c: Fix undeclared "ret".

2020-11-17 Thread GitBox
davids5 merged pull request #2322: URL: https://github.com/apache/incubator-nuttx/pull/2322 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[incubator-nuttx] branch master updated: arch/arm/src/stm32h7/stm32_otghost.c: Fix undeclared "ret".

2020-11-17 Thread davids5
This is an automated email from the ASF dual-hosted git repository. davids5 pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git The following commit(s) were added to refs/heads/master by this push: new fa713c0 arch/arm/src/stm32h7/stm32_ot

[GitHub] [incubator-nuttx] davids5 closed issue #2314: chip/stm32_otghost.c doesn't build , have C errors

2020-11-17 Thread GitBox
davids5 closed issue #2314: URL: https://github.com/apache/incubator-nuttx/issues/2314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-nuttx] juniskane opened a new pull request #2325: arch/arm/src/stm32/stm32_serial.c: for flowcontrol use common idiom f…

2020-11-17 Thread GitBox
juniskane opened a new pull request #2325: URL: https://github.com/apache/incubator-nuttx/pull/2325 arch/arm/src/stm32/stm32_serial.c: for flowcontrol use common idiom for enabling/disabling RX interrupts ## Summary Code cleanup. Change makes it easier to diff serial driver betwee

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
jerpelea commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525093364 ## File path: drivers/audio/cxd56_src.c ## @@ -0,0 +1,596 @@ +/ + * d

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
Ouss4 commented on a change in pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525094998 ## File path: audio/Makefile ## @@ -49,6 +49,8 @@ ifeq ($(CONFIG_AUDIO_FORMAT_PCM),y) CSRCS += pcm_decode.c endif +include libsrc/Make.defs R

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
Ouss4 commented on a change in pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525094998 ## File path: audio/Makefile ## @@ -49,6 +49,8 @@ ifeq ($(CONFIG_AUDIO_FORMAT_PCM),y) CSRCS += pcm_decode.c endif +include libsrc/Make.defs R

[GitHub] [incubator-nuttx] Ouss4 commented on a change in pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
Ouss4 commented on a change in pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525095651 ## File path: audio/Makefile ## @@ -75,7 +77,7 @@ $(BIN): $(OBJS) depend: .depend -clean: +clean: .clean Review comment: I think it's b

[GitHub] [incubator-nuttx] davids5 commented on pull request #2325: arch/arm/src/stm32/stm32_serial.c: for flowcontrol use common idiom f…

2020-11-17 Thread GitBox
davids5 commented on pull request #2325: URL: https://github.com/apache/incubator-nuttx/pull/2325#issuecomment-728889446 @juniskane - I think there is a subtle changes. Ins't the The DMA disable path is now different? Did you test with DMA & flow control? ---

[GitHub] [incubator-nuttx] davids5 commented on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
davids5 commented on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728895155 Should these be 2 independent settings? I can have none, either one or both. This is an automated

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #482: netutils/netcat: Add netcat tool

2020-11-17 Thread GitBox
xiaoxiang781216 commented on a change in pull request #482: URL: https://github.com/apache/incubator-nuttx-apps/pull/482#discussion_r525122085 ## File path: netutils/netcat/Kconfig ## @@ -0,0 +1,52 @@ +###

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728905096 > Should these be 2 independent settings? > > I can have none, either one or both. No, we can't select both. Because only one function named __arch_s

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728905096 > Should these be 2 independent settings? > > I can have none, either one or both. No, we can't select both. Because only one function named _

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-728907009 @jerpelea libsamplerate could be used in userspace application too, so why not put into apps/ or libs/ folder? -

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
patacongo commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525138881 ## File path: drivers/audio/cxd56_src.c ## @@ -0,0 +1,606 @@ +/ + *

[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
jerpelea commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525151767 ## File path: drivers/audio/cxd56_src.c ## @@ -0,0 +1,606 @@ +/ + * d

[GitHub] [incubator-nuttx-apps] rzr commented on a change in pull request #482: netutils/netcat: Add netcat tool

2020-11-17 Thread GitBox
rzr commented on a change in pull request #482: URL: https://github.com/apache/incubator-nuttx-apps/pull/482#discussion_r525152733 ## File path: netutils/netcat/Kconfig ## @@ -0,0 +1,52 @@ +# +# +# net

[GitHub] [incubator-nuttx] jerpelea commented on pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
jerpelea commented on pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-728929148 @xiaoxiang781216 I can move it to libs if needed This is an automated message from the Apache Git Serv

[GitHub] [incubator-nuttx] davids5 commented on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
davids5 commented on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728933312 Can this be cascaded with priority of chip -> arch -> system: ``` /* The actual logger function may be overridden in arch/debug.h if needed. * (Currently only if

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728942587 > Can this be cascaded with priority of chip -> arch -> system: Yes, you can achieve this by select one of: 1. CONFIG_ARCH_CHIP_DEBUG_H->chip 2. C

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728942587 > Can this be cascaded with priority of chip -> arch -> system: Yes, you can achieve this by select one of: 1. CONFIG_ARCH_CHIP_DEBUG_H->chip

[GitHub] [incubator-nuttx] juniskane commented on pull request #2325: arch/arm/src/stm32/stm32_serial.c: for flowcontrol use common idiom f…

2020-11-17 Thread GitBox
juniskane commented on pull request #2325: URL: https://github.com/apache/incubator-nuttx/pull/2325#issuecomment-728950144 @davids5 : unfortunately not really tested DMA + flow control with upstream NuttX because for that STM32L1 needs the functionality reverted by df9ae3c13f. It would be

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
davids5 commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525181300 ## File path: include/nuttx/mm/circ_buf.h ## @@ -0,0 +1,308 @@ +/ + *

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #483: Fix test failed when some apis are NULL

2020-11-17 Thread GitBox
Donny9 opened a new pull request #483: URL: https://github.com/apache/incubator-nuttx-apps/pull/483 ## Summary Fix test failed when some apis are NULL. ## Impact Fix bug for some special driver. ## Testing daily test --

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
Donny9 commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525195649 ## File path: include/nuttx/mm/circ_buf.h ## @@ -0,0 +1,308 @@ +/ + * i

[GitHub] [incubator-nuttx] v01d commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
v01d commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525161235 ## File path: mm/circ_buf/circ_buf.c ## @@ -0,0 +1,496 @@ +/ + * mm/circ_

[GitHub] [incubator-nuttx-apps] Donny9 opened a new pull request #484: Fix compile break

2020-11-17 Thread GitBox
Donny9 opened a new pull request #484: URL: https://github.com/apache/incubator-nuttx-apps/pull/484 ## Summary Fix compile break when disable CONFIG_READLINE_ECHO ## Impact Fix compile break ## Testing daily test --

[GitHub] [incubator-nuttx-apps] jerpelea commented on pull request #484: Fix compile break

2020-11-17 Thread GitBox
jerpelea commented on pull request #484: URL: https://github.com/apache/incubator-nuttx-apps/pull/484#issuecomment-728975086 @Donny9 /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/system/readline/readline.h:92:3: error: Small odd alignment /home/runner/work/incub

[GitHub] [incubator-nuttx] v01d commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
v01d commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729016848 I went over this again. I'm now (hopefully) addressing both issues correctly. These were actually unrelated: the missing release on receive queue was simply a mistake. As f

[GitHub] [incubator-nuttx] v01d commented on issue #1639: Bluetooth: Implement the BTPROTO_HCI Protocol for AF_BLUETOOTH socket domain.

2020-11-17 Thread GitBox
v01d commented on issue #1639: URL: https://github.com/apache/incubator-nuttx/issues/1639#issuecomment-729025031 I think that we can close this right? Or if you prefer to keep it to remind about the MGMT and monitor channel, the title could be changed. ---

[GitHub] [incubator-nuttx] btashton commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
btashton commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525280954 ## File path: drivers/audio/cxd56_src.c ## @@ -0,0 +1,606 @@ +/ + * d

[GitHub] [incubator-nuttx] btashton commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
btashton commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729047833 I still think it's a little odd that we are having to add this special case here. Seems like this is a problem for anything sending via the raw channel? --

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2324: audio: libsamplerate: add initial audio Sample Rate Converter

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #2324: URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-729064802 or libc/audio? This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [incubator-nuttx] v01d commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
v01d commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729066228 Well, the allocated buffer needs to be freed eventually, don't see why that it is odd. The only reason why this isn't done there for both cases is NuttX's stack need to kee

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #482: netutils/netcat: Add netcat tool

2020-11-17 Thread GitBox
xiaoxiang781216 merged pull request #482: URL: https://github.com/apache/incubator-nuttx-apps/pull/482 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[incubator-nuttx-apps] branch master updated: netutils/netcat: Add netcat tool

2020-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git The following commit(s) were added to refs/heads/master by this push: new 4a5152f netutils/netcat: Add n

[GitHub] [incubator-nuttx] btashton commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
btashton commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729074040 But I should be able to run nimBLE on top of the socket regardless just as we do with Linux. There is something ugly happening here if we need to change the free logic.

[GitHub] [incubator-nuttx] v01d commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
v01d commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729078791 I don't understand what you mean as nimBLE runs on top of the socket. I think the actual issue is that NuttX's own stack is not very well integrated to NuttX: there's

[GitHub] [incubator-nuttx] v01d commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model

2020-11-17 Thread GitBox
v01d commented on pull request #2318: URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729102603 Can you remove the check for HPWORK define in code to Kconfig, only for when BUFFER > 0? This is an automa

[GitHub] [incubator-nuttx] v01d edited a comment on pull request #2318: Update l3gd20 sensor driver with new sensor driver model

2020-11-17 Thread GitBox
v01d edited a comment on pull request #2318: URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729102603 Can you move the check for HPWORK define in code to Kconfig, only for when BUFFER > 0? This is an a

[GitHub] [incubator-nuttx] v01d commented on pull request #2318: Update l3gd20 sensor driver with new sensor driver model

2020-11-17 Thread GitBox
v01d commented on pull request #2318: URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729103233 Also, why the need to introduce a config variable for the gyro which is actually on-board? I would presume this should always be zero (many boards do this). -

[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #2326: libc: Enhance getopt function

2020-11-17 Thread GitBox
xiaoxiang781216 opened a new pull request #2326: URL: https://github.com/apache/incubator-nuttx/pull/2326 ## Summary 1.Support arguments before options(e.g. ls /dev -l) 2.Support the long options by getopt_long 3.Support the reentrant version(e.g. getopt_r) 4.Move the related dec

[GitHub] [incubator-nuttx] acassis commented on pull request #2321: drivers/leds/apa102: remove/fix references to I2C/LM-75 (comments only)

2020-11-17 Thread GitBox
acassis commented on pull request #2321: URL: https://github.com/apache/incubator-nuttx/pull/2321#issuecomment-729110408 Hi @diegoherranz please just fix the Coding Styles issues that was already in the apa102 and push the commit. Thanks for fixing the incorrect reference. ---

[GitHub] [incubator-nuttx-apps] rzr opened a new pull request #485: fxos8700cq_test: Adjust rate and lint json output

2020-11-17 Thread GitBox
rzr opened a new pull request #485: URL: https://github.com/apache/incubator-nuttx-apps/pull/485 Change-Id: Iab80381e4f451ac186515cd5593434d80e4c7421 Relate-to: https://github.com/rzr/aframe-smart-home/issues/3 Signed-off-by: Philippe Coval ## Summary ## Impact ##

[GitHub] [incubator-nuttx] btashton commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
btashton commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729127051 I agree that the existing stack needs to be adjusted a bit but you will still have packets that are not at L2CAP level. I suspect we just need to be increasing t

[GitHub] [incubator-nuttx] v01d commented on pull request #2302: bluetooth: fix outgoing buffer freeing

2020-11-17 Thread GitBox
v01d commented on pull request #2302: URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729131978 Ok, thanks. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [incubator-nuttx] acassis commented on a change in pull request #2269: xtensa/esp32: Add high memory support to work with PSRAM

2020-11-17 Thread GitBox
acassis commented on a change in pull request #2269: URL: https://github.com/apache/incubator-nuttx/pull/2269#discussion_r525408871 ## File path: boards/xtensa/esp32/esp32-core/src/esp32_bringup.c ## @@ -143,7 +143,7 @@ int esp32_bringup(void) #endif -#if defined(CONFIG_ES

[GitHub] [incubator-nuttx] patacongo opened a new issue #2327: Incomplete TCP Urgent OOB Data Support

2020-11-17 Thread GitBox
patacongo opened a new issue #2327: URL: https://github.com/apache/incubator-nuttx/issues/2327 net/tcp/tcp_input.c contains data to detect the presence of urgent OOB data in a packet. It will also save the a pointer to the urgent data and the size of the urgent data. However, there

[GitHub] [incubator-nuttx] patacongo opened a new issue #2328: Limitations in IPv4 Packet Re-assembly

2020-11-17 Thread GitBox
patacongo opened a new issue #2328: URL: https://github.com/apache/incubator-nuttx/issues/2328 IPv4 packet re-assembly is implemented in net/devif/ipv4_input.c. The current implementation, however, has too many limitations to be useful: 1. IPv4 reassembly is untested. 2. Currentl

[GitHub] [incubator-nuttx] diegoherranz opened a new pull request #2329: Documentation/components/drivers/character/pwm: fix pwm.c location

2020-11-17 Thread GitBox
diegoherranz opened a new pull request #2329: URL: https://github.com/apache/incubator-nuttx/pull/2329 - pwm.c was moved in 68bbc8438c6f1e8a448b14a32a1da70cf0e4609f but the documentation wasn't updated. - Also a minor typo fixed. Thanks! ---

[GitHub] [incubator-nuttx] Ouss4 merged pull request #2329: Documentation/components/drivers/character/pwm: fix pwm.c location

2020-11-17 Thread GitBox
Ouss4 merged pull request #2329: URL: https://github.com/apache/incubator-nuttx/pull/2329 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[incubator-nuttx] branch master updated (fa713c0 -> 3956787)

2020-11-17 Thread aguettouche
This is an automated email from the ASF dual-hosted git repository. aguettouche pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from fa713c0 arch/arm/src/stm32h7/stm32_otghost.c: Fix undeclared "ret". add 3956787 Documentation/co

[GitHub] [incubator-nuttx] Ouss4 opened a new pull request #2330: arch/xtensa/src/esp32/esp32_tim.c: Fix build when debug is enabled.

2020-11-17 Thread GitBox
Ouss4 opened a new pull request #2330: URL: https://github.com/apache/incubator-nuttx/pull/2330 ## Summary A non-existent variable was used in the debug message. ## Impact Fix build when timer's debug is enabled. ## Testing N/A ---

[GitHub] [incubator-nuttx] yamt commented on pull request #2222: Use a few integer types from the compiler

2020-11-17 Thread GitBox
yamt commented on pull request #: URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729251876 > > > All patches fix the type mismatch issue, why split it into multiple small one(e.g. sim has 4 patch). > > > > > > have you read the commit messages fo those

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525574262 ## File path: drivers/audio/cxd56_src.h ## @@ -0,0 +1,127 @@ +/ +

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525574756 ## File path: drivers/audio/cxd56_src.h ## @@ -0,0 +1,127 @@ +/ +

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525574262 ## File path: drivers/audio/cxd56_src.h ## @@ -0,0 +1,127 @@ +/ +

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525575910 ## File path: drivers/audio/cxd56_src.h ## @@ -0,0 +1,127 @@ +/ +

[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2282: cxd56: add initial audio SRC implementation

2020-11-17 Thread GitBox
masayuki2009 commented on a change in pull request #2282: URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525575910 ## File path: drivers/audio/cxd56_src.h ## @@ -0,0 +1,127 @@ +/ +

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2042: Fix interrupt stack handlings for ARM SMP

2020-11-17 Thread GitBox
masayuki2009 commented on pull request #2042: URL: https://github.com/apache/incubator-nuttx/pull/2042#issuecomment-729279857 @btashton Could you please backport this PR and PR #2061 to the 10.0 branch? This is an aut

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board

2020-11-17 Thread GitBox
masayuki2009 commented on pull request #2309: URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729280432 @btashton Could you backport this PR to the 10.0 branch? This is an automated message from

[GitHub] [incubator-nuttx] btashton commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board

2020-11-17 Thread GitBox
btashton commented on pull request #2309: URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729294997 > @btashton > Could you backport this PR to the 10.0 branch? > Sure I'll go through these tonight there are a few more as well. I already did this for the

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #2309: Fix armv7-a L2CC and apply the code to the sabre-6quad board

2020-11-17 Thread GitBox
masayuki2009 commented on pull request #2309: URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729299783 > > @btashton > > Could you backport this PR to the 10.0 branch? > > Sure I'll go through these tonight there are a few more as well. I already did this fo

[incubator-nuttx-website] branch asf-site updated: Publishing web: 5eb8540a7fe060c5e451b36dfb23656a6f18e3e7 docs: 39567872547438fd353a2ffd01f963578f3d8a90

2020-11-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new fd300cb Publishing web

[incubator-nuttx-website] branch asf-site updated: Publishing web: 5eb8540a7fe060c5e451b36dfb23656a6f18e3e7 docs: 39567872547438fd353a2ffd01f963578f3d8a90

2020-11-17 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch asf-site in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git The following commit(s) were added to refs/heads/asf-site by this push: new fd300cb Publishing web

[GitHub] [incubator-nuttx-apps] Donny9 commented on pull request #484: Fix compile break

2020-11-17 Thread GitBox
Donny9 commented on pull request #484: URL: https://github.com/apache/incubator-nuttx-apps/pull/484#issuecomment-729336965 > @Donny9 > /home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/system/readline/readline.h:92:3: error: Small odd alignment > /home/runner/work/in

[GitHub] [incubator-nuttx-apps] yamt opened a new pull request #486: canutils/candump/candump.c: Fix scanf format warnings

2020-11-17 Thread GitBox
yamt opened a new pull request #486: URL: https://github.com/apache/incubator-nuttx-apps/pull/486 ## Summary ## Impact ## Testing This is an automated message from the Apache Git Service. To respond to t

[GitHub] [incubator-nuttx-apps] yamt commented on pull request #486: canutils/candump/candump.c: Fix scanf format warnings

2020-11-17 Thread GitBox
yamt commented on pull request #486: URL: https://github.com/apache/incubator-nuttx-apps/pull/486#issuecomment-729338338 nxstyle errors are expected. this file doesn't follow nxstyle at all. This is an automated message from

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2330: arch/xtensa/src/esp32/esp32_tim.c: Fix build when debug is enabled.

2020-11-17 Thread GitBox
xiaoxiang781216 merged pull request #2330: URL: https://github.com/apache/incubator-nuttx/pull/2330 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2321: drivers/leds/apa102: remove/fix references to I2C/LM-75 (comments only)

2020-11-17 Thread GitBox
xiaoxiang781216 merged pull request #2321: URL: https://github.com/apache/incubator-nuttx/pull/2321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (3956787 -> 2d7e063)

2020-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 3956787 Documentation/components/drivers/character/pwm: fix pwm.c location add 2d7e063 arch/xtens

[incubator-nuttx] branch master updated (2d7e063 -> d4c0786)

2020-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from 2d7e063 arch/xtensa/src/esp32/esp32_tim.c: Fix build when debug is enabled. A non-existent variable was

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
Donny9 commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525683869 ## File path: include/nuttx/mm/circ_buf.h ## @@ -0,0 +1,308 @@ +/ + * i

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2316: RISCV minor fix

2020-11-17 Thread GitBox
xiaoxiang781216 merged pull request #2316: URL: https://github.com/apache/incubator-nuttx/pull/2316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2317: flashback to release all file descriptors in group to increase debugging time.

2020-11-17 Thread GitBox
xiaoxiang781216 merged pull request #2317: URL: https://github.com/apache/incubator-nuttx/pull/2317 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[incubator-nuttx] branch master updated (d4c0786 -> a396b19)

2020-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from d4c0786 drivers/leds/apa102: Fix code style add 9eae6ed rv32im: fix typo. add a396b19 rv32im

[incubator-nuttx] branch master updated (a396b19 -> c22ab31)

2020-11-17 Thread xiaoxiang
This is an automated email from the ASF dual-hosted git repository. xiaoxiang pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git. from a396b19 rv32im: set compressed instruction enabled as default. add c22ab31 fs: flashback to releas

[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
xiaoxiang781216 edited a comment on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728942587 > Can this be cascaded with priority of chip -> arch -> system: Yes, you can achieve this by select one of: 1. CONFIG_ARCH_CHIP_DEBUG_H->chip

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2320: Add debug.h selection choice to support include chip debug.h

2020-11-17 Thread GitBox
xiaoxiang781216 commented on pull request #2320: URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-729344232 @davids5 do you think my anwser resolve your concern? This is an automated message from the Apac

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
patacongo commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525720509 ## File path: include/nuttx/mm/circ_buf.h ## @@ -0,0 +1,308 @@ +/ +

[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
patacongo commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525720509 ## File path: include/nuttx/mm/circ_buf.h ## @@ -0,0 +1,308 @@ +/ +

[GitHub] [incubator-nuttx] Donny9 commented on a change in pull request #2315: Add common circular buffer management

2020-11-17 Thread GitBox
Donny9 commented on a change in pull request #2315: URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525723915 ## File path: mm/circ_buf/circ_buf.c ## @@ -0,0 +1,496 @@ +/ + * mm/cir

  1   2   >