Ouss4 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525094998
##########
File path: audio/Makefile
##########
@@ -49,6 +49,8 @@ ifeq ($(CONFIG_AUDIO_FORMAT_PCM),y)
CSRCS += pcm_decode.c
endif
+include libsrc/Make.defs
Review comment:
Isn't that the other way around?
i.e. libsrc/Make.defs should include audio/Makefile.
##########
File path: audio/Makefile
##########
@@ -75,7 +77,7 @@ $(BIN): $(OBJS)
depend: .depend
-clean:
+clean: .clean
Review comment:
I think it's better to extend the target with a double colon.
The top-level audio/Makefile can have the common target and other Make.defs
include audio/Makefile and extend `clean::` with their specific operations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
