yamt commented on pull request #2222: URL: https://github.com/apache/incubator-nuttx/pull/2222#issuecomment-729251876
> > > All patches fix the type mismatch issue, why split it into multiple small one(e.g. sim has 4 patch). > > > > > > have you read the commit messages fo those 4 patches? > > > BTW, is compiler_stdint.h required? > > > > > > i'm not sure if i understand the question. > > currently it's used. yes. > > Yes, it is used, but all configs can build fine by removing compiler_stdint.h. So I think it is redundant and should be removed. * the majority of configs relies on it providing _uintmax_t and _intmax_t. * it serves as an assertion to ensure the compiler types matches arch types.h. > > > there are ways to do this without the header. in that sense, no. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
