acassis commented on a change in pull request #2269: URL: https://github.com/apache/incubator-nuttx/pull/2269#discussion_r525408871
########## File path: boards/xtensa/esp32/esp32-core/src/esp32_bringup.c ########## @@ -143,7 +143,7 @@ int esp32_bringup(void) #endif -#if defined(CONFIG_ESP32_SPIRAM) +#if defined(CONFIG_ESP32_SPIRAM) && defined(CONFIG_SPIRAM_BANKSWITCH_ENABLE) Review comment: Thank you! I was going to replace CONFIG_SPIRAM_BANKSWITCH_ENABLE with CONFIG_ESP32_SPIRAM_BANKSWITCH_ENABLE but I regret on it and forgot to remove it from a place in the Kconfig. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org