Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on PR #16356: URL: https://github.com/apache/nuttx/pull/16356#issuecomment-2876665742 You are welcome too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on PR #16356: URL: https://github.com/apache/nuttx/pull/16356#issuecomment-2876581179 Thank you all for your comments! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 merged PR #16356: URL: https://github.com/apache/nuttx/pull/16356 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nu

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2085787448 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084812745 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084690257 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084690257 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084653304 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084653304 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084627419 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2084618610 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083969809 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083969809 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083969809 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083967437 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR struct

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083870748 ## drivers/misc/optee.c: ## @@ -1155,38 +1223,31 @@ int optee_shm_alloc(FAR struct optee_priv_data *priv, FAR void *addr, * ***

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083955863 ## drivers/misc/optee.c: ## @@ -529,10 +534,21 @@ static int optee_close(FAR struct file *filep) { FAR struct optee_priv_data *priv = filep->f_priv; FAR

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on PR #16356: URL: https://github.com/apache/nuttx/pull/16356#issuecomment-2871033430 Had to remove `CONFIG_EXAMPLES_OPTEE` as it introduces a circular dependency with https://github.com/apache/nuttx-apps/pull/3074. I'll enable examples to `imx93-evk:koptee` in a ne

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083810701 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083810701 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083737378 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083736499 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083736238 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083587575 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083587575 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083581080 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083574539 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083567372 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083567372 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083543407 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083542832 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0)

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083542478 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083541883 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083540768 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083540768 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083534871 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083534871 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083466728 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083531007 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L2_",

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083531007 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L2_",

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083525313 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083525313 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083525313 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083510622 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083509981 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083509798 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083487421 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083487421 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083467486 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0) { +

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083487421 ## drivers/misc/optee.c: ## @@ -555,23 +555,22 @@ static int optee_close(FAR struct file *filep) return 0; } +#ifdef CONFIG_OPTEE_OPENVELA_COMPAT Review Comment

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083486427 ## tools/nxstyle.c: ## @@ -212,6 +212,7 @@ static const char *g_white_prefix[] = "luaL_", /* Ref: apps/interpreters/lua/lua-5.x.x/src/lauxlib.h */ "V4L2_",

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083464712 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee_shm_en

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083481142 ## drivers/misc/optee.c: ## @@ -568,20 +628,7 @@ static int optee_to_msg_param(FAR struct optee_msg_param *mparams, case TEE_IOCTL_PARAM_ATTR_TYPE_MEMREF_I

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083480191 ## drivers/misc/optee.c: ## @@ -533,7 +538,16 @@ static int optee_close(FAR struct file *filep) idr_for_each_entry(priv->shms, shm, id) { - optee_shm_fr

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083467486 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0) { +

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083466728 ## drivers/misc/optee.c: ## @@ -925,20 +987,27 @@ optee_ioctl_shm_register(FAR struct optee_priv_data *priv, return -EFAULT; } - if (rdata->flags & TEE_

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083464712 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee_shm_en

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083464712 ## drivers/misc/optee.h: ## @@ -46,17 +45,19 @@ * Public Types / -struct optee_shm_en

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on code in PR #16356: URL: https://github.com/apache/nuttx/pull/16356#discussion_r2083392213 ## drivers/misc/optee.c: ## @@ -890,21 +941,32 @@ optee_ioctl_shm_alloc(FAR struct tee_ioctl_shm_alloc_data *data) if (ftruncate(memfd, data->size) < 0)

Re: [PR] Fix OP-TEE driver compatibility issues [nuttx]

xiaoxiang781216 commented on PR #16356: URL: https://github.com/apache/nuttx/pull/16356#issuecomment-2869396800 > 2. Fixes compatibility with [upstream OP-TEE OS](https://github.com/OP-TEE/optee_os/) when using temporary memory > >* Previous implementation of tempor

[PR] Fix OP-TEE driver compatibility issues [nuttx]

gpoulios opened a new pull request, #16356: URL: https://github.com/apache/nuttx/pull/16356 ## Summary This PR addresses 2 major issues with the existing implementation of the OP-TEE driver in NuttX: 1. Fixes compatibility with the GlobalPlatform client API ([optee_client](https: