TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2739913190
> > I am going to add a Kconfig option for whether to intercept/redirect
STDIN - it's necessary for NSH but probably is not if the FB is just used for
output from the majority of otgher
lupyuen commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006659386
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX t
cederom commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006673946
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX t
TimJTi commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2003706541
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,201 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX to
lupyuen commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742931847
> 2\. Is it possible it was merged before the checks on the last push had
finished CI? Is this visible to me or, if not, can someone check just be sure?
CI Checks didn't catch th
hartmannathan commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006527306
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the N
TimJTi commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006562579
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX to
acassis merged PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.a
cederom commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2745395040
All good now :-) @hartmannathan found the issue and @lupyuen quickly fixed
it, things like this happen sometimes, we just need to keep draft status until
absolutely sure it can be mer
simbit18 commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2007321202
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742932303
@cederom
> Hmm was this PR marked DRAFT and merged? We need to be more careful as it
broke master build for all other boards/config even those not using fbcon.
DRAFT means NO MERGE!
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742941017
> > 2. Is it possible it was merged before the checks on the last push had
finished CI? Is this visible to me or, if not, can someone check just be sure?
>
> CI Checks didn't catc
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742908952
> @cederom I think it was marked Ready For Review yesterday?
>
> * [Add fbcon example #3029
(comment)](https://github.com/apache/nuttx-apps/pull/3029#event-16882080694)
@ce
lupyuen commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006659386
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX t
cederom commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2741984037
Hmm was this PR marked DRAFT and merged? We need to be more careful as it
broke build for all other boards/config not using fbcon. DRAFT means NO MERGE!
:-)
Things to update (in
lupyuen commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2741994899
@cederom I think it was marked Ready For Review yesterday?
- https://github.com/apache/nuttx-apps/pull/3029#event-16882080694
--
This is an automated message from the Apache Git Se
cederom commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742001058
Cool cool at least we have more focus now :D :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lupyuen commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006672226
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX t
hartmannathan commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2006577020
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,205 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the N
acassis commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2740435332
> > > I am going to add a Kconfig option for whether to intercept/redirect
STDIN - it's necessary for NSH but probably is not if the FB is just used for
output from the majority of otg
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2737744345
@cederom @acassis
> Some documentation would be nice to have too on how to setup hardware so
we could test on other targets :-)
I have added a bit more meat to Kconfig - shall
simbit18 commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2003697222
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,201 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX
simbit18 commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2003697855
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,201 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX
TimJTi commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2003499952
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,184 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX to
acassis commented on code in PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#discussion_r2001846839
##
examples/fbcon/Kconfig:
##
@@ -0,0 +1,184 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX t
acassis commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2736795327
> I am going to add a Kconfig option for whether to intercept/redirect STDIN
- it's necessary for NSH but probably is not if the FB is just used for output
from the majority of otgher
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2736152787
I am going to add a Kconfig option for whether to intercept/redirect STDIN -
it's necessary for NSH but probably is not if the FB is just used for output
from the majority of otgher app
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2736144059
@cederom
> Thanks @TimJTi amazing work!! :-)
Thank you :-D
>
> Please remember to update git commit:
>
> * examples/fbcon: Add video framebuffer console (or something
cederom commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2735107180
Thanks @TimJTi amazing work!! :-)
Please remember to update git commit:
* examples/fbcon: Add video framebuffer console (or something like that).
* some description.
* g
TimJTi commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2734372129
Just spotted there's a left over folder and CMakeLists.txt from when I
called it something else. Will remove that with any future commits here, and
before I make it ready for review aft
nuttxpr commented on PR #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2734296172
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
__Fill In The Commit Message:__ This PR contains a Commit wi
TimJTi opened a new pull request, #3029:
URL: https://github.com/apache/nuttx-apps/pull/3029
## Summary
This adds a new "Example App" that allows a framebuffer character device to
be used for STDOUT and/or STDIN text rendering.
## Impact
It is a standalone app so has no impact o
32 matches
Mail list logo
