cederom commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2741984037
Hmm was this PR marked DRAFT and merged? We need to be more careful as it broke build for all other boards/config not using fbcon. DRAFT means NO MERGE! :-) Things to update (in next PR): 1. Kconfig dependencies are missing (i.e. NX Graphics, fonts, bit depths, fifo pipes). In best case selecting this functionality should also enable required underlying functionalities :-) 2. Documentation on how to setup and use this functionality :-) 3. Possible conflicts outline - if I use LVGL demo config would it be possible to use fbcon example too? ``` % gmake -j8 CROSSDEV=riscv32-esp-elf- Create version.h LN: platform/board to /XXX/nuttx-apps.git/platform/dummy Register: lvgldemo Register: fbcon Register: nsh Register: sh ./fbcon_main.c:51:4: error: #error This application requires NX Graphics # error This application requires NX Graphics ^~~~~ ./fbcon_main.c:57:4: error: #error FIFO and Named Pipe Drivers should be enabled in the configuration # error FIFO and Named Pipe Drivers should be enabled in the configuration ^~~~~ ./fbcon_main.c:176:6: error: #error NXFONT_DEFAULT not defined # error NXFONT_DEFAULT not defined ^~~~~ CC: dirent/lib_versionsort.c fbcon_main.c:51:4: error: #error This application requires NX Graphics # error This application requires NX Graphics ^~~~~ fbcon_main.c:57:4: error: #error FIFO and Named Pipe Drivers should be enabled in the configuration # error FIFO and Named Pipe Drivers should be enabled in the configuration ^~~~~ fbcon_main.c:176:6: error: #error NXFONT_DEFAULT not defined # error NXFONT_DEFAULT not defined ^~~~~ CC: sched/sched_rrgetinterval.c fbcon_main.c: In function 'fbcon_renderglyph': fbcon_main.c:1062:22: warning: passing argument 1 of 'nxf_convert_1bpp' from incompatible pointer type [-Wincompatible-pointer-types] ret = RENDERER((FAR nxgl_mxpixel_t *)glyph->bitmap, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from fbcon_main.c:41: /XXX/nuttx.git/include/nuttx/nx/nxfonts.h:553:35: note: expected 'uint8_t *' {aka 'unsigned char *'} but argument is of type 'nxgl_mxpixel_t *' {aka 'long unsigned int *'} int nxf_convert_1bpp(FAR uint8_t *dest, uint16_t height, ~~~~~~~~~^~~~ fbcon_main.c: In function 'fbcon_initialize': fbcon_main.c:178:24: error: 'NXFONT_DEFAULT' undeclared (first use in this function); did you mean 'FONTID_DEFAULT'? # define FBCON_FONTID NXFONT_DEFAULT ^~~~~~~~~~~~~~ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org