TimJTi commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742932303
@cederom > Hmm was this PR marked DRAFT and merged? We need to be more careful as it broke master build for all other boards/config even those not using fbcon. DRAFT means NO MERGE! :-) See comment below! > > Things to update (in next PR): > > 1. Kconfig dependencies are missing (i.e. NX Graphics, fonts, bit depths, fifo pipes). In best case selecting this functionality should also enable required underlying functionalities :-) I recalled - but didn't go back and check tbh - a discussion saying that `depends on` was preferable to `select`? Originally I did `select` (e.g.) NX but changed it to `depends on` with #define error Sorry if I got it wrong...and reinforces my other reply that this was merged too soon IMHO. > 2. Documentation on how to setup and use this functionality :-) This was mentioned before and I asked where, and for pointers to similar for reference, and followed up with a suggested as to where? Still happy to do this :-) > 3. Possible conflicts outline - if I use LVGL demo config would it be possible to use fbcon example too? > I see this as a standalone example...but it can be built on of course. For example, I've just found that (perhaps of course, which is my inexperience showing) syslog messages got to /dev/console and that doesn't make its way through to FBCON. It's almost like FBCON should be an actual driver (/dev/fbcon) not an app? That's why I opened a discussion on the mail list, and left it as a draft for a while to seek feedback ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
