TimJTi commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2742941017
> > 2. Is it possible it was merged before the checks on the last push had finished CI? Is this visible to me or, if not, can someone check just be sure? > > CI Checks didn't catch the Kconfig Errors because it uses kconfiglib, but most of us use kconfig-frontends. So we wouldn't have known about the Kconfig Errors, even if we waited for the CI Checks to complete. > > Here's a trick I use on my Bigger PRs: I set my PR to Draft Mode while CI Check is still running. It gives me more time to fix things if the CI Check fails :-) It was marked as a draft for many days with several pushes and successful CI runs...which is why I wonder if, after marked as ready for review and/or a last push from me, the last CI run wasn't allowed to, or didn't, run? I always check CI results and fix broken things, and I do use kconfiglib...and it didn't report any issues but perhaps I forgot some method or setting to ensure it reported errors. Blame old age making me forgetful lol. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
