nuttxpr commented on PR #3029: URL: https://github.com/apache/nuttx-apps/pull/3029#issuecomment-2734296172
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) __Fill In The Commit Message:__ This PR contains a Commit with an Empty Commit Message. Please fill in the Commit Message with the PR Summary. Yes, this PR appears to mostly meet the requirements, but is missing some key information. Here's what needs improvement: * **Summary:** While the "what" is explained, the "why" is missing. *Why* is this new example app necessary? What use case does it address? Is there a demand for this functionality? * **Impact:** While it *probably* doesn't impact other components, explicitly stating "NO" for each impact category is preferred for clarity. For example: `Impact on user (will user need to adapt to change)? NO`. This avoids ambiguity. * **Testing:** The testing section is severely lacking. * **Build Host(s):** Specify the OS, CPU architecture, and compiler version used for building. (e.g., Linux x86_64, GCC 12.2.1) * **Target(s):** Be more specific. Instead of just "custom board", provide the NuttX architecture (e.g., armv7-m) and the specific board configuration name used (e.g., `sama5d27c_d1g_som1ek1`). * **Logs:** "Testing logs" are crucial. Provide actual output demonstrating the application's functionality both before and after the change (though "before" might be N/A if it's a new app). Show that the app works. Example: output of `hello world` or similar on the framebuffer. If stdin is involved, show how that works too. By providing this missing information, the PR will be much more complete and easier to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
