xiaoxiang781216 commented on code in PR #2113:
URL: https://github.com/apache/nuttx-apps/pull/2113#discussion_r1359201466
##
examples/sensor_fusion/sensor_fusion_main.c:
##
@@ -0,0 +1,162 @@
+/
+ * apps/
xiaoxiang781216 closed pull request #2109: interpreters/wamr: Don't select
ARCH_USE_TEXT_HEAP automatically
URL: https://github.com/apache/nuttx-apps/pull/2109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
xiaoxiang781216 commented on PR #10871:
URL: https://github.com/apache/nuttx/pull/10871#issuecomment-1762662013
@yamt the patch you concern is removed from pr, please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
davids5 commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1359142047
##
sched/irq/irq_spinlock.c:
##
@@ -209,4 +220,202 @@ void spin_unlock_irqrestore_wo_note(spinlock_t *lock,
irqstate_t flags)
up_irq_restore(flags);
}
+#ifdef CO
This is an automated email from the ASF dual-hosted git repository.
davids5 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new 1989749850 cpu_pause.c: fix typo
1989749850 is d
davids5 merged PR #10908:
URL: https://github.com/apache/nuttx/pull/10908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
crafcat7 opened a new pull request, #10909:
URL: https://github.com/apache/nuttx/pull/10909
## Summary
In previous versions, during the teardown phase, the "open_blockdriver"
would call the "mtd proxy" causing the "file mtd" node to be registered in the
ftl. " node is registered in ftl.
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1358860001
##
sched/semaphore/spinlock.c:
##
@@ -446,4 +446,225 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned
int cpu,
}
#endif
+#ifdef CONFIG_RW_SPINLOCK
+
+/***
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new 0506177d Publishing web: 07abea83
TaiJuWu opened a new pull request, #10908:
URL: https://github.com/apache/nuttx/pull/10908
## Summary
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1358866963
##
sched/semaphore/spinlock.c:
##
@@ -446,4 +446,225 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned
int cpu,
}
#endif
+#ifdef CONFIG_RW_SPINLOCK
+
+/***
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1358866963
##
sched/semaphore/spinlock.c:
##
@@ -446,4 +446,225 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned
int cpu,
}
#endif
+#ifdef CONFIG_RW_SPINLOCK
+
+/***
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1358866963
##
sched/semaphore/spinlock.c:
##
@@ -446,4 +446,225 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned
int cpu,
}
#endif
+#ifdef CONFIG_RW_SPINLOCK
+
+/***
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729
##
include/nuttx/spinlock.h:
##
@@ -32,6 +32,14 @@
#include
+#ifdef CONFIG_RW_SPINLOCK
+#include
+typedef atomic_int rwlock_t;
Review Comment:
It can't.
T
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1358860001
##
sched/semaphore/spinlock.c:
##
@@ -446,4 +446,225 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned
int cpu,
}
#endif
+#ifdef CONFIG_RW_SPINLOCK
+
+/***
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1358860001
##
sched/semaphore/spinlock.c:
##
@@ -446,4 +446,225 @@ void spin_clrbit(FAR volatile cpu_set_t *set, unsigned
int cpu,
}
#endif
+#ifdef CONFIG_RW_SPINLOCK
+
+/***
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729
##
include/nuttx/spinlock.h:
##
@@ -32,6 +32,14 @@
#include
+#ifdef CONFIG_RW_SPINLOCK
+#include
+typedef atomic_int rwlock_t;
Review Comment:
It can't.
T
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729
##
include/nuttx/spinlock.h:
##
@@ -32,6 +32,14 @@
#include
+#ifdef CONFIG_RW_SPINLOCK
+#include
+typedef atomic_int rwlock_t;
Review Comment:
It can't.
T
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729
##
include/nuttx/spinlock.h:
##
@@ -32,6 +32,14 @@
#include
+#ifdef CONFIG_RW_SPINLOCK
+#include
+typedef atomic_int rwlock_t;
Review Comment:
It can't.
T
TaiJuWu commented on code in PR #10776:
URL: https://github.com/apache/nuttx/pull/10776#discussion_r1354283729
##
include/nuttx/spinlock.h:
##
@@ -32,6 +32,14 @@
#include
+#ifdef CONFIG_RW_SPINLOCK
+#include
+typedef atomic_int rwlock_t;
Review Comment:
It can't.
T
acassis commented on code in PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#discussion_r1358694533
##
drivers/motor/Kconfig:
##
@@ -62,3 +62,23 @@ endif
source "drivers/motor/foc/Kconfig"
endif # MOTOR
+
+menuconfig STEPPER
+ bool "Stepper control drivers"
This is an automated email from the ASF dual-hosted git repository.
acassis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new f196d108bf drivers/note: Change 0/1 to false/tru
acassis merged PR #10907:
URL: https://github.com/apache/nuttx/pull/10907
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apac
xiaoxiang781216 commented on code in PR #101:
URL: https://github.com/apache/nuttx-website/pull/101#discussion_r1358410515
##
_data/contributors.yml:
##
@@ -191,4 +191,10 @@
role: Committer
org:
+- name: Guiding Li
Review Comment:
keep the order
--
This is an aut
GUIDINGLI opened a new pull request, #101:
URL: https://github.com/apache/nuttx-website/pull/101
## Summary
Add ligd to contributors
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
xiaoxiang781216 commented on code in PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#discussion_r1358394606
##
arch/sim/src/sim/posix/sim_hostmisc.c:
##
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WIN
xiaoxiang781216 opened a new pull request, #10907:
URL: https://github.com/apache/nuttx/pull/10907
## Summary
## Impact
code refactor only
## Testing
ci
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitH
xiaoxiang781216 commented on PR #10871:
URL: https://github.com/apache/nuttx/pull/10871#issuecomment-1761668914
> what's your motivation?
>
> > arch: Change ARCH_USE_TEXT_HEAP default to y instead selection
>
> as you see in the CI results,
ci failure isn't related to thi
xiaoxiang781216 commented on code in PR #10871:
URL: https://github.com/apache/nuttx/pull/10871#discussion_r1358378418
##
arch/sim/src/sim/posix/sim_hostmemory.c:
##
@@ -60,18 +60,18 @@ static atomic_int g_uordblks;
*
*
Donny9 commented on code in PR #10871:
URL: https://github.com/apache/nuttx/pull/10871#discussion_r1358367945
##
arch/sim/src/sim/posix/sim_hostmemory.c:
##
@@ -60,18 +60,18 @@ static atomic_int g_uordblks;
*
**
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx.git
The following commit(s) were added to refs/heads/master by this push:
new abfeafa876 arm64: XN should only be set when t
xiaoxiang781216 merged PR #10904:
URL: https://github.com/apache/nuttx/pull/10904
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nu
acassis commented on code in PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#discussion_r1358359671
##
arch/sim/src/sim/posix/sim_hostmisc.c:
##
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WINDOWS_CYG
xiaoxiang781216 commented on code in PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#discussion_r1358347477
##
arch/sim/src/sim/posix/sim_hostmisc.c:
##
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WIN
raiden00pl commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761597760
> This way the drive will become more generic over the time and eventually
it will be easier to integrate both. I know the immediate thought is the driver
could become more complex ove
acassis commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761549814
> > @leducp really cool idea!
> > Please include later an apps/example/stepper and some basic documentation
>
> Do you have any advice to show how to integrate it in a board? For
acassis commented on issue #10906:
URL: https://github.com/apache/nuttx/issues/10906#issuecomment-1761585472
I think this is a good suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
acassis commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761579597
@leducp @raiden00pl I think there are pros and cons of both options:
1) A generic driver is good to have a standard interface that could share at
least some basic features;
2) A
leducp commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761553966
> > > @leducp really cool idea!
> > > Please include later an apps/example/stepper and some basic
documentation
> >
> >
> > Do you have any advice to show how to integrate it
fdcavalcanti opened a new issue, #10906:
URL: https://github.com/apache/nuttx/issues/10906
Hi everyone!
I would like to propose a new README page on Github. The current one is a
big wall of text which is already covered in the documentation.
I think we can do something smaller and
chirping78 commented on PR #10496:
URL: https://github.com/apache/nuttx/pull/10496#issuecomment-1761498868
@masayuki2009
Since when the issue is reproduced, the system will hang and can't use
`trace dump` command, so I made a homemade trace buffer to save `up_irq_save` /
`up_irq_restore
simbit18 opened a new pull request, #10905:
URL: https://github.com/apache/nuttx/pull/10905
## Summary
Simulator build fails on non-GLIBC platform #5621 #5623.
On platforms where the execinfo.h file is missing, the Gnulib substitute
implementation is just a stub, and does nothing.
h
anchao opened a new pull request, #2117:
URL: https://github.com/apache/nuttx-apps/pull/2117
## Summary
system/readline: correct the readline(3) prototype
Reference:
https://man.openbsd.org/readline.3
## Impact
N/A
## Testing
ci-check
--
Thi
zyfeier opened a new pull request, #10904:
URL: https://github.com/apache/nuttx/pull/10904
## Summary
Only when SCTLR_ELn.WXN is set to 1, regions that are writable at ELn are
treated as non-executable. Therefore, when SCTLR_ELn.WXN is set to 0, regions
that are writable at ELn can b
leducp commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761196576
> > I understand the idea but I feel that it became a kind of god object
anti pattern...
> > The whole motor interface works with a different mindset like start and
stop. Moreover, what
raiden00pl commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761171634
> I understand the idea but I feel that it became a kind of god object anti
pattern...
The whole motor interface works with a different mindset like start and
stop. Moreover, what i
leducp commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761046651
> The idea behind `motor.h` was to create a universal interface for various
types of motors so I think it's better to modify it to fit better for stepper
motors. You can just add another c
raiden00pl commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761023331
The idea behind `motor.h` was to create a universal interface for various
types of motors so I think it's better to modify it to fit better for stepper
motors. You can just add another
leducp commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761019923
> @leducp really cool idea!
>
> Please include later an apps/example/stepper and some basic documentation
Do you have any advice to show how to integrate it in a board? For now
leducp commented on PR #10902:
URL: https://github.com/apache/nuttx/pull/10902#issuecomment-1761014260
> please add a commit message
Note sure what you means: my commits have messages. Do you want a particular
message? I Could add it when I'll squash to go out of the draft state.
--
50 matches
Mail list logo
