xiaoxiang781216 commented on code in PR #10905:
URL: https://github.com/apache/nuttx/pull/10905#discussion_r1358394606
##########
arch/sim/src/sim/posix/sim_hostmisc.c:
##########
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WINDOWS_CYGWIN
- return 0;
-#else
+#ifdef CONFIG_SIM_GLIBC_PLATFORM
Review Comment:
__has_include is part of c++17 spec, should become c spec soon, but it's
always good to check defined(__has_include) first.
##########
arch/sim/src/sim/posix/sim_hostmisc.c:
##########
@@ -90,10 +90,10 @@ void host_abort(int status)
int host_backtrace(void** array, int size)
{
-#ifdef CONFIG_WINDOWS_CYGWIN
- return 0;
-#else
+#ifdef CONFIG_SIM_GLIBC_PLATFORM
Review Comment:
__has_include is part of c++17 spec, should become c spec soon, but it's
always good to check `defined(__has_include)` first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
