masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525876704
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,601 @@
+/
+
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525877072
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,601 @@
+/
+
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525876704
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,601 @@
+/
+
yamt opened a new pull request #2331:
URL: https://github.com/apache/incubator-nuttx/pull/2331
## Summary
extracted from https://github.com/apache/incubator-nuttx/pull/2319
## Impact
## Testing
This i
xiaoxiang781216 opened a new pull request #487:
URL: https://github.com/apache/incubator-nuttx-apps/pull/487
## Summary
Because the configured signo may have the default action(e.g. SIGPIPE),
and then will generate the bad side effect before the caller wakeup.
## Impact
#
yamt commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729398667
> > > Yes, it is used, but all configs can build fine by removing
compiler_stdint.h. So I think it is redundant and should be removed.
> >
> >
> >
> > * the m
patacongo commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525781574
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+
xiaoxiang781216 merged pull request #484:
URL: https://github.com/apache/incubator-nuttx-apps/pull/484
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 6189a8d app/system/readline: f
xiaoxiang781216 merged pull request #486:
URL: https://github.com/apache/incubator-nuttx-apps/pull/486
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 086d8db canutils/candump/candu
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git.
from 4a5152f netutils/netcat: Add netcat tool
add 4e4c92f fxos8700cq_test: Adjust rate and lint js
xiaoxiang781216 merged pull request #485:
URL: https://github.com/apache/incubator-nuttx-apps/pull/485
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
xiaoxiang781216 commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729392591
> > Yes, it is used, but all configs can build fine by removing
compiler_stdint.h. So I think it is redundant and should be removed.
>
> * the majority of
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525752816
##
File path: drivers/sensors/sensor.c
##
@@ -867,6 +720,6 @@ void sensor_unregister(FAR struct sensor_lowerhalf_s
*lower, int devno)
nxsem_des
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525750183
##
File path: drivers/sensors/sensor.c
##
@@ -801,9 +654,9 @@ int sensor_register(FAR struct sensor_lowerhalf_s *lower,
int devno)
/* Initial
xiaoxiang781216 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525748835
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/*
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525733189
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+ * i
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525733484
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/circ_
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525726944
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525726668
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525725585
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525725361
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525723915
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/cir
patacongo commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525720509
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+
patacongo commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525720509
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+
xiaoxiang781216 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-729344232
@davids5 do you think my anwser resolve your concern?
This is an automated message from the Apac
xiaoxiang781216 edited a comment on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728942587
> Can this be cascaded with priority of chip -> arch -> system:
Yes, you can achieve this by select one of:
1. CONFIG_ARCH_CHIP_DEBUG_H->chip
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from a396b19 rv32im: set compressed instruction enabled as default.
add c22ab31 fs: flashback to releas
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from d4c0786 drivers/leds/apa102: Fix code style
add 9eae6ed rv32im: fix typo.
add a396b19 rv32im
xiaoxiang781216 merged pull request #2317:
URL: https://github.com/apache/incubator-nuttx/pull/2317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged pull request #2316:
URL: https://github.com/apache/incubator-nuttx/pull/2316
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525683869
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+ * i
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 2d7e063 arch/xtensa/src/esp32/esp32_tim.c: Fix build when debug is
enabled. A non-existent variable was
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from 3956787 Documentation/components/drivers/character/pwm: fix pwm.c
location
add 2d7e063 arch/xtens
xiaoxiang781216 merged pull request #2321:
URL: https://github.com/apache/incubator-nuttx/pull/2321
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
xiaoxiang781216 merged pull request #2330:
URL: https://github.com/apache/incubator-nuttx/pull/2330
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
yamt commented on pull request #486:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/486#issuecomment-729338338
nxstyle errors are expected. this file doesn't follow nxstyle at all.
This is an automated message from
yamt opened a new pull request #486:
URL: https://github.com/apache/incubator-nuttx-apps/pull/486
## Summary
## Impact
## Testing
This is an automated message from the Apache Git Service.
To respond to t
Donny9 commented on pull request #484:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/484#issuecomment-729336965
> @Donny9
>
/home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/system/readline/readline.h:92:3:
error: Small odd alignment
>
/home/runner/work/in
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new fd300cb Publishing web
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a commit to branch asf-site
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-website.git
The following commit(s) were added to refs/heads/asf-site by this push:
new fd300cb Publishing web
masayuki2009 commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729299783
> > @btashton
> > Could you backport this PR to the 10.0 branch?
>
> Sure I'll go through these tonight there are a few more as well. I already
did this fo
btashton commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729294997
> @btashton
> Could you backport this PR to the 10.0 branch?
>
Sure I'll go through these tonight there are a few more as well. I already
did this for the
masayuki2009 commented on pull request #2309:
URL: https://github.com/apache/incubator-nuttx/pull/2309#issuecomment-729280432
@btashton
Could you backport this PR to the 10.0 branch?
This is an automated message from
masayuki2009 commented on pull request #2042:
URL: https://github.com/apache/incubator-nuttx/pull/2042#issuecomment-729279857
@btashton
Could you please backport this PR and PR #2061 to the 10.0 branch?
This is an aut
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525575910
##
File path: drivers/audio/cxd56_src.h
##
@@ -0,0 +1,127 @@
+/
+
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525575910
##
File path: drivers/audio/cxd56_src.h
##
@@ -0,0 +1,127 @@
+/
+
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525574262
##
File path: drivers/audio/cxd56_src.h
##
@@ -0,0 +1,127 @@
+/
+
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525574756
##
File path: drivers/audio/cxd56_src.h
##
@@ -0,0 +1,127 @@
+/
+
masayuki2009 commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525574262
##
File path: drivers/audio/cxd56_src.h
##
@@ -0,0 +1,127 @@
+/
+
yamt commented on pull request #:
URL: https://github.com/apache/incubator-nuttx/pull/#issuecomment-729251876
> > > All patches fix the type mismatch issue, why split it into multiple
small one(e.g. sim has 4 patch).
> >
> >
> > have you read the commit messages fo those
Ouss4 opened a new pull request #2330:
URL: https://github.com/apache/incubator-nuttx/pull/2330
## Summary
A non-existent variable was used in the debug message.
## Impact
Fix build when timer's debug is enabled.
## Testing
N/A
---
This is an automated email from the ASF dual-hosted git repository.
aguettouche pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git.
from fa713c0 arch/arm/src/stm32h7/stm32_otghost.c: Fix undeclared "ret".
add 3956787 Documentation/co
Ouss4 merged pull request #2329:
URL: https://github.com/apache/incubator-nuttx/pull/2329
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
diegoherranz opened a new pull request #2329:
URL: https://github.com/apache/incubator-nuttx/pull/2329
- pwm.c was moved in 68bbc8438c6f1e8a448b14a32a1da70cf0e4609f but the
documentation wasn't updated.
- Also a minor typo fixed.
Thanks!
---
patacongo opened a new issue #2328:
URL: https://github.com/apache/incubator-nuttx/issues/2328
IPv4 packet re-assembly is implemented in net/devif/ipv4_input.c. The
current implementation, however, has too many limitations to be useful:
1. IPv4 reassembly is untested.
2. Currentl
patacongo opened a new issue #2327:
URL: https://github.com/apache/incubator-nuttx/issues/2327
net/tcp/tcp_input.c contains data to detect the presence of urgent OOB data
in a packet. It will also save the a pointer to the urgent data and the size
of the urgent data.
However, there
acassis commented on a change in pull request #2269:
URL: https://github.com/apache/incubator-nuttx/pull/2269#discussion_r525408871
##
File path: boards/xtensa/esp32/esp32-core/src/esp32_bringup.c
##
@@ -143,7 +143,7 @@ int esp32_bringup(void)
#endif
-#if defined(CONFIG_ES
v01d commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729131978
Ok, thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log
btashton commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729127051
I agree that the existing stack needs to be adjusted a bit but you will
still have packets that are not at L2CAP level.
I suspect we just need to be increasing t
rzr opened a new pull request #485:
URL: https://github.com/apache/incubator-nuttx-apps/pull/485
Change-Id: Iab80381e4f451ac186515cd5593434d80e4c7421
Relate-to: https://github.com/rzr/aframe-smart-home/issues/3
Signed-off-by: Philippe Coval
## Summary
## Impact
##
acassis commented on pull request #2321:
URL: https://github.com/apache/incubator-nuttx/pull/2321#issuecomment-729110408
Hi @diegoherranz please just fix the Coding Styles issues that was already
in the apa102 and push the commit. Thanks for fixing the incorrect reference.
---
xiaoxiang781216 opened a new pull request #2326:
URL: https://github.com/apache/incubator-nuttx/pull/2326
## Summary
1.Support arguments before options(e.g. ls /dev -l)
2.Support the long options by getopt_long
3.Support the reentrant version(e.g. getopt_r)
4.Move the related dec
v01d commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729103233
Also, why the need to introduce a config variable for the gyro which is
actually on-board? I would presume this should always be zero (many boards do
this).
-
v01d edited a comment on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729102603
Can you move the check for HPWORK define in code to Kconfig, only for when
BUFFER > 0?
This is an a
v01d commented on pull request #2318:
URL: https://github.com/apache/incubator-nuttx/pull/2318#issuecomment-729102603
Can you remove the check for HPWORK define in code to Kconfig, only for when
BUFFER > 0?
This is an automa
v01d commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729078791
I don't understand what you mean as nimBLE runs on top of the socket.
I think the actual issue is that NuttX's own stack is not very well
integrated to NuttX: there's
btashton commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729074040
But I should be able to run nimBLE on top of the socket regardless just as
we do with Linux. There is something ugly happening here if we need to change
the free logic.
This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new 4a5152f netutils/netcat: Add n
xiaoxiang781216 merged pull request #482:
URL: https://github.com/apache/incubator-nuttx-apps/pull/482
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
v01d commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729066228
Well, the allocated buffer needs to be freed eventually, don't see why that
it is odd. The only reason why this isn't done there for both cases is NuttX's
stack need to kee
xiaoxiang781216 commented on pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-729064802
or libc/audio?
This is an automated message from the Apache Git Service.
To respond to the messa
btashton commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729047833
I still think it's a little odd that we are having to add this special case
here. Seems like this is a problem for anything sending via the raw channel?
--
btashton commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525280954
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,606 @@
+/
+ * d
v01d commented on issue #1639:
URL:
https://github.com/apache/incubator-nuttx/issues/1639#issuecomment-729025031
I think that we can close this right? Or if you prefer to keep it to remind
about the MGMT and monitor channel, the title could be changed.
---
v01d commented on pull request #2302:
URL: https://github.com/apache/incubator-nuttx/pull/2302#issuecomment-729016848
I went over this again. I'm now (hopefully) addressing both issues
correctly. These were actually unrelated: the missing release on receive queue
was simply a mistake. As f
jerpelea commented on pull request #484:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/484#issuecomment-728975086
@Donny9
/home/runner/work/incubator-nuttx-apps/incubator-nuttx-apps/apps/system/readline/readline.h:92:3:
error: Small odd alignment
/home/runner/work/incub
Donny9 opened a new pull request #484:
URL: https://github.com/apache/incubator-nuttx-apps/pull/484
## Summary
Fix compile break when disable CONFIG_READLINE_ECHO
## Impact
Fix compile break
## Testing
daily test
--
v01d commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525161235
##
File path: mm/circ_buf/circ_buf.c
##
@@ -0,0 +1,496 @@
+/
+ * mm/circ_
Donny9 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525195649
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+ * i
Donny9 opened a new pull request #483:
URL: https://github.com/apache/incubator-nuttx-apps/pull/483
## Summary
Fix test failed when some apis are NULL.
## Impact
Fix bug for some special driver.
## Testing
daily test
--
davids5 commented on a change in pull request #2315:
URL: https://github.com/apache/incubator-nuttx/pull/2315#discussion_r525181300
##
File path: include/nuttx/mm/circ_buf.h
##
@@ -0,0 +1,308 @@
+/
+ *
juniskane commented on pull request #2325:
URL: https://github.com/apache/incubator-nuttx/pull/2325#issuecomment-728950144
@davids5 : unfortunately not really tested DMA + flow control with upstream
NuttX because for that STM32L1 needs the functionality reverted by df9ae3c13f.
It would be
xiaoxiang781216 edited a comment on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728942587
> Can this be cascaded with priority of chip -> arch -> system:
Yes, you can achieve this by select one of:
1. CONFIG_ARCH_CHIP_DEBUG_H->chip
xiaoxiang781216 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728942587
> Can this be cascaded with priority of chip -> arch -> system:
Yes, you can achieve this by select one of:
1. CONFIG_ARCH_CHIP_DEBUG_H->chip
2. C
davids5 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728933312
Can this be cascaded with priority of chip -> arch -> system:
```
/* The actual logger function may be overridden in arch/debug.h if needed.
* (Currently only if
jerpelea commented on pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-728929148
@xiaoxiang781216 I can move it to libs if needed
This is an automated message from the Apache Git Serv
rzr commented on a change in pull request #482:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/482#discussion_r525152733
##
File path: netutils/netcat/Kconfig
##
@@ -0,0 +1,52 @@
+#
+#
+# net
jerpelea commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525151767
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,606 @@
+/
+ * d
patacongo commented on a change in pull request #2282:
URL: https://github.com/apache/incubator-nuttx/pull/2282#discussion_r525138881
##
File path: drivers/audio/cxd56_src.c
##
@@ -0,0 +1,606 @@
+/
+ *
xiaoxiang781216 commented on pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#issuecomment-728907009
@jerpelea libsamplerate could be used in userspace application too, so why
not put into apps/ or libs/ folder?
-
xiaoxiang781216 edited a comment on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728905096
> Should these be 2 independent settings?
>
> I can have none, either one or both.
No, we can't select both. Because only one function named _
xiaoxiang781216 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728905096
> Should these be 2 independent settings?
>
> I can have none, either one or both.
No, we can't select both. Because only one function named __arch_s
xiaoxiang781216 commented on a change in pull request #482:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/482#discussion_r525122085
##
File path: netutils/netcat/Kconfig
##
@@ -0,0 +1,52 @@
+###
davids5 commented on pull request #2320:
URL: https://github.com/apache/incubator-nuttx/pull/2320#issuecomment-728895155
Should these be 2 independent settings?
I can have none, either one or both.
This is an automated
davids5 commented on pull request #2325:
URL: https://github.com/apache/incubator-nuttx/pull/2325#issuecomment-728889446
@juniskane - I think there is a subtle changes. Ins't the The DMA disable
path is now different? Did you test with DMA & flow control?
---
Ouss4 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525095651
##
File path: audio/Makefile
##
@@ -75,7 +77,7 @@ $(BIN): $(OBJS)
depend: .depend
-clean:
+clean: .clean
Review comment:
I think it's b
Ouss4 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525094998
##
File path: audio/Makefile
##
@@ -49,6 +49,8 @@ ifeq ($(CONFIG_AUDIO_FORMAT_PCM),y)
CSRCS += pcm_decode.c
endif
+include libsrc/Make.defs
R
Ouss4 commented on a change in pull request #2324:
URL: https://github.com/apache/incubator-nuttx/pull/2324#discussion_r525094998
##
File path: audio/Makefile
##
@@ -49,6 +49,8 @@ ifeq ($(CONFIG_AUDIO_FORMAT_PCM),y)
CSRCS += pcm_decode.c
endif
+include libsrc/Make.defs
R
1 - 100 of 123 matches
Mail list logo
