sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds the support to create a job for the `Of
sfantao created this revision.
sfantao added reviewers: echristo, tra, jlebar, hfinkel, ABataev.
sfantao added subscribers: caomhin, carlo.bertolli, arpith-jacob,
andreybokhanko, Hahnfeld, cfe-commits.
Herald added a subscriber: mehdi_amini.
This patch adds the support to create jobs for the `Off
sfantao updated this revision to Diff 62435.
sfantao marked 5 inline comments as done.
sfantao added a comment.
- Mark classes with final and fix comments.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
sfantao added a comment.
Hi Alexey,
Thanks for the review! I addressed your comments in the last diff.
In http://reviews.llvm.org/D18171#471044, @ABataev wrote:
> No '\brief's
When you say "no \brief" do you mean I am using that where I shouldn't or the
other way around. I am only adding th
sfantao updated this revision to Diff 62438.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix comments, annotate classes with final, and add default initializers.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: l
sfantao added a comment.
Hi Alexey,
Thanks for the review! Addressed your comments in the new diff.
I'll wait for your response on my question in http://reviews.llvm.org/D18172 to
address the issue with \brief properly.
Thanks again,
Samuel
http://reviews.llvm.org/D18172
_
sfantao added a comment.
In http://reviews.llvm.org/D18171#471824, @sfantao wrote:
> Hi Alexey,
>
> Thanks for the review! I addressed your comments in the last diff.
>
> In http://reviews.llvm.org/D18171#471044, @ABataev wrote:
>
> > No '\brief's
>
>
> When you say "no \brief" do you mean I am
sfantao added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
ABataev wrote:
>
sfantao updated this revision to Diff 62460.
sfantao added a comment.
- Remove \brief.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChai
sfantao added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:11377
@@ +11376,3 @@
+// item should be a pointer or array
+if (!Type.getNonReferenceType()->isPointerType()) {
+ Diag(ELoc, diag::err_omp_usedeviceptr_not_a_pointer)
ABataev wrote:
>
sfantao updated this revision to Diff 62462.
sfantao added a comment.
- Remove \brief.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Dri
sfantao added a comment.
In http://reviews.llvm.org/D18172#471861, @jlebar wrote:
> Alexey, it seems that you're asking for "final" on all classes that are not
> inherited from. Forgive my ignorance, but would you mind pointing me to the
> document that talks about our position on "final" in L
sfantao updated this revision to Diff 62506.
sfantao added a comment.
- Use double instead of triple slash in one comment.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
sfantao updated this revision to Diff 62507.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Fix comments.
- Mark functions properly with const and static.
- Remove \brief.
http://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index:
sfantao updated this revision to Diff 62516.
sfantao marked an inline comment as done.
sfantao added a comment.
- Check the OpenMP flags only in one place for purposes of obtaining the
runtime kind.
http://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/Driver/Driver.cpp:464-468
@@ +463,7 @@
+ RuntimeName = A->getValue();
+HasCompatibleOpenMP = llvm::StringSwitch(RuntimeName)
+ .Case("libomp", true)
+
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/Driver/Driver.cpp:2416
@@ +2415,3 @@
+ /// be collapsed with it.
+ struct JobActionInfoTy {
+// \brief The action this info refers to.
ABataev wrote:
> I think this can be marked '
sfantao updated this revision to Diff 62518.
sfantao added a comment.
- Add code dropped accidently in the previous diff.
http://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
sfantao updated this revision to Diff 62519.
sfantao marked an inline comment as done.
sfantao added a comment.
- Mark class as final and remove \brief from comments.
http://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.
sfantao added a comment.
Hi Alexey,
Thanks for the review! Addressed your comment in the new diff. Also removed
`\brief` from the comments.
http://reviews.llvm.org/D21845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
sfantao updated this revision to Diff 62523.
sfantao marked an inline comment as done.
sfantao added a comment.
- Use llvm::sys::path::replace_extension to deal with the extension of the
linker script.
http://reviews.llvm.org/D21847
Files:
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/
sfantao added a comment.
Hi Alexey,
Thanks for the review! Addressed the comments in the new diff.
http://reviews.llvm.org/D21847
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 62525.
sfantao added a comment.
- Remove \brief from one comment.
http://reviews.llvm.org/D21847
Files:
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
==
sfantao updated this revision to Diff 62528.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Add default initializers to toolchain arguments key and use range based
iterator in Dtor.
http://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
include/clang
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/Driver/Compilation.h:73
@@ +72,3 @@
+ /// architecture, and device offload kind.
+ struct TCArgsKey {
+const ToolChain *TC;
ABataev wrote:
> 1. 'final'
> 2. default initi
sfantao added a comment.
In http://reviews.llvm.org/D18172#472152, @jlebar wrote:
> Yeah, I'd say that in the absence of a rule, consistency with surrounding
> code is king. Otherwise we're sending a message when we don't mean to be.
>
> I'm not at my machine, but my recollection is that most o
sfantao updated this revision to Diff 62538.
sfantao marked 9 inline comments as done.
sfantao added a comment.
- Merge branch 'master' into patch-D13909
- Remove unecessary returns and fix iterators.
http://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundle
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: test/Driver/clang-offload-bundler.c:14
@@ +13,3 @@
+//
+// RUN: touch %t.empty
+
ABataev wrote:
> Hmm, will it work on Windows? Maybe it is better just to add an empty test
> file?
I see ma
sfantao updated this revision to Diff 62540.
sfantao added a comment.
- Remove \brief when not needed.
http://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler/CMakeLists.txt
tools/clang-offload-bund
sfantao updated this revision to Diff 62550.
sfantao marked 6 inline comments as done.
sfantao added a comment.
- Remove \brief and return errors instead of crashing when temporary tiles
can't be created.
http://reviews.llvm.org/D21851
Files:
test/Driver/clang-offload-bundler.c
tools/clang
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:345
@@ +344,3 @@
+ /// return the triple by reference.
+ bool isOffloadSection(SectionRef CurSection, StringRef &OffloadTriple) {
+StringRef SectionN
sfantao updated this revision to Diff 62553.
sfantao added a comment.
- Rebase.
- Fix format.
http://reviews.llvm.org/D21852
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openm
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/Driver/Types.h:78
@@ +77,3 @@
+ /// compilation phase is a preprocessor one.
+ bool isSrcFile(ID Id);
+
ABataev wrote:
> 'const'?
`isSrcFile` is not member of a class. It is
sfantao updated this revision to Diff 62558.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Mark classes 'final' and set defalt initializers.
http://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/
sfantao updated this revision to Diff 62561.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Use StringRef instead of string and mark bundler tool as final.
http://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/Driver/Action.cpp:133
@@ +132,3 @@
+/// we assume 'host'.
+std::string Action::getOffloadKindName(OffloadKind Kind) {
+ switch (Kind) {
ABataev wrote:
> 1. Maybe it is enough to return
sfantao updated this revision to Diff 62565.
sfantao added a comment.
- Add Ctor dropped by mistake in the previous diff.
http://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.c
sfantao updated this revision to Diff 62567.
sfantao added a comment.
- Use StringRef instead of std::string, fix comments and mark class final.
http://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChai
sfantao updated this revision to Diff 62569.
sfantao marked 2 inline comments as done.
sfantao added a comment.
- Change name of static function, format comments and remove \brief.
http://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Tool.h
lib/Driver/A
sfantao added a comment.
Hi Alexey, thanks for the review!
Comment at: include/clang/Driver/Tool.h:132-140
@@ -131,1 +131,11 @@
const char *LinkingOutput) const = 0;
+ /// ConstructJob - Construct jobs to perform the action \p JA,
+ /// writing to
sfantao updated this revision to Diff 62572.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
sfantao updated this revision to Diff 62573.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driv
sfantao updated this revision to Diff 62575.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.cp
sfantao updated this revision to Diff 62577.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tools.
sfantao updated this revision to Diff 62580.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
--- test/Driver/op
sfantao updated this revision to Diff 62582.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D21847
Files:
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
==
sfantao updated this revision to Diff 62583.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/ToolChain.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolChai
sfantao updated this revision to Diff 62584.
sfantao added a comment.
- Start staic function name with caps.
http://reviews.llvm.org/D21851
Files:
test/Driver/clang-offload-bundler.c
tools/clang-offload-bundler/ClangOffloadBundler.cpp
Index: tools/clang-offload-bundler/ClangOffloadBundler.
sfantao updated this revision to Diff 62587.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D21852
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
sfantao updated this revision to Diff 62589.
sfantao added a comment.
- Rebase
http://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Types.cpp
test/Driver/ope
sfantao updated this revision to Diff 62590.
sfantao added a comment.
- Start static function name with caps.
http://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/
sfantao updated this revision to Diff 62591.
sfantao added a comment.
- Fix format.
http://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools
sfantao added a comment.
Hi David,
Thanks for the fix!
Comment at: lib/Sema/SemaOpenMP.cpp:10639
@@ -10638,2 +10638,3 @@
break;
}
+while(SI != SE) {
You have to document what you are trying to accomplish here, something like
`"Che
sfantao added a comment.
Thanks. You have to wait for Alexey to take a look at the patch too.
Thanks again,
Samuel
http://reviews.llvm.org/D22075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
sfantao added a comment.
Hi Jonas,
Thanks for trying that out!
Comment at: tools/clang-offload-bundler/ClangOffloadBundler.cpp:477-490
@@ +476,16 @@
+
+// Do the incremental linking. We write to the output file directly. So, we
+// close it and use the name to pass down
sfantao added a comment.
In http://reviews.llvm.org/D21857#476527, @Hahnfeld wrote:
> Hi Samuel,
>
> this looks pretty good overall!
>
> I've only encountered one issue which I don't really know is caused by which
> patch: I can't use the (exact) same triple for offloading and the host when
> c
sfantao added a comment.
In http://reviews.llvm.org/D21851#477905, @Hahnfeld wrote:
> Another overall question: Back in February you said that it would be possible
> to have a "default" object that can be taken without knowledge of the bundler
> (see http://lists.llvm.org/pipermail/cfe-dev/2016
sfantao marked 4 inline comments as done.
sfantao added a comment.
That was probably not the reason why you were getting the failure, but the
bundler was not prepared to bundle files if the host was not the first input. I
fixed that.
I also replaced the test that was running the linker by somet
sfantao updated this revision to Diff 63361.
sfantao added a comment.
- Allow host object to come in any order when generating the binary. Add
testing for that.
- Add save temps and command print option.
- Add bundled object for testing.
http://reviews.llvm.org/D21851
Files:
test/Driver/clan
sfantao updated this revision to Diff 63362.
sfantao added a comment.
- Add tests for when the host does not come first.
- Fix format of comments and add variable to trace the position of the host
input.
http://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bu
sfantao updated this revision to Diff 63365.
sfantao marked an inline comment as done.
sfantao added a comment.
- Bind an action to an offloading prefix even if no bound architecture is used.
http://reviews.llvm.org/D21847
Files:
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/open
sfantao added inline comments.
Comment at: lib/Driver/Driver.cpp:3108-3115
@@ +3107,10 @@
+
+// Now that we have all the results generated, select the one that should
be
+// return for the current depending action.
+std::pair ActionTC = {
+A,
+GetTripl
sfantao updated this revision to Diff 63680.
sfantao added a comment.
- Rebase.
- Remove static function no longer necessary.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/
sfantao updated this revision to Diff 63681.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Dri
sfantao updated this revision to Diff 63682.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.c
sfantao updated this revision to Diff 63683.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tools
sfantao added a comment.
@tra, any more comments about this patch?
Thanks!
Samuel
http://reviews.llvm.org/D18171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 63684.
sfantao added a comment.
- Rebase.
http://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
--- test/Driver/o
sfantao updated this revision to Diff 63850.
sfantao marked 4 inline comments as done.
sfantao added a comment.
- Add assertions before accessing getInputs() when assumptions are made about
the number of elements.
- Add missing evaluations of end iterator in the beginning of loops.
- Address othe
sfantao updated this revision to Diff 63852.
sfantao added a comment.
- Add one more assert.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/To
sfantao added a comment.
Hi Art,
Thanks for the review! Addressed your comments in the last diff.
Thanks again,
Samuel
Comment at: lib/Driver/Action.cpp:191-202
@@ +190,14 @@
+const OffloadActionWorkTy &Work) const {
+ auto I = getInputs().begin();
+ auto E = getInputs()
sfantao updated this revision to Diff 63865.
sfantao marked an inline comment as done.
sfantao added a comment.
- Modify assertion to check that sizes of input dependences and device
toolchains is consistent.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang
sfantao added inline comments.
Comment at: lib/Driver/Action.cpp:191-202
@@ +190,14 @@
+ auto I = getInputs().begin();
+ auto E = getInputs().end();
+ if (I == E)
+return;
+
+ // Skip host action
+ if (HostTC)
+++I;
+
+ auto TI = DevToolChains.begin();
+ for (; I !=
sfantao updated this revision to Diff 63880.
sfantao added a comment.
- Add test to check the generated phases for CUDA.
- Fix typo in comment.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver
sfantao updated this revision to Diff 63889.
sfantao added a comment.
- Add comments and REQUIRE directives to test.
http://reviews.llvm.org/D18171
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Dr
sfantao marked an inline comment as done.
Comment at: test/Driver/cuda_phases.cu:2
@@ +1,3 @@
+// Tests the phases generated for a CUDA offloading target for different
+// combinations of:
+// - Number of gpu architectures;
Oh, ok. Thought that the registration of
Author: sfantao
Date: Fri Jul 15 18:13:27 2016
New Revision: 275645
URL: http://llvm.org/viewvc/llvm-project?rev=275645&view=rev
Log:
[CUDA][OpenMP] Create generic offload action
Summary:
This patch replaces the CUDA specific action by a generic offload action. The
offload action may have multip
Author: sfantao
Date: Fri Jul 15 18:51:21 2016
New Revision: 275650
URL: http://llvm.org/viewvc/llvm-project?rev=275650&view=rev
Log:
Attempt to fix breakage caused by r275645 for Windows bots.
Modified:
cfe/trunk/include/clang/Driver/Action.h
cfe/trunk/lib/Driver/Action.cpp
Modified: cf
Author: sfantao
Date: Fri Jul 15 19:15:56 2016
New Revision: 275651
URL: http://llvm.org/viewvc/llvm-project?rev=275651&view=rev
Log:
Use std::string instead of StringRef when generating the auxiliar triple in the
frontend tool.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/
sfantao updated this revision to Diff 49239.
sfantao marked 3 inline comments as done.
sfantao added a comment.
Use better disgnostic message and OMPArraySectionExpr::getBaseOriginalType.
http://reviews.llvm.org/D17547
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOpenMP.cp
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7767-7768
@@ -7766,4 +7766,4 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "
sfantao updated this revision to Diff 49244.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove extra braces.
Waiting on dependency.
http://reviews.llvm.org/D17367
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
t
sfantao updated this revision to Diff 49247.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove extra braces.
Waiting on dependency.
http://reviews.llvm.org/D17368
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
t
sfantao updated this revision to Diff 49249.
sfantao marked 2 inline comments as done.
sfantao added a comment.
Remove extra braces.
Waiting on dependency.
http://reviews.llvm.org/D17369
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
t
Author: sfantao
Date: Fri Feb 26 18:01:58 2016
New Revision: 262094
URL: http://llvm.org/viewvc/llvm-project?rev=262094&view=rev
Log:
[OpenMP] Fix parsing of delete map clause modifier in C++ mode.
Summary: The map modifier 'delete' is parser in c++ mode as a delete keyword,
which requires speci
sfantao updated this revision to Diff 49331.
sfantao marked an inline comment as done.
sfantao added a comment.
Emit num teams and thread limit using the inlined directives machinery.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/C
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4002
@@ +4001,3 @@
+static llvm::Value *
+emitNumTeamsClauseForTargetDirective(CodeGenFunction &CGF,
+ const OMPExecutableDirective &D,
ABataev wrote:
>
sfantao updated this revision to Diff 49653.
sfantao added a comment.
Use new innermost scope API for the emission of the num_teams and thread_limit
expressions.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/teams_codegen.c
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:256-296
@@ -255,26 +255,43 @@
/// \brief RAII for emitting code of OpenMP constructs.
class InlinedOpenMPRegionRAII {
CodeGenFunction &CGF;
+ /// \brief Saves the varaibles that were forced to be loca
sfantao updated this revision to Diff 49709.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Allow array expressions whose memory contiguous checks are inconclusive.
- Add C test to check the constant expressions no longer can prove bounds in
array sections.
http://reviews.
sfantao added inline comments.
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7787-7789
@@ -7786,5 +7786,5 @@
"bit fields cannot be used to specify storage in a map clause">;
-def err_omp_array_section_in_rightmost_expression : Error<
- "array section can only be assoc
sfantao updated this revision to Diff 49712.
sfantao marked 4 inline comments as done.
sfantao added a comment.
- Remove InnerInlineRegion Kind. Improve comments and other two minor edits.
http://reviews.llvm.org/D17019
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGStmtOpenMP.cpp
t
sfantao added a comment.
Hi Alexey,
Thanks for the review!
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:49-51
@@ -48,2 +48,5 @@
TargetRegion,
+/// \brief Region that do not require function outlining and uses
+/// information from a inner scope.
+InlinedInnerReg
Author: sfantao
Date: Thu Mar 3 10:20:23 2016
New Revision: 262625
URL: http://llvm.org/viewvc/llvm-project?rev=262625&view=rev
Log:
[OpenMP] Code generation for teams - kernel launching
Summary:
This patch implements the launching of a target region in the presence of a
nested teams region, i.
sfantao updated this revision to Diff 49749.
sfantao marked 4 inline comments as done.
sfantao added a comment.
- Remove extra braces and revert the sense of the whole/unity array section
check.
http://reviews.llvm.org/D17547
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaO
sfantao added inline comments.
Comment at: lib/Sema/SemaOpenMP.cpp:9071
@@ +9070,3 @@
+/// 0 if it is inconclusive.
+static int CheckArrayExpressionReferToWholeSize(Sema &SemaRef, const Expr *E,
+QualType BaseQTy) {
sfantao updated this revision to Diff 49827.
sfantao added a comment.
- Change return value from int to bool.
http://reviews.llvm.org/D17547
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/Sema/SemaOpenMP.cpp
test/OpenMP/target_map_messages.cpp
Index: test/OpenMP/target_map_message
sfantao marked an inline comment as done.
Comment at: lib/Sema/SemaOpenMP.cpp:9127
@@ +9126,3 @@
+// whose base type is \a BaseQTy.
+static bool CheckArrayExpressionDoesNotReferToUnitySize(Sema &SemaRef,
+ const Expr *E,
--
Author: sfantao
Date: Fri Mar 4 15:02:14 2016
New Revision: 262744
URL: http://llvm.org/viewvc/llvm-project?rev=262744&view=rev
Log:
Revert r262741 - [OPENMP] Codegen for distribute directive
Was causing a failure in one of the buildbot slaves.
Removed:
cfe/trunk/test/OpenMP/distribute_code
Author: sfantao
Date: Wed Mar 9 09:46:05 2016
New Revision: 263019
URL: http://llvm.org/viewvc/llvm-project?rev=263019&view=rev
Log:
[OpenMP] Add support for multidimensional array sections in map clause SEMA.
Summary: In some cases it can be proved statically that multidimensional array
sectio
301 - 400 of 453 matches
Mail list logo
