sfantao added inline comments.

================
Comment at: lib/Sema/SemaOpenMP.cpp:9071
@@ +9070,3 @@
+/// 0 if it is inconclusive.
+static int CheckArrayExpressionReferToWholeSize(Sema &SemaRef, const Expr *E,
+                                                QualType BaseQTy) {
----------------
ABataev wrote:
> Don't use 'int' as a result of the functions, add enumeric and use it.
I changed this back to bool and reverted the sense given that I am only taking 
any action if something is proved NOT to be whole or unity.

================
Comment at: lib/Sema/SemaOpenMP.cpp:9127
@@ +9126,3 @@
+// if it is inconclusive.
+static int CheckArrayExpressionReferToUnitySize(Sema &SemaRef, const Expr *E,
+                                                QualType BaseQTy) {
----------------
ABataev wrote:
> Again, use enum as a return result
Using bool instead with reverted sense.


http://reviews.llvm.org/D17547



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to