sfantao added a comment.
Hi Alexey,
Thanks for the review!
================
Comment at: lib/Driver/Driver.cpp:2416
@@ +2415,3 @@
+ /// be collapsed with it.
+ struct JobActionInfoTy {
+ // \brief The action this info refers to.
----------------
ABataev wrote:
> I think this can be marked 'final' and add 'nullptr' as a default initializer
> for 'JA' field
Yep, I'm doing that now.
================
Comment at: lib/Driver/Driver.cpp:2426
@@ +2425,3 @@
+ /// in the action info array.
+ void appendCollapsedOffloadAction(ActionList &CollapsedOffloadAction,
+ ArrayRef<JobActionInfoTy> &ActionInfo,
----------------
ABataev wrote:
> I think this function can be marked as 'static', no?
You're right, using static now.
http://reviews.llvm.org/D21840
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
