sfantao added a comment.
Hi Alexey,
Thanks for the review!
================
Comment at: include/clang/Driver/Compilation.h:73
@@ +72,3 @@
+ /// architecture, and device offload kind.
+ struct TCArgsKey {
+ const ToolChain *TC;
----------------
ABataev wrote:
> 1. 'final'
> 2. default initializers for fields.
I added the default initializers but that required me to add a Ctor so that
initializer lists work when this struct is built.
================
Comment at: include/clang/Driver/Compilation.h:206
@@ +205,3 @@
+ const llvm::opt::DerivedArgList &
+ getArgsForToolChain(const ToolChain *TC, const char *BoundArch,
+ Action::OffloadKind DeviceOffloadKind);
----------------
ABataev wrote:
> 'const' function?
This one can't be marked const has it potentially changes the cache of
translated arguments.
http://reviews.llvm.org/D21848
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
