sfantao added a comment.
Hi Alexey,
Thanks for the review!
================
Comment at: lib/Driver/Action.cpp:133
@@ +132,3 @@
+/// we assume 'host'.
+std::string Action::getOffloadKindName(OffloadKind Kind) {
+ switch (Kind) {
----------------
ABataev wrote:
> 1. Maybe it is enough to return just StringRef, rather than std::string
> 2. This can be made 'static'
True, it can be a `StringRef`. This function is already marked static in its
declaration.
http://reviews.llvm.org/D21856
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
