rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
Hi Sam,
The patch looks good, thanks!
A few comments on the process:
1. When you send an update, send the whole patch again, not just the new diff.
E
rengolin added a comment.
Right, if you could update both reviews with the full patch, I could commit
them for you, for now.
http://reviews.llvm.org/D18311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
rengolin closed this revision.
rengolin added a comment.
Committed in r263957.
http://reviews.llvm.org/D18311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rengolin
Date: Mon Mar 21 12:29:51 2016
New Revision: 263957
URL: http://llvm.org/viewvc/llvm-project?rev=263957&view=rev
Log:
[ARM] Clang tests for ARM Cortex-A32 support
Patch by Sam Parker.
Modified:
cfe/trunk/test/CodeGen/arm-target-features.c
cfe/trunk/test/Driver/arm-cortex
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
Nice cleaning! LGTM. Thanks!
http://reviews.llvm.org/D18391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
rengolin added a comment.
Tests?
http://reviews.llvm.org/D15883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rengolin added a comment.
Well, I only saw later that these are propositions from another patch...
I don't see why this can't be part of the original patch, but I'm ok with no
tests if they're used (and tested) on the final patch.
I'll defer to Logan to decide. :)
http://reviews.llvm.org/D158
On 14 January 2016 at 10:41, Andrey Bokhanko via cfe-commits
wrote:
> Author: asbokhan
> Date: Thu Jan 14 04:41:16 2016
> New Revision: 257754
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257754&view=rev
> Log:
> PR25910: clang allows two var definitions with the same mangled name
Hi Andrey,
On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits
wrote:
> Author: cbieneman
> Date: Fri Jan 15 15:21:12 2016
> New Revision: 257934
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev
> Log:
> [CMake] Support generation of linker order files using dtrace
>
> Summary:
> This
It did, thanks!
On 15 January 2016 at 23:28, Chris Bieneman wrote:
> That should be fixed with r257948.
>
> -Chris
>
>> On Jan 15, 2016, at 3:19 PM, Renato Golin wrote:
>>
>> On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits
>> wrote:
>>> Author: cbieneman
>>> Date: Fri Jan 15 15:21:1
On 25 January 2016 at 21:14, Ehsan Akhgari via cfe-commits
wrote:
> Author: ehsan
> Date: Mon Jan 25 15:14:52 2016
> New Revision: 258720
>
> URL: http://llvm.org/viewvc/llvm-project?rev=258720&view=rev
> Log:
> [MSVC Compat] Only warn for unknown clang-cl arguments
Hi Eshan,
Not sure you've see
On 26 January 2016 at 01:56, Ehsan Akhgari wrote:
> OK, I reverted the test in r258772.
Thanks!
Ok, the error code with no output will make for an interesting
investigation... :)
I'll try to collect as much info as possible. In the meantime, if you
have any insights, just let me know.
cheers,
rengolin added a comment.
In http://reviews.llvm.org/D14471#288621, @ahatanak wrote:
> In getAArch64TargetCPU, if it finds out the cpu name passed via -mtune or
> -mcpu is "native",
>
> 1. Call llvm::sys::getHostCPUName to get the host CPU name.
> 2. Check the host CPU name to see if it is a val
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14662
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
rengolin added a comment.
In http://reviews.llvm.org/D14570#288132, @compnerd wrote:
> Wow, this is tricky: the code change is in LLVM, and test change in clang :(.
> However, this does seem to preserve the features.
The problem is that Clang is the most important user of this library, which
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM. The 64-bit rev pattern can be added later. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14609
_
On 16 November 2015 at 23:09, Stephen Canon via cfe-commits
wrote:
> Author: scanon
> Date: Mon Nov 16 17:09:11 2015
> New Revision: 253269
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253269&view=rev
> Log:
> Make FP_CONTRACT ON the default.
>
> Differential Revision: D14200
Hi Stephen,
It
On 17 November 2015 at 15:47, Manuel Klimek wrote:
> Reverted in r253337. Failing test case in commit message.
And the bot is green again! :)
Thanks!
--renato
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
rengolin requested changes to this revision.
This revision now requires changes to proceed.
Comment at: lib/Driver/Tools.cpp:6298
@@ -6297,1 +6297,3 @@
unsigned ArchKind;
+ if (Arch == "armv7k" || Arch == "thumbv7k")
+return "v7k"; // In other cases, Cortex-A7 should resol
rengolin added a comment.
Same comment as http://reviews.llvm.org/D14755. Whenever that's approved, so it
this.
http://reviews.llvm.org/D14756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cf
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
This looks good to me. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
rengolin accepted this revision.
rengolin added a comment.
This revision is now accepted and ready to land.
LGTM, too. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D14804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
On 23 November 2015 at 08:33, Daniel Jasper via cfe-commits
wrote:
> Author: djasper
> Date: Mon Nov 23 02:33:48 2015
> New Revision: 253859
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253859&view=rev
> Log:
> Fix calculation of shifted cursor/code positions. Specifically support
> the case w
On 23 November 2015 at 10:41, Daniel Jasper wrote:
> Seen and fixed, I think..
Still looks broken... :)
http://lab.llvm.org:8011/builders/clang-cmake-thumbv7-a15/builds/7684
http://lab.llvm.org:8011/builders/clang-cmake-aarch64-quick/builds/2616
http://lab.llvm.org:8011/builders/clang-cmake-aa
On 23 November 2015 at 22:31, Daniel Jasper wrote:
> Fixed in r253929.
Thanks!
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On 1 December 2015 at 11:44, James Molloy via cfe-commits
wrote:
> In summary, I agree with you that we need tests for both Clang and LLVM
> separately. However I also think the full-trip tests add significant value
> and wouldn't like to see them removed, and there's significant prior art in
> th
On 1 December 2015 at 17:23, James Molloy via cfe-commits
wrote:
> This isn't just a NEON intrinsics thing, and this isn't just an ARM/AArch64
> thing. There needs to be some way to test the compiler from start to finish.
> Not being able to do so leaves serious coverage holes.
Just for the sake
On 1 December 2015 at 18:29, David Blaikie wrote:
> Are they things the test-suite couldn't (either technically or
> philosophically) cover, or only that it doesn't cover it at the moment, but
> could do so?
IMO, it's a philosophical issue. The test-suite is a whole-program
execution, and all tha
On 1 December 2015 at 19:09, David Blaikie wrote:
> Not sure I follow - I'm not suggesting adding objdump/instruction checking
> to existing large programs in the test-suite, but adding other tests to the
> test-suite that do this and have appropriate input for it to be a
> reliable/useful form of
On 1 December 2015 at 19:42, James Molloy wrote:
> Why do you think it would be non trivial? Some simple lit tests aren't
> exactly arduous on most targets.
I mean having more points in the testing matrix.
Clang check-all is cheaper than running the test-suite, but if we
start moving more tests
On 1 December 2015 at 19:45, David Blaikie wrote:
> These cases I don't understand - if they're features LLVM supports we'd just
> test them straight up. If you run our test suite against another compiler it
> should tell you if it's compatible with our compiler (does it offer the same
> functiona
On 1 December 2015 at 19:53, James Molloy wrote:
> I think I'd be OK with demoting these tests to the test-suite, and dealing
> with the slightly lower amount of testing that comes with it if it means we
> can keep the clang tests in a nice shape.
If the tests are independent of sub-architecture
rengolin accepted this revision.
rengolin added a reviewer: rengolin.
rengolin added a comment.
This revision is now accepted and ready to land.
Isn't it time we move AArch64 to the target parser, too?
Anyway, as it is, LGTM, for the time being. Thanks!
Repository:
rL LLVM
http://reviews.llv
On Wed, 18 Aug 2021 at 18:17, MyDeveloper Day via llvm-dev <
llvm-...@lists.llvm.org> wrote:
> But unless I missed this, was there any discussion regarding the recent
> "Winding Down" announcement of Phabricator? and what it might mean for us
> in LLVM
>
I think we have our own self-hosted versio
On Mon, 23 Aug 2021 at 18:56, James Y Knight wrote:
> If phabricator/phorge do turn out to be non-viable in the future, I think
> we may want to reopen the option of moving to Gerrit for the primary
> code-review platform.
>
> I'll note that the Golang folks are using Gerrit as their review platf
On Tue, 24 Aug 2021 at 12:49, Aaron Ballman wrote:
> > A minor issue is that the messages Gerrit sends to Github are a bit
> pointless "Message from PersonA: (1 comment)". It would be better if the
> integration either works (like adding comments to a specific line or
> updating the commits) or n
On Tue, 24 Aug 2021 at 17:30, James Y Knight wrote:
> Yes, the Gerrit hosting which Go uses ("googlesource.com") only permits a
> google-account login as a matter of policy. But that's not a restriction of
> Gerrit itself -- it can perfectly well be configured to use a github login.
>
Ah, awesom
301 - 337 of 337 matches
Mail list logo
