On Mon, 23 Aug 2021 at 18:56, James Y Knight <jykni...@google.com> wrote:
> If phabricator/phorge do turn out to be non-viable in the future, I think > we may want to reopen the option of moving to Gerrit for the primary > code-review platform. > > I'll note that the Golang folks are using Gerrit as their review platform, > and they have a GitHub bot setup to translate GH pull-requests into a > gerrit review, so as to be friendly to first-time or drive-by contributors. > See e.g. https://github.com/golang/go/pull/47766 for an example. > Honestly, this is a thing we can do regardless of which tool we use. There are other tools that integrate with Github more closely that Anton was looking at, but I think none of them had the functionality we needed (which both Phab and Gerrit do). The main problem with that (Go) solution is that the Gerrit install doesn't single-sign-on with Github accounts, it asked me for my Google account. We shouldn't ask people to create more accounts if we want integration with Github. I guess this is just a configuration issue, right? A minor issue is that the messages Gerrit sends to Github are a bit pointless "Message from PersonA: (1 comment)". It would be better if the integration either works (like adding comments to a specific line or updating the commits) or not pollute. Same goes for bug tracker... cheers, --renato
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
