On Tue, 24 Aug 2021 at 12:49, Aaron Ballman <aa...@aaronballman.com> wrote:
> > A minor issue is that the messages Gerrit sends to Github are a bit > pointless "Message from PersonA: (1 comment)". It would be better if the > integration either works (like adding comments to a specific line or > updating the commits) or not pollute. > > Also, the Gerrit review process uses a different workflow than the > Phabricator review process, and we should make sure we're comfortable > with that. My uses of Gerrit (which have been purely corporate in > nature, so my experience may be with an older version of the tool) > have run into some pretty big usability concerns -- like the fact that > it only shows you the diff contents of one file at a time, lacks the > ability to "stack" related patches, comments are easier to lose track > of when updating a review, there's no way to mark comments as "done" > or not, etc. Right, my comment was about the integration, not Gerrit vs Phab vs Github. Whatever integrates with Github should be more succinct, clearer and re-use Github's ID.
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
