[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. LGTM with a few minor edits. Do you have commit access? Comment at: clang-tools-extra/clang-tidy/bugprone/AssignmentInIfConditionCheck.cpp:19-21 +void AssignmentInI

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-assignment-in-if-condition.cpp:84 + +// Add something that doesn't trigger the check here. +void awesome_f2(int arg) { CHANGES SINCE LAST ACTION https://review

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

gribozavr2 added a comment. Thanks! I'll commit this for you once you upload a refreshed patch (that applies to the main branch cleanly). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127114/new/ https://reviews.llvm.org/D127114 ___ cfe-comm

[PATCH] D127114: new clang-tidy checker for assignments within condition clause of if statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG05130a6ba7d9: new clang-tidy checker for assignments within condition clause of if statement (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:263-267 + Possible return values are: + /// - `Satisfiable` : There exists a satisfying assignment for `Constraints`, + ///the solutio

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:266 + /// - `Unsatisfiable`: A satisfying assignment does not exist. + /// - `

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Solver.h:67 +/// boolean formula if available. Otherwise, an empty optional is returned. +std::optional> +getSolution() const { Please use llvm::Optional, we can'

[PATCH] D129180: [clang][dataflow] Return a solution from the solver when `Constraints` are `Satisfiable`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19e21887eb18: [clang][dataflow] Return a solution from the solver when `Constraints` are… (authored by wyt, committed by gribozavr). Changed prior t

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

gribozavr updated this revision to Diff 447609. gribozavr added a comment. Actually visit a subexpression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130522/new/ https://reviews.llvm.org/D130522 Files: clang/lib/Analysis/FlowSensitive/WatchedL

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3281138aad80: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X` (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/Value.h:40-41 // Synthetic boolean values are either atomic values or composites that // represent conjunctions, disjunctions, and negations. AtomicBool, sga

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5e3dac33d42: [clang][dataflow] Add explicit "AST" nodes for implications and iff (authored by gribozavr). Changed prior to commit: https://review

[PATCH] D130270: [clang][dataflow] Use a dedicated bool to encode which branch was taken

gribozavr2 requested changes to this revision. gribozavr2 added a comment. This revision now requires changes to proceed. Sorry, could you rebase the patch? It does not apply cleanly anymore. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130270/new/

[PATCH] D130600: [clang][dataflow] Handle return statements

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:110 + /// Assigns `Loc` as the storage location of `return`. + /// Comment at: clang/include/clang/Analysis/FlowSensitive/

[PATCH] D121796: [clang][dataflow] Add an API for dataflow "models" -- reusable analysis components.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:139 +/// Virtual base class for "dataflow models": reusable analysis components that +/// model a particular aspect of program semantics, with respect to a specific -

[PATCH] D121797: [clang][dataflow] Add modeling of Chromium's CHECK functionality

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/ChromiumCheckModel.cpp:16-17 +namespace dataflow { +/// Determines whether `D` is one of the methods used to implement Chromium's +/// `CHECK` macros. +bool isCheckLikeMethod(llvm::SmallDenseSet

[PATCH] D114732: [clang] Mark `trivial_abi` types as "trivially relocatable".

gribozavr2 added a comment. I rolled it back while @devin.jeanpierre investigates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114732/new/ https://reviews.llvm.org/D114732 ___ cfe-commits mailing list

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Approving the delta for the PS4 fix (relying or @rsmith 's approval for the actual patch -- https://reviews.llvm.org/D114732). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D119017: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG56d46b36fc23: [clang] roll-forward "[clang] Mark `trivial_abi` types as "trivially… (authored by devin.jeanpierre, committed by gribozavr). Reposit

[PATCH] D123059: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable"".""

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b31f06b79a: re-roll-forward "[clang] Mark `trivial_abi` types as "trivially relocatable""."" (authored by devin.jeanpierre, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124952: [clang-tidy] Escape diagnostic messages before passing to `diag` in Transformer.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:107 + ASSERT_EQ(Errors.size(), 1U); + // This should match the input; this

[PATCH] D129546: [clang][dataflow] Refactor boolean creation as a test utility.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:223 +/// Utility class for creating boolean values. +class BoolValueManager { --

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h:24-25 +namespace dataflow { +/// Utility functions which return a string representation for a boolean value +/// `B`. +/// Comment at: clan

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:143 + +return formatv("{0:$[\n]}", llvm::make_range(Lines.begin(), Lines.end())); + } I appreciate the table, but it looks quite bulky... Could we switch to a sim

[PATCH] D129547: [clang][dataflow] Generate readable form of boolean values for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DebugSupport.cpp:33-34 + explicit DebugStringGenerator( + llvm::DenseMap UserSpecifiedAtomNames) + : Counter(0), AtomNames(std::move(UserSpecifiedAtomNames

[PATCH] D129548: [clang][dataflow] Generate readable form of input and output of satisfiability checking for debugging purposes.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h:49-56 +debugString(std::vector &Constraints, Solver::Result &Result, +llvm::DenseMap AtomNames = {{}}); +inline std::string +debu

[PATCH] D130305: [clang][dataflow] Refactor ApplyBuiltinTransfer field out into DataflowAnalysisOptions struct

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysis.h:66 explicit DataflowAnalysis(ASTContext &Context) : Context(Context) {} explicit D

[PATCH] D130306: [clang][dataflow] Analyze calls to in-TU functions

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:231 + // parameters still need to be given `StorageLocation`s anyway, so this code + // will need to be generalized later. + for (; ArgIt != ArgEnd; ++ParamIt, ++ArgIt) { ---

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr created this revision. Herald added subscribers: martong, tschuett, mgrang, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Start by dumping the flow

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr updated this revision to Diff 446988. gribozavr added a comment. Moved some changes to a different revision Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130398/new/ https://reviews.llvm.org/D130398 Files: clang/include/clang/Analysis/

[PATCH] D130400: [clang][dataflow] ArrayRef'ize debugString()

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monor

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

gribozavr updated this revision to Diff 446991. gribozavr added a comment. Fix the build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130399/new/ https://reviews.llvm.org/D130399 Files: clang/include/clang/Analysis/FlowSensitive/DebugSupport.h

[PATCH] D130398: [clang][dataflow] Add Environment::dump()

gribozavr updated this revision to Diff 446992. gribozavr added a comment. Reverted more changes broken out to separate revisions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130398/new/ https://reviews.llvm.org/D130398 Files: clang/include/cla

[PATCH] D130400: [clang][dataflow] ArrayRef'ize debugString()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG589ddd7fe8e4: [clang][dataflow] ArrayRef'ize debugString() (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D130399: [clang][dataflow] Expose stringification functions for SAT solver enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGee6aba85aa48: [clang][dataflow] Expose stringification functions for SAT solver enums (authored by gribozavr). Changed prior to commit: https://re

[PATCH] D130398: [clang][dataflow] Add DataflowEnvironment::dump()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb5414b566a5a: [clang][dataflow] Add DataflowEnvironment::dump() (authored by gribozavr). Changed prior to commit: https://reviews.llvm.org/D130398

[PATCH] D130403: Use the range-based overload of llvm::sort where possible

gribozavr created this revision. Herald added subscribers: carlosgalvezp, cishida, cmtice, usaxena95, kadircet, arphaman, mgrang. Herald added a reviewer: jhenderson. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added a project: All. gribozavr requested review

[PATCH] D130406: Use llvm::sort instead of std::sort where possible

gribozavr created this revision. Herald added subscribers: bzcheeseman, sdasgup3, carlosgalvezp, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini, usaxe

[PATCH] D130403: Use the range-based overload of llvm::sort where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd9a5cfd2e4e: Use the range-based overload of llvm::sort where possible (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D130406: Use llvm::sort instead of std::sort where possible

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaba43035bdf8: Use llvm::sort instead of std::sort where possible (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D130423: [clang][dataflow] Rename iterators from IT to It

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The latter way to abbreviate is a

[PATCH] D130423: [clang][dataflow] Rename iterators from IT to It

gribozavr updated this revision to Diff 447067. gribozavr added a comment. Reverted an unintended edit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130423/new/ https://reviews.llvm.org/D130423 Files: clang/lib/Analysis/FlowSensitive/DataflowAna

[PATCH] D130423: [clang][dataflow] Rename iterators from IT to It

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0c9d717dfd2: [clang][dataflow] Rename iterators from IT to It (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we used to desugar impl

[PATCH] D130522: [clang][dataflow] Fix SAT solver crashes on `X ^ X` and `X v X`

gribozavr created this revision. Herald added subscribers: martong, tschuett, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. gribozavr requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. BooleanFormula::addClause has an i

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

gribozavr updated this revision to Diff 447484. gribozavr added a comment. Normalized more comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130519/new/ https://reviews.llvm.org/D130519 Files: clang/include/clang/Analysis/FlowSensitive/Data

[PATCH] D130519: [clang][dataflow] Add explicit "AST" nodes for implications and iff

gribozavr2 added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:332 + + if (LeftSubVar == RightSubVar) { +// `X <=> (A <=> A)` is equvalent to `X` which is already in xazax.hun wrote: > xazax.hun wrote: > > I

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/AST/CommentCommands.td:93 +def N : InlineCommand<"n", 0>; + Could you add a test that shows that the text

[PATCH] D125473: Comment parsing: Treat properties as zero-argument inline commands

gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125473/new/ https://reviews.llvm.org/D125473 __

[PATCH] D66473: Removed some dead code in BugReporter and related files

gribozavr marked 3 inline comments as done. gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - NoQ wrote: > Hey, i just added that! :D (

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:408 -public: - enum Kind { BasicBRKind, PathSensitiveBRKind }; - NoQ wrote: > gribozavr wrote: > > NoQ wro

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

gribozavr updated this revision to Diff 216342. gribozavr marked an inline comment as done. gribozavr added a comment. Updated a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66473/new/ https://reviews.llvm.org/D66473 Files: clang/inclu

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporter.cpp:2343 InterExplodedGraphMap ForwardMap; - TrimmedGraph = OriginalGraph->trim(Nodes, &ForwardMap, &InverseMap); Szelethus wr

[PATCH] D66473: [analyzer] Removed some dead code in BugReporter and related files

This revision was automatically updated to reflect the committed changes. gribozavr marked an inline comment as done. Closed by commit rL369504: Removed some dead code in BugReporter and related files (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6775 +if (!pathOnlyInitializesGslPointer(Path)) + Init = const_cast(Init->skipRValueSubobjectAdjustments()); I'm afraid this change could disable some other analysis, which would

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4596 +for (Decl *Redecl : D->redecls()) { + Redecl->addAttr(::new (S.Context) + OwnerA

[PATCH] D66631: [clang-tidy] Don't emit google-runtime-references warning for functions defined in macros.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM, although I'd be more comfortable with a whitelist of macros. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-references.cpp:156 +DEFINE_F(func) {} \

[PATCH] D66652: [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Refactoring/Transformer.cpp:197 // Verify the existence and validity of the AST node that roots this rule. + SourceLocation Root

[PATCH] D66700: [Wdocumentation] improve wording of a warning message

gribozavr added a comment. I will commit on Monday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66700/new/ https://reviews.llvm.org/D66700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

gribozavr added inline comments. Comment at: clang/lib/AST/Comment.cpp:151 +static bool getFunctionTypeLoc(TypeLoc TL, FunctionTypeLoc &ResFTL, + bool testTypedefTypeLoc = false) { TypeLoc PrevTL; Why is the new functionality turn

[PATCH] D66700: [Wdocumentation] improve wording of a warning message

This revision was automatically updated to reflect the committed changes. Closed by commit rL369873: [Wdocumentation] improve wording of a warning message (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: http

[PATCH] D66706: [Wdocumentation] fixes an assertion failure with typedefed function and block pointer

gribozavr added inline comments. Comment at: clang/lib/AST/Comment.cpp:151 +static bool getFunctionTypeLoc(TypeLoc TL, FunctionTypeLoc &ResFTL, + bool testTypedefTypeLoc = false) { TypeLoc PrevTL; Mordante wrote: > gribozavr wrote

[PATCH] D66722: [clang] Ensure that comment classes are trivially destructible

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. Regarding adding a test for `DeclInfo` -- SGTM as well. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66722/new/ https://reviews.llvm.org/D66722 _

[PATCH] D66627: [clang-tidy] new check: bugprone-pthread-return

gribozavr added a comment. Thanks for the contribution! In abstract, I think it is a good checker, however, the implementation largely duplicates `clang-tidy/bugprone/PosixReturnCheck.cpp` -- do you think you could factor out the common parts? I see at least two ways: - Factor out a library, u

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

gribozavr added a comment. It does seem reasonable for Clangd to recover when it sees unknown command line flags (after all, in compiler_commands.json we can see command line flags from past and future versions of Clang, GCC and other compilers -- whatever the build system decided to write ther

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

gribozavr added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:106 +// argument, while the change spans only the argument AND there are two such +// matches. Here, we expect a conflict between the two matches and the second

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6775 +if (!pathOnlyInitializesGslPointer(Path)) + Init = const_cast(Init->skipRValueSubobjectAdjustments()); xazax.hun wrote: > gribozavr wrote: > > I'm afraid this change could d

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

gribozavr added a comment. Sorry for the silly comments, but my main point is, I guess, that I don't quite understand the design towards which you are refactoring, and to meaningfully review patches I need to be on the same page. Comment at: clang/include/clang/StaticAnalyzer

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I see, it all makes sense now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66676/new/ https://reviews.llvm.org/D66676 ___

[PATCH] D66747: Moved GlobList into a separate header file

gribozavr created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. It is a separate abstraction that is used in more contexts than just a helper for ClangTidyDiagnosticConsumer. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66747 Fi

[PATCH] D66747: Moved GlobList into a separate header file

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fed93f0d10: Moved GlobList into a separate header file (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66747/new/ https://reviews.l

[PATCH] D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies

gribozavr added inline comments. Comment at: clang/tools/libclang/Indexing.cpp:126 +/// Is thread-safe. +class SharedParsedRegionsStorage { std::mutex Mux; "SharedParsedRegions"? "ThreadSafeParsedRegions"? Comment at: clang/tools/libclang/In

[PATCH] D66787: GlobList: added a clear test for pattern priority

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: ilya-biryukov. The last glob that matches the string decides whether that string is included or excluded. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think it makes method implementations more obvious. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66788 Files: clang-tools-extra/clang-tidy/GlobList.cpp clang-tools-e

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:150 /// + /// If an error was encountered while parsing the arguments, \returns false + /// and a

[PATCH] D66787: GlobList: added a clear test for pattern priority

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd2315ce2101: GlobList: added a clear test for pattern priority (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66787/new/ https://re

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/GlobList.cpp:46 +GlobList::GlobList(StringRef Globs) { + do { +GlobListItem Item; ilya-biryukov wrote: > NIT: I suggest using `for (;!Globs.

[PATCH] D66788: Refactor GlobList from an ad-hoc linked list to a vector

This revision was automatically updated to reflect the committed changes. Closed by commit rL370039: Refactor GlobList from an ad-hoc linked list to a vector (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. LGTM with all comments addressed. Comment at: clang-tools-extra/test/clang-tidy/bugprone-posix-return.cpp:169 int posix_fadvise(int fd, off_t offset, off_t len, int ad

[PATCH] D66797: ArrayRef'ized CompilerInvocation::CreateFromArgs

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: ilya-biryukov. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66797 Files: clang/include/clang/Frontend/CompilerInvocation.h clang/lib/Frontend

[PATCH] D66797: ArrayRef'ized CompilerInvocation::CreateFromArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rL370122: ArrayRef'ized CompilerInvocation::CreateFromArgs (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D66627: [clang-tidy] add checks to bugprone-posix-return

gribozavr accepted this revision. gribozavr added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:70 +- New :doc:`bugprone-posix-return + ` check. jcai19 wrote: > Eugene.Zelenko wrote: > > Check is not new, just modified. Such check should

[PATCH] D66874: [clang-tidy] Fix the potential infinite loop in recordIsTriviallyDefaultConstructible.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clang-tidy/utils/TypeTraits.cpp:57 return true; + // Don't perform the check on an ill-formed Decl. As we will visit every clas

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. gribozavr added a parent revision: D66875: [Index] Marked a bunch of classes 'final'. Doing so removes one reason to create a custom FrontendAction. FrontendActions are not desirable b

[PATCH] D66875: [Index] Marked a bunch of classes 'final'

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. gribozavr added a reviewer: ilya-biryukov. gribozavr added a child revision: D66876: Indexing: create PP callbacks in the ASTConsumer. This file defines multiple inheritance hierarchie

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

gribozavr created this revision. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Doing so removes the last reason to expose a FrontendAction from libIndex. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66877 Files: clang/lib/Index/IndexingAct

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. gribozavr added reviewers: ilya-biryukov, jkorous. Herald added a subscriber: dexonsmith. gribozavr added a parent revision: D66877: Moved the IndexDataConsumer::finis

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. gribozavr added reviewers: ilya-biryukov, jkorous. Herald added a subscriber: dexonsmith. gribozavr added a parent revision: D66878: [Index] Stopped wrapping Frontend

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

gribozavr marked 2 inline comments as done. gribozavr added inline comments. Comment at: clang/lib/Index/IndexingAction.cpp:77 +IndexCtx->getDataConsumer().setPreprocessor(PP); +PP->addPPCallbacks(std::make_unique(IndexCtx)); + } ilya-biryukov wrote: > T

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

gribozavr marked 4 inline comments as done. gribozavr added inline comments. Comment at: clang-tools-extra/clangd/index/IndexAction.cpp:217 std::unique_ptr Includes; + index::IndexingOptions Opts; std::unique_ptr PragmaHandler; ilya-biryukov wrote: > Are t

[PATCH] D66884: Removed dead code from clang/AST/NSAPI.h

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66884 Files: clang/include/clang/AST/NSAPI.h clang/lib/AST/NSAPI.cpp Index: clang/lib/AST/NSAPI.cpp ==

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

gribozavr added inline comments. Comment at: clang/include/clang/Index/IndexingAction.h:60 + +inline std::unique_ptr createIndexingASTConsumer( +std::shared_ptr DataConsumer, jkorous wrote: > Why not use default argument instead of overloading? Writing a whol

[PATCH] D66884: Removed dead code from clang/AST/NSAPI.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL370298: Removed dead code from clang/AST/NSAPI.h (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

[PATCH] D66875: [Index] Marked a bunch of classes 'final'

gribozavr added a comment. Committed as r370321. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66875/new/ https://reviews.llvm.org/D66875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D66876: Indexing: create PP callbacks in the ASTConsumer

gribozavr added a comment. Committed as r370323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66876/new/ https://reviews.llvm.org/D66876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D66877: Moved the IndexDataConsumer::finish call into the IndexASTConsumer from IndexAction

gribozavr closed this revision. gribozavr marked an inline comment as done. gribozavr added a comment. Committed as r370336. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66877/new/ https://reviews.llvm.org/D66877 ___

[PATCH] D66878: [Index] Stopped wrapping FrontendActions in libIndex and its users

gribozavr marked 2 inline comments as done. gribozavr added a comment. Committed as r370337. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66878/new/ https://reviews.llvm.org/D66878 ___ cfe-commits mai

[PATCH] D66879: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored clients to use it instead of inventing their own solution

This revision was automatically updated to reflect the committed changes. Closed by commit rL370338: [Index] Added a ShouldSkipFunctionBody callback to libIndex, and refactored… (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66947: Changed FrontendActionFactory::create to return a std::unique_ptr

gribozavr created this revision. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66947 Files: clang-tools-extra/clang-doc/ClangDoc.cpp clang-tools-extra/clang-include-fixer/find

<    2   3   4   5   6   7   8   9   10   11   >