gribozavr2 added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/WatchedLiteralsSolver.cpp:332
+
+ if (LeftSubVar == RightSubVar) {
+ // `X <=> (A <=> A)` is equvalent to `X` which is already in
----------------
xazax.hun wrote:
> xazax.hun wrote:
> > I wonder why this simplification is done here only for
> > `BiconditionalValue`. Other operations seem to not do these sorts of
> > simplifications. Also, when would we take this branch? `getOrCreateIff` has
> > a special case when both operands are the same.
> Oh, looking at the other patch I see it mentioning desugaring. So can
> desugaring also introduce `Biconditional`s?
It is also necessary in the other cases due to the precondition of
`addClause()`, I'm adding that special handling in a separate patch:
https://reviews.llvm.org/D130522
We would take this branch when someone avoids using the DataflowContext API. So
not extremely likely at the moment, but it is a latent bug that can be exposed
by some future refactoring.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130519/new/
https://reviews.llvm.org/D130519
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
