gribozavr2 added inline comments.
================
Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:231
+ // parameters still need to be given `StorageLocation`s anyway, so this code
+ // will need to be generalized later.
+ for (; ArgIt != ArgEnd; ++ParamIt, ++ArgIt) {
----------------
The Clang AST includes argument expressions for defaulted arguments, so I
believe there shouldn't be anything left to do here, it should just work.
================
Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:3896
+ *cast<BoolValue>(Env.getValue(*FooDecl, SkipPast::None));
+ EXPECT_FALSE(Env.flowConditionImplies(FooVal));
+ },
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130306/new/
https://reviews.llvm.org/D130306
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
