gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land.
LGTM with all comments addressed. ================ Comment at: clang-tools-extra/test/clang-tidy/bugprone-posix-return.cpp:169 int posix_fadvise(int fd, off_t offset, off_t len, int advice); +int pthread_create(pthread_t *thread, const pthread_attr_t *attr, void *(*start_routine)(void *), void *arg); ---------------- Maybe pick a simpler function for this test, like pthread_yield? ================ Comment at: clang-tools-extra/test/clang-tidy/bugprone-posix-return.cpp:191 int posix_fadvise(int fd, off_t offset, off_t len, int advice); + int pthread_create(pthread_t *thread, const pthread_attr_t *attr, void *(*start_routine)(void *), void *arg); ---------------- Ditto, pthread_yield would be simpler to declare. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66627/new/ https://reviews.llvm.org/D66627 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
