[PATCH] D66143: Don't use std::errc

This revision was automatically updated to reflect the committed changes. Closed by commit rL368739: Don't use std::errc (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1627693 , @Hahnfeld wrote: > In D65819#1627638 , @ABataev wrote: > > > In D65819#1627631 , @Hahnfeld > > wrote: > > > > > In D65819#162762

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215214. ABataev added a comment. Reworked to keep partial linking to make original host object available for analysis without unbundling. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D658

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. Do we really need to map such variables? According to standard, "The map clause specifies how an original list item is mapped from the current task’s data environment to a corresponding list item in the device data environment of the device identified by the construct."

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630245 , @jdenny wrote: > In D66247#1630196 , @ABataev wrote: > > > Do we really need to map such variables? According to standard, "The map > > clause specifies how an original

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630287 , @jdenny wrote: > In D66247#1630262 , @ABataev wrote: > > > In D66247#1630245 , @jdenny wrote: > > > > > In D66247#1630196

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630333 , @jdenny wrote: > In D66247#1630321 , @ABataev wrote: > > > Try `map(a) firstprivate(a) defaultmap(scalar:tofrom)`, where `a` is `int`, > > for example. The variable must

[PATCH] D66247: [OpenMP] Fix target map for unused variables

ABataev added a comment. In D66247#1630398 , @jdenny wrote: > In D66247#1630352 , @ABataev wrote: > > > Yes, just realized that, defaultmap does not affect explicit firstprivates. > > Then just check `map(a) firstp

[PATCH] D65835: [OpenMP] Permit map with DSA on combined directive

ABataev added a comment. Why there are the changes from the another patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65835/new/ https://reviews.llvm.org/D65835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215399. ABataev added a comment. Fixed comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c test/Driver/clang-offload-bundler.c.o

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev added a comment. In D65819#1631410 , @Hahnfeld wrote: > The code changes look good to me, but the test doesn't pass on x86. We've > faced the same problem when `clang-offload-bundler` was initially committed > and the current testing is the best

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

ABataev created this revision. ABataev added reviewers: Hahnfeld, hfinkel. Herald added a reviewer: jdoerfert. Herald added a project: clang. Make the test more portable and do not rely on the pre-bundled object file. Repository: rC Clang https://reviews.llvm.org/D66296 Files: test/Driver/

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369015: [BUNDLER]Improve the test, NFC. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

ABataev updated this revision to Diff 215421. ABataev added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65819/new/ https://reviews.llvm.org/D65819 Files: test/Driver/clang-offload-bundler.c tools/clang-offload-bundler/ClangOffloadBundler.

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369019: [Driver][Bundler] Improve bundling of object files. (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINC

[PATCH] D66296: [BUNDLER]Improve the test, NFC.

ABataev added a comment. In D66296#1632003 , @azharudd wrote: > Looks like this is failing on Darwin: > > http://green.lab.llvm.org/green/job/clang-stage1-cmake-RA-incremental/1193/consoleFull#-2382751928254eaf0-7326-4999-85b0-388101f2d404 > > > /Users/

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#1619958 , @sdmitriev wrote: > As I understand ‘atexit’ solution would be target dependent (‘__cxa_atexit’ > on Linux and ‘atexit’ on Windows) whereas @llvm.global_ctors/dtors variables > offer similar and platform neutr

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added a comment. In D64943#1633170 , @lebedev.ri wrote: > In D64943#1633164 , @ABataev wrote: > > > In D64943#1619958 , @sdmitriev > > wrote: > > > > > As I understa

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added a comment. Sorry for the delay, Lingda. I tried to find some better solution for this. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponen

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8739 +/// // For each component specified by this mapper: +/// if (currentComponent.hasMapper()) +/// (*currentComponent.Mapper())(rt_mapper_handle, arg_base, arg_begin, lild

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* MaskRay wrote: > @ABataev The mangling scheme of __float128 is broken on x86 befor

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* MaskRay wrote: > ABataev wrote: > > MaskRay wrote: > > > @ABataev The mangling sch

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && Hm

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && jd

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && jd

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && jd

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && jd

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && jd

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && Ma

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1594 + !Context.getTargetInfo().hasFloat128Type() && + Context.getTargetInfo().getLongDoubleWidth() != 128) || (Ty->isIntegerType() && Context.getTypeSize(Ty) == 128 && jd

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8515 "%0 is not supported on this target">; +def err_type_not_equivalent : Error< + "%0 is not equivalent between host and target">; No, this message shall tell someth

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64289: [OpenMP] Fix 128-bit long double support on target

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1596 << Ty << E->getSourceRange(); + if (Ty->isRealFloatingType()) { +llvm::APFloatBase::Semantics Sem = llvm::APFloatBase::SemanticsToEnum( jdenny wrote: > ABataev wrote: > >

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev created this revision. ABataev added reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: jdoerfert, jfb, guansong, rnkovacs. Herald added a project: clang. Some OpenMP clauses rely on the values of the variables. If the variable

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* MaskRay wrote: > ABataev wrote: > > MaskRay wrote: > > > ABataev wrote: > > > > Ma

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574540 , @NoQ wrote: > I don't know much about OpenMP, but i guess i can help with the CFG a bit. Thanks a lot! > I strongly recommend adding a few direct tests for the CFG so

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added a comment. The scheme itself looks good in general. Just as an improvement, it would be good to use coloring for the feature status. Also, what's the difference between claimed, mostly done and done? Comment at: clang/docs/OpenMPSupport.rst:153 ++

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added a comment. In D64375#1574698 , @jdoerfert wrote: > In D64375#1574662 , @ABataev wrote: > > > The scheme itself looks good in general. > > > Good. Once we agreed on a scheme we can improve the actual pr

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:161 ++--+--+--++ +| memory mangagement | memory alloca

[PATCH] D64277: [X86][PowerPC] Support -mlong-double-128

ABataev added inline comments. Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79 } - -// CHECK: define weak void @__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]* ABataev wrote: > MaskRay wrote: > > ABataev wrote: > > > MaskRay wrote: > > > > AB

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: lib/Analysis/CFG.cpp:4746-4750 + D->for_each_used_expr([this, &B](Expr *E) { +assert(E && "Expected expression."); +if (CFGBlock *R = Visit(E)) + B = R; + }); NoQ

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1574981 , @NoQ wrote: > Ok, so i think i more or less understand where this is going and i like it! > My only concern about making sure that used-expressions don't appear in both

[PATCH] D64423: [OpenMP] Simplify getFloatTypeSemantics

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG, but I agree, some general description would be good Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64423/new/ https://reviews.llvm.org/D64423 _

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev added a comment. In D64356#1576813 , @NoQ wrote: > Something like this: > > F9509417: photo_2019-07-09_12-21-46.jpg > > Like, you can construct a CFG for an arbitrary statement. CFG₁ is the CFG for > xxx() and C

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:205 ++--+--+--++ +| device extension | clause: devic

[PATCH] D64526: [NFC] Unforget a colon in a few CHECK: directives.

ABataev added inline comments. Comment at: clang/test/OpenMP/sections_lastprivate_codegen.cpp:31 + +// FIXME: This line doesn't work. // CHECK [[CAP_MAIN_TY:%.+]] = type { i{{[0-9]+}}*, [2 x i{{[0-9]+}}]*, [2 x [[S_FLOAT_TY]]]*, [[S_FLOAT_TY]]*, i{{[0-9]+}}* }

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev updated this revision to Diff 209042. ABataev added a comment. Improved code. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64356/new/ https://reviews.llvm.org/D64356 Files: include/clang/AST/OpenMPClause.h include/clang/AST/StmtOpenMP.h lib/AST/Op

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

ABataev marked an inline comment as done. ABataev added a comment. In D64356#1579154 , @NoQ wrote: > Ugh, i forced a lot of boilerplate on you. Hope it was worth it >.< > > Thank you!~ No problems, thanks for the review! Comment at: t

[PATCH] D64375: [OpenMP][Docs] Provide implementation status details

ABataev added inline comments. Comment at: clang/docs/OpenMPSupport.rst:207 ++--+--+--++ +| device extension | clause: in_re

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8114 + } else { +LValue VarLVal = CGF.EmitLValueForField(VDLVal, It->second); +RValue VarRVal = CGF.EmitLoadOfLValue(VarLVal, RD->getLocation()); I think you csn use `

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ https://reviews.llvm.org/D64558 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

ABataev added a comment. In D64558#1580361 , @DavidTruby wrote: > I don't have commit access so can't commit this myself, could you do it for > me? Thanks Sure, thanks for the patch! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64558/new/ ht

[PATCH] D64558: Added mapping for pointers captured in Lambdas in OpenMP target regions

This revision was automatically updated to reflect the committed changes. Closed by commit rL365777: Added mapping for pointers captured in Lambdas in OpenMP target regions, (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D64356: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL365786: [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP… (authored by ABataev, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/ https://reviews.llvm.org/D61522 ___

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; gtbercea wrote: > ABataev wro

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:9291 + if (CGM.getLangOpts().OpenMPSimd || CGM.getLangOpts().OpenMPIsDevice || + (OffloadEntriesInfoManager.empty() && !HasEmittedDeclareTargetRegion)) +return nullptr; Missed ch

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added a comment. Looks good, in general. Just one more question: will __tgt_register_requires be emitted if only -fopenmp is used? If -fopenmp-targets is not provided, this function should not be called, I think, because we're not going to use offloading at all in this case and __tgt_re

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev added inline comments. Comment at: lib/Frontend/CompilerInvocation.cpp:2840 Opts.OpenMP && Args.hasArg(options::OPT_fopenmp_is_device); + Opts.OpenMPHasTargets = + Opts.OpenMP && Args.hasArg(options::OPT_fopenmp_targets_EQ); We already have `

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

ABataev accepted this revision. ABataev added a comment. LG. Please, commit it only after the runtime part is committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60568/new/ https://reviews.llvm.org/D60568 ___ cf

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

ABataev added a comment. In D61509#1512293 , @Meinersbur wrote: > 1. Is there a diagnostic that would point to the `omp` token? As much as I > like complete info (such as SourceLoc of semicolons), I cannot think of a use > case for it. > 2. I would like

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

ABataev added a comment. Tests? Comment at: lib/CodeGen/CGOpenMPRuntime.h:1628 + /// Return whether the unified_shared_memory has been specified. + virtual bool hasRequiresUnifiedSharedMemory(); }; Do we need to make it virtual? Repository: rC Clang CHA

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

ABataev added a comment. Just one question - why it is not the part of the whole patch for the unified memory support in clang? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62407/new/ https://reviews.llvm.org/D62407 __

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

ABataev added a comment. Just add it to the original patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62407/new/ https://reviews.llvm.org/D62407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D62407: [OpenMP] Add test for requires and unified shared memory clause with declare target link

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. After some offline discussion, the patch is accepted. It is required to demonstrate the changes in https://reviews.llvm.org/D60883 Repository: rC Clang CHANGES SINCE LAST ACTION https

[PATCH] D60883: [OpenMP] Avoid emitting maps for target link variables when unified memory is used

ABataev added a comment. Just one question after looking at the test: how we're going to link the device variable to its host copy? I think the address should be passed to the runtime, no? Comment at: lib/CodeGen/CGOpenMPRuntime.h:1628 + /// Return whether the unified_shared

[PATCH] D51554: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348930: [CUDA][OPENMP][NVPTX]Improve logic of the debug info support. (authored by ABataev, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION http

[PATCH] D55719: [OpenMP] parsing and sema support for 'close' map-type-modifier

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55719/new/ https://reviews.llvm.org/D55719 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D55861: [OpenMP] Fix data sharing analysis in nested clause

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55861/new/ https://reviews.llvm.org/D55861 ___ cfe-commits ma

[PATCH] D55892: [OpenMP] 'close' map-type-modifier code generation

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55892/new/ https://reviews.llvm.org/D55892 ___ cfe-commits ma

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev added inline comments. Comment at: docs/OpenMPSupport.rst:119 +time. To prevent this conservative choice and use at most 32 bits, +compile your program with the `-fopenmp-max-32bit-collapse-width`. + -fopenmp-optimistic-collapse Comment

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:4429 Args.AddAllArgs(CmdArgs, options::OPT_fopenmp_cuda_blocks_per_sm_EQ); + Args.AddLastArg(CmdArgs, options::OPT_fopenmp_optimistic_collapse, + options::OPT_fno_openmp_op

[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55928/new/ https://reviews.llvm.org/D55928 ___ cfe-commits ma

[PATCH] D55982: [OPENMP] Add support for explicit mapping of classes using 'this' pointer

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55982/new/ https://reviews.llvm.org/D55982 ___ cfe-commits ma

[PATCH] D56086: Pass a concrete triple for two OpenMP tests that depend on TLS

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56086/new/ https://reviews.llvm.org/D56086 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. The patch does not seem quite correct. I committed another fix for this problem. There is still the problem with the explicitly specified `shared` clause on `target teams` directive, but I don't think that it must cause some troubles. The variable still should not be tra

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1342076 , @jdenny wrote: > In D56113#1341940 , @ABataev wrote: > > > The patch does not seem quite correct. I committed another fix for this > > problem. > > > Thanks for the fix,

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1342878 , @jdenny wrote: > Hi Alexey, > > > In D56113#1342076 , @jdenny wrote: > > > >> In D56113#1341940 , @ABataev > >> wrote: > >> > >

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:9702 +static bool RejectConstNotMutableType(Sema &SemaRef, ValueDecl *D, + OpenMPClauseKind CKind, Functions must start from the small letters. =

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1344210 , @jdenny wrote: > In D56113#1342879 , @ABataev wrote: > > > But you will need another serie of patches for `reduction` and `linear` > > clauses to update their error mess

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345232 , @jdenny wrote: > In D56113#1345047 , @ABataev wrote: > > > In D56113#1344210 , @jdenny wrote: > > > > > In D56113#1342879

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345336 , @jdenny wrote: > In D56113#1345238 , @ABataev wrote: > > > >>> By the way, is there any value to keeping the predetermined shared for > > >>> const if -openmp-version=3.

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345372 , @jdenny wrote: > In D56113#1345337 , @ABataev wrote: > > > > In D56113#1345238 , @ABataev > > > wrote: > > > > > >> In D56113#1

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345529 , @jdenny wrote: > In D56113#1345238 , @ABataev wrote: > > > >>> By the way, is there any value to keeping the predetermined shared for > > >>> const if -openmp-version=3.

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345564 , @jdenny wrote: > In D56113#1345535 , @ABataev wrote: > > > In D56113#1345529 , @jdenny wrote: > > > > > In D56113#1345238

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added a comment. In D56113#1345588 , @jdenny wrote: > In D56113#1345578 , @ABataev wrote: > > > >>> By the way, LangOpts.OpenMP currently defaults to 0. Should it? > > >> > > >> Yes, it means it is disable

[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:9736 +static bool rejectConstNotMutableType(Sema &SemaRef, ValueDecl *D, + OpenMPClauseKind CKind, This function and the original code has a lot of com

<    1   2   3   4   5   6   7   8   9   10   >