ABataev added inline comments.
================
Comment at: test/OpenMP/nvptx_unsupported_type_codegen.cpp:79
}
-
-// CHECK: define weak void
@__omp_offloading_{{.+}}foo{{.+}}_l75([[BIGTYPE:.+]]*
----------------
ABataev wrote:
> MaskRay wrote:
> > ABataev wrote:
> > > MaskRay wrote:
> > > > ABataev wrote:
> > > > > MaskRay wrote:
> > > > > > @ABataev The mangling scheme of __float128 is broken on x86 before
> > > > > > this patch. For some reason the two lines no longer apply.. I
> > > > > > assume you can fix this test properly :)
> > > > > You mean, these lines are not generated anymore? If so, it means that
> > > > > you broke compatibility between the host and device codegen with this
> > > > > patch.
> > > > The two lines are not generated. Can you help fix the test? The
> > > > mangling scheme of __float128 is incorrect without this patch. If the
> > > > test relies on that, it should be fixed. I know little about
> > > > openmp+nvidia to understand what's going on..
> > > Sure, will try to send additional changes next week, most probably on
> > > Monday. Does this work for you?
> > Thanks!
> Hi, I have a fix for the problem revealed with your patch, will commit it
> tomorrow. After this, I hope, the problem with the test will disappear.
I fixed the problem, try to update the patch, the test should pass with your
changes.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64277/new/
https://reviews.llvm.org/D64277
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
