[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

mboehme added a comment. In D153366#4441758 , @sammccall wrote: >> Would you like me to review https://reviews.llvm.org/D153469 or should we >> wait for this patch to converge first? > > Similarly it'd be great to get high-level feedback there: whether t

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

hokein updated this revision to Diff 533873. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153259/new/ https://reviews.llvm.org/D153259 Files: clang-tools-extra/cl

[PATCH] D153469: [dataflow] Replace most BoolValue subclasses with references to Formula (and AtomicBoolValue => Atom and BoolValue => Formula where appropriate)

mboehme added a comment. Just some top-level comments to begin with. In D153469#4439770 , @sammccall wrote: > Here we start to see benefits: Value becomes less reliant on inheritance, > flow conditions are no longer Values that can uselessly bear proper

[clang-tools-extra] 7298bcf - [clangd] Store offsets in MacroOccurrence

Author: Haojian Wu Date: 2023-06-23T09:21:08+02:00 New Revision: 7298bcf7f06145e2d4dfdb177b94dc42fc95dc55 URL: https://github.com/llvm/llvm-project/commit/7298bcf7f06145e2d4dfdb177b94dc42fc95dc55 DIFF: https://github.com/llvm/llvm-project/commit/7298bcf7f06145e2d4dfdb177b94dc42fc95dc55.diff LO

[PATCH] D153259: [clangd] Store offsets in MacroOccurrence

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7298bcf7f061: [clangd] Store offsets in MacroOccurrence (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D143241: [Clang] Reset FP options before function instantiations

sepavloff added a comment. In D143241#4441812 , @rjmccall wrote: > Hmm. Why are we clearing the FP pragma stack instead of saving the old > context onto it and then restoring after instantiation? I don't think > semantic analysis ever depends on enclo

[PATCH] D153616: [clang][Interp] Create a new local variable in visitLambdaExpr()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move the logic for initialization of a lambda int

[clang] dd639eb - [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator.

Author: Balázs Kéri Date: 2023-06-23T10:04:01+02:00 New Revision: dd639eb15aacfc865409915516f52385c4381923 URL: https://github.com/llvm/llvm-project/commit/dd639eb15aacfc865409915516f52385c4381923 DIFF: https://github.com/llvm/llvm-project/commit/dd639eb15aacfc865409915516f52385c4381923.diff L

[PATCH] D153424: [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd639eb15aac: [clang][ASTImporter] Add import of CXXRewrittenBinaryOperator. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153424/new

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

DavidSpickett added a comment. > Does that make it clearer? (I still suspect that people won't understand what > is meant by "environment" here but I can't think of a better explanation). "clang triple environment" into Google gets you the cross compilation guide and the Triple class docs so "e

[PATCH] D153491: [dataflow] Avoid copying environment

xazax.hun added a comment. This sounds extremely error-prone to me. In case copying the analysis state has side effects like this, I would argue we want such operations to be really explicit. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D152263: [clang][CFG] Add support for partitioning CFG into intervals.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/IntervalPartition.cpp:26 + + std::queue Worklist; + for (const CFGBlock *S : Header.succs()) ymandel wrote: > xaza

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein updated this revision to Diff 533896. hokein marked 2 inline comments as done. hokein added a comment. Herald added a subscriber: arphaman. address comments: - move the filtering in analysis API - add an actual -edit lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/tool/IncludeCleaner.cpp:160 auto Results = analyze(AST.Roots, PP.MacroReferences, PP.Includes, &PI, SM, HS); if (!Insert) kadircet wrote: > we actually want to perform

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

owenpan added inline comments. Comment at: clang/lib/Format/Format.cpp:3571-3585 + // Don't make replacements that replace nothing. This can affect e.g. the + // output of clang-format with the --output-replacements-xml option. + tooling::Replacements NonNoOpFixes; + for (con

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

tbaeder added inline comments. Comment at: clang/test/Lexer/unicode.c:30 -int _; +int a; Are these changes only for the case where we compile as c++? I know lots of C (and c++?) projects use `_` as GNU gettext identifier to mark a translatable strin

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:164 AST.getHeuristicResolver())) { Result.insert(canonicalRenameDecl(D)); } before calling `canonicalRenameDecl` here we can do a `D = pickInteres

[PATCH] D151923: [APFloat] Add APFloat semantic support for TF32

This revision was automatically updated to reflect the committed changes. Closed by commit rG55c2211a233e: [APFloat] Add APFloat semantic support for TF32 (authored by jfurtek, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[clang] 55c2211 - [APFloat] Add APFloat semantic support for TF32

Author: Jeremy Furtek Date: 2023-06-23T10:54:49+02:00 New Revision: 55c2211a233e11179048cf58778f40e5a62f444a URL: https://github.com/llvm/llvm-project/commit/55c2211a233e11179048cf58778f40e5a62f444a DIFF: https://github.com/llvm/llvm-project/commit/55c2211a233e11179048cf58778f40e5a62f444a.diff

[PATCH] D135476: [clang-tidy] Support concepts in `bugprone-forwarding-reference-overload`

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. May require rebase, but looks fine. Release notes entry should be added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135476/new/ https://r

[PATCH] D153617: [clangd] Fix an assertion failure in NamedDecl::getName during the prepareRename

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. getName method required to be ca

[PATCH] D153476: [dataflow] document & test determinism of formula structure

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Arena.cpp:13 +// Compute a canonical key for an unordered poir of operands, so that we +// can intern (A & B) and (B

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin added inline comments. Comment at: clang/test/Lexer/unicode.c:30 -int _; +int a; tbaeder wrote: > Are these changes only for the case where we compile as c++? I know lots of C > (and c++?) projects use `_` as GNU gettext identifier to mark a

[PATCH] D153488: [dataflow] HTMLLogger: meaningful names for flow condition variables

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Should we have some documentation or tooltip explaining the users what the meaning of those names are? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D153584: [dataflow] Make SAT solver deterministic

xazax.hun added a comment. Is there a measurable perf cost for this determinism? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153584/new/ https://reviews.llvm.org/D153584 ___ cfe-commits mailing list cf

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

michaelplatings updated this revision to Diff 533904. michaelplatings added a comment. Tweak warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https://reviews.llvm.org/D153430 Files: clang/include/clang/Basic/DiagnosticCo

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. For first experiment I have made patch D153612 that adds a `NoteTag` to "all" standard function calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152436/new/ https://reviews.llvm.org

[PATCH] D153476: [dataflow] document & test determinism of formula structure

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp:169 + auto &BOr = A.makeOr(BY, BX); + auto &BEqual = A.makeEquals(BOr, BAnd); + EXPECT_EQ(Expected, llvm::to_string(B.getFormula(BEqual))); Shouldn't these lines

[PATCH] D153476: [dataflow] document & test determinism of formula structure

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/ArenaTest.cpp:165-169 + auto &BX = A.create(); + auto &BY = A.create(); + auto &BAnd = A.makeAnd(BX, BY); + auto &BOr = A.makeOr(BY, BX); + auto &BEqual = A.makeEquals(BOr, BAnd); --

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/test/Analysis/errno-stdlibraryfunctions-notes.c:17 access("path", 0); - // expected-note@-1{{Assuming that function 'access' is successful, in this case the value 'errno' may be undefined after the call and should not be used

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. In D152436#4438956 , @NoQ wrote: > Uh-oh, looks like I'm not paying nearly enough attention to this discussion > (sorry about that!!) > > I'm somewhat skeptical of the decision made in D151225 >

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. Thanks for the update! LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https://reviews.llvm.org/D153430 _

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

DavidSpickett accepted this revision. DavidSpickett added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153430/new/ https://reviews.llvm.org/D153430 ___ cfe-commits mailing list cfe-commi

[clang] 041ffc1 - [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

Author: Michael Platings Date: 2023-06-23T11:54:29+01:00 New Revision: 041ffc155fd7d154af1ea59853fbe5932d0216d3 URL: https://github.com/llvm/llvm-project/commit/041ffc155fd7d154af1ea59853fbe5932d0216d3 DIFF: https://github.com/llvm/llvm-project/commit/041ffc155fd7d154af1ea59853fbe5932d0216d3.di

[PATCH] D153430: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG041ffc155fd7: [Clang][Driver] Warn on invalid Arm or AArch64 baremetal target triple (authored by michaelplatings). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 63342ae - Fix a failing assertion with implicit function definitions

Author: Aaron Ballman Date: 2023-06-23T07:02:21-04:00 New Revision: 63342ae4b8f7573fd03fdb6eb38d55097b9a6922 URL: https://github.com/llvm/llvm-project/commit/63342ae4b8f7573fd03fdb6eb38d55097b9a6922 DIFF: https://github.com/llvm/llvm-project/commit/63342ae4b8f7573fd03fdb6eb38d55097b9a6922.diff

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This covers - P2558R2 (C++, wg21.link/P2558 ) - N2701 (C, https://www.open-std.org/jtc1/s

[PATCH] D153576: [Headers] Fix up some conditionals

pengfei added a comment. In D153576#4442096 , @craig.topper wrote: > The mulx function being 32-bit mode only is also true in gcc. It probably > won't generate a mulx instruction on x86-64. Maybe that's why it was 32-bit > only? But it should still be

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:360 +for (const auto &Ref : Refs) { + SourceLocation Loc = SM.getLocForStartOfFile(SM.getMainFileID()

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:846 +void SymbolCollector::setSymbolProviders( +const Symbol &S, const llvm::SmallVector Headers) { + if (Opts.CollectIncludePath && kadircet wrote: > what about

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

abhina.sreeskantharajan added a comment. The CI shows the following lit tests are failing due to this patch which should be resolved first Failed Tests (7): Clang :: CodeGen/SystemZ/zos-alignment.c Clang :: CodeGen/target-data.c Clang :: CodeGen/wchar-size.c Clang :: Driver/zos-comp-cxx

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

hokein updated this revision to Diff 533926. hokein marked 2 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147034/new/ https://reviews.llvm.org/D147034 Files: clang-tools-extra/cl

[clang-tools-extra] 6585dd3 - [clangd] Replace the hacky include-cleaner macro-reference implementation.

Author: Haojian Wu Date: 2023-06-23T14:08:55+02:00 New Revision: 6585dd3b83738789dff5ca82008efdf84c9b922c URL: https://github.com/llvm/llvm-project/commit/6585dd3b83738789dff5ca82008efdf84c9b922c DIFF: https://github.com/llvm/llvm-project/commit/6585dd3b83738789dff5ca82008efdf84c9b922c.diff LO

[PATCH] D147034: [clangd] Replace the hacky include-cleaner macro-reference implementation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6585dd3b8373: [clangd] Replace the hacky include-cleaner macro-reference implementation. (authored by hokein). Repository: rG LLVM Github Monorepo

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. While we wait for Richard's response... @Fznamznon what are your thoughts on wrapping all `ConstantExpr` that span immediate invocations with redundant `ExprWithCleanups` per Richard's suggestions? I would be comfortable LGTMing such a change even if we choose to r

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > While we wait for Richard's response... @Fznamznon what are your thoughts on > wrapping all ConstantExpr that span immediate invocations with redundant > ExprWithCleanups per Richard's suggestions? > This bug looks scary enough to me to warrant a fix asap. Agree. I

[clang] 82e29c6 - Fixed failed assertion w/attribute on anon unions

Author: Aaron Ballman Date: 2023-06-23T08:58:37-04:00 New Revision: 82e29c65e3112fd5d7ed71250bf53ffaec87c2be URL: https://github.com/llvm/llvm-project/commit/82e29c65e3112fd5d7ed71250bf53ffaec87c2be DIFF: https://github.com/llvm/llvm-project/commit/82e29c65e3112fd5d7ed71250bf53ffaec87c2be.diff

[clang] d7feba7 - HIP: Directly call trunc builtins

Author: Matt Arsenault Date: 2023-06-23T09:11:06-04:00 New Revision: d7feba74b649cb8aabc0cb09b9bef5d79659e31c URL: https://github.com/llvm/llvm-project/commit/d7feba74b649cb8aabc0cb09b9bef5d79659e31c DIFF: https://github.com/llvm/llvm-project/commit/d7feba74b649cb8aabc0cb09b9bef5d79659e31c.diff

[PATCH] D153293: [clang][WebAssembly] support wasm32-wasi shared libraries

dicej added a comment. @sbc100 @sunfish I believe I've addressed all your feedback so far. Anything else you'd like me to do before we call this ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153293/new/ https://reviews.llvm.org/D153293 __

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533941. IncludeGuardian added a comment. Herald added subscribers: vkmr, kadircet, arphaman, emaste. Herald added a reviewer: bollu. Herald added a reviewer: aartbik. Herald added a reviewer: MaskRay. Herald added a project: clang-tools-extra. Fix comp

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian added a comment. @barannikov88 no it's not. I was going to commit separately to keep the change small, but it turns out that if I move this to the source file there are no additional changes needed. SmallVector.h has now been moved to Error.cpp as well. Repository: rG LLVM G

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4989 if (SS->getCond()->isValueDependent()) { if (!EvaluateDependentExpr(SS->getCond(), Info)) return ESR_Failed; shafik wrote: > As far as I can tell `Value` will s

[clang] 940c94e - [clang][Sema] Fix comments to conform to bugprone-argument-comment (NFC)

Author: Takuya Shimizu Date: 2023-06-23T22:25:04+09:00 New Revision: 940c94e1c1b99511630b6f61890ac54161b5829c URL: https://github.com/llvm/llvm-project/commit/940c94e1c1b99511630b6f61890ac54161b5829c DIFF: https://github.com/llvm/llvm-project/commit/940c94e1c1b99511630b6f61890ac54161b5829c.diff

[PATCH] D152796: [clang][Sema] Fix diagnostic message for unused constant varialbe templates

hazohelet marked an inline comment as done. hazohelet added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1385 + Diag(DiagD->getLocation(), diag::warn_unused_template) + << /*variable*/ 1 << DiagD; } else if (DiagD->getType().isConstQualified

[PATCH] D149246: [RISCV] Relax rules for ordering s/z/x prefixed extensions in ISA naming strings

asb added a comment. Herald added a subscriber: wangpc. All feedback so far has been positive and this has two LGTMs, but I also recognise this patch has been left for a while. Heads up that I intend to commit this towards the end of the working day Monday UK time unless anyone has any objectio

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:2024 if (const VarDecl *VD = dyn_cast(D)) { +if (D->isPlaceholderVar()) + return !VD->hasInit(); Why would we get here? Doesn't line 1995 pick this up? Or am I missing where

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL updated this revision to Diff 533952. PiotrZSL added a comment. This revision is now accepted and ready to land. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144828/new/ https://reviews.llvm.org/D144828 Files: clang-tools-extra/

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

barannikov88 added a comment. In D153229#134 , @IncludeGuardian wrote: > @barannikov88 no it's not. I was going to commit separately to keep the > change small, but it turns out that if I move this to the source file there > are no additional chang

[clang] 7a38b3b - [clang-format] Respect ColumnLimit 0 line breaks in inline asm

Author: Emilia Kond Date: 2023-06-23T17:30:24+03:00 New Revision: 7a38b3bfeb5623fb970a03ed9f295288802f4506 URL: https://github.com/llvm/llvm-project/commit/7a38b3bfeb5623fb970a03ed9f295288802f4506 DIFF: https://github.com/llvm/llvm-project/commit/7a38b3bfeb5623fb970a03ed9f295288802f4506.diff L

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7a38b3bfeb56: [clang-format] Respect ColumnLimit 0 line breaks in inline asm (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D153510: [Clang] Check type support for local variable declaration

eopXD updated this revision to Diff 533961. eopXD added a comment. Extract RVV type check as a separate function as Craig has commented. Add test case from Aaron's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/ https://reviews.l

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533966. IncludeGuardian added a comment. Fix missing include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: llvm/unittests/Support/CompressionTest.c

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen updated this revision to Diff 533967. HaohaiWen added a comment. Restore DWARFContext.cpp since D153602 has fixed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet updated this revision to Diff 533964. hazohelet added a comment. Address review comment NFC - make some arguments conform to bugprone-argument-comments - edit release note text CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151720/new/ https://reviews.llvm.org/D151720 Files:

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet marked 4 inline comments as done. hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:983 EnableNewConstInterp(C.getLangOpts().EnableNewConstInterp), - BottomFrame(*this, SourceLocation(), nullptr, nullptr, CallRef()), +

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533968. IncludeGuardian added a comment. Add back all includes (bad arc change) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extra/cla

[PATCH] D150978: [clang][Sema] Add CodeCompletionContext::CCC_ObjCClassForwardDecl

dgoldman updated this revision to Diff 533969. dgoldman marked an inline comment as done. dgoldman added a comment. Add a contextAllowsHeaderInsertion helper to clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150978/new/ https://reviews.llvm.o

[PATCH] D153267: [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

hazohelet updated this revision to Diff 533971. hazohelet marked an inline comment as done. hazohelet edited the summary of this revision. hazohelet added a comment. Address comments from @cjdb and @aaron.ballman - Remove unnecessary cast to void in test - Add release note CHANGES SINCE LAST AC

[PATCH] D153639: [clang-tidy] Document modernize-raw-string-literal check options

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add missing documentati

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. When parsing a requires clause, the Unwrappe

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

rymiel added a comment. @HazardyKnusperkeks I'm not sure why it didn't recurse already, given that you even documented that it doesn't, but I chose to trust in the Beyoncé rule. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153641/new/ https://rev

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam updated this revision to Diff 533981. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/ https://reviews.llvm.org/D153590 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clan

[PATCH] D95299: Fix truncated __OPENMP_NVPTX__ preprocessor condition

capn added a comment. Can a committer go ahead and land this please? I'm running into this warning for any CUDA code compiled by Clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95299/new/ https://reviews.llvm.org/D95299 _

[PATCH] D153639: [clang-tidy] Document modernize-raw-string-literal check options

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0f6fd24dc12: [clang-tidy] Document modernize-raw-string-literal check options (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153639/n

[clang-tools-extra] b0f6fd2 - [clang-tidy] Document modernize-raw-string-literal check options

Author: Piotr Zegar Date: 2023-06-23T16:14:15Z New Revision: b0f6fd24dc12cf860e6b01f417badb115c7535ce URL: https://github.com/llvm/llvm-project/commit/b0f6fd24dc12cf860e6b01f417badb115c7535ce DIFF: https://github.com/llvm/llvm-project/commit/b0f6fd24dc12cf860e6b01f417badb115c7535ce.diff LOG: [

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153590/new/ https://reviews.llvm.org/D153590 ___ cfe-commits mailing list cfe-comm

[PATCH] D153229: [llvm] Move StringExtras.h include from Error.h to Error.cpp

IncludeGuardian updated this revision to Diff 533989. IncludeGuardian added a comment. Fix missing includes for Windows-only files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153229/new/ https://reviews.llvm.org/D153229 Files: clang-tools-extr

[PATCH] D151697: [clang] Add test for CWG1710 and related issues

Endill added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151697/new/ https://reviews.llvm.org/D151697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman updated this revision to Diff 533993. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152720/new/ https://reviews.llvm.org/D152720 Files: clang-tools-ex

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:787 + // names like class and protocol names. + if (const auto *CD = dyn_cast(&RenameDecl)) +if (CD->getName() != IdentifierToken->text(SM)) kadircet wrote: > this spec

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

erichkeane added a comment. So I think I'm pretty confident that the only time we would call `EvaluateDependentExpr` is when we are in an error condition, so I'm convinced the fix 'as is' is incorrect. The check for noteSideEffect records that we HAVE a side effect, then returns if we are OK i

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

ilya-biryukov added a comment. In D153294#065 , @Fznamznon wrote: >> While we wait for Richard's response... @Fznamznon what are your thoughts on >> wrapping all ConstantExpr that span immediate invocations with redundant >> ExprWithCleanups per Ric

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

jrbyrnes added a comment. In D147732#4434557 , @arsenm wrote: > I think this may not hard break mesa. I believe mesa bypasses the intrinsic > creation API, and just declares the string name of the intrinsic. The type > name mangling suffix is technicall

[PATCH] D153649: [clang][Interp] Fix return statements with expresssion in void functions

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If the return type of a function is void, ReturnT

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 534018. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153370/new/ https://reviews.llvm.org/D153370 Files: clang/test/Driver/riscv-cpus.c llvm/docs/RISCVUsage.rst llvm/docs/ReleaseNotes.rst llvm/lib

[PATCH] D153649: [clang][Interp] Fix return statements with expresssion in void functions

tbaeder updated this revision to Diff 534021. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153649/new/ https://reviews.llvm.org/D153649 Files: clang/lib/AST/Interp/ByteCodeStmtGen.cpp clang/test/AST/Interp/functions.cpp Index: clang/test/AST/Interp/functions.cpp ==

[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

hokein created this revision. hokein added a reviewer: avl. Herald added a subscriber: hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo https://reviews.llv

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono updated this revision to Diff 534024. Sedeniono added a comment. As suggested by the reviewers, the noop fixes are now filtered only if the qualifier alignment passes are active. Also implemented the other minor refactorings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D153228: [clang-format] Fixed bad performance with enabled qualifier fixer.

Sedeniono marked 6 inline comments as done. Sedeniono added inline comments. Comment at: clang/lib/Format/Format.cpp:3476-3477 + + // Regarding the 16: Note that multiple passes are added in + // addQualifierAlignmentFixerPasses(). + SmallVector Passes; Hazard

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

alexhenrie added a comment. Herald added a project: All. Any update on this? The Wine project would like to omit the refptr symbols, see https://gitlab.winehq.org/wine/wine/-/merge_requests/3109 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://re

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

Sedeniono marked an inline comment as done. Sedeniono added a comment. @owenpan , @MyDeveloperDay Any opinion on the latest changes? Otherwise, since I do not have commit rights, someone needs to commit the changes to main (my name and mail: `Sedenion <39583823+sedeni...@users.noreply.github.co

[PATCH] D153510: [Clang] Check type support for local variable declaration

eopXD updated this revision to Diff 534025. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/ https://reviews.llvm.org/D153510 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp

[PATCH] D153653: [clang][Interp] Make CXXTemporaryObjectExprs leave a value behind

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. visitLocalInitializer() pops the pointer from the

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

craig.topper accepted this revision. craig.topper added inline comments. This revision is now accepted and ready to land. Comment at: llvm/docs/ReleaseNotes.rst:209 disassembler/assembler. +* Added support for the vendor-defined Xsfcie (SiFive SCIE) extension + disassembler/a

[PATCH] D144911: adding bf16 support to NVPTX

tra added a comment. The latest patch revision still fails on a few LLVM tests: Failed Tests (3): LLVM :: CodeGen/NVPTX/bf16-instructions.ll LLVM :: CodeGen/NVPTX/f16x2-instructions.ll LLVM :: CodeGen/NVPTX/math-intrins-sm80-ptx70.ll Comment at: llvm/lib/Target/N

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

isuckatcs added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:390 for (const Type *T : TypesToDelete) -ThrownExceptions.erase(T); +ThrownExceptions.erase({T, SourceLocation()}); PiotrZSL wrote: > isuckatcs wrot

[PATCH] D153298: [clang-tidy] Extend bugprone-exception-escape diagnostics

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp:390 for (const Type *T : TypesToDelete) -ThrownExceptions.erase(T); +ThrownExceptions.erase({T, SourceLocation()}); isuckatcs wrote: > PiotrZSL wrote

[clang] 62fa708 - [RISCV] Implement KCFI operand bundle lowering

Author: Sami Tolvanen Date: 2023-06-23T18:25:24Z New Revision: 62fa708ceb027713b386c7e0efda994f8bdc27e2 URL: https://github.com/llvm/llvm-project/commit/62fa708ceb027713b386c7e0efda994f8bdc27e2 DIFF: https://github.com/llvm/llvm-project/commit/62fa708ceb027713b386c7e0efda994f8bdc27e2.diff LOG:

[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

This revision was automatically updated to reflect the committed changes. Closed by commit rG62fa708ceb02: [RISCV] Implement KCFI operand bundle lowering (authored by samitolvanen). Herald added a subscriber: wangpc. Changed prior to commit: https://reviews.llvm.org/D148385?vs=531476&id=534032#

  1   2   >